Easy Scrap adds a new frame to the Scrap interface that shows you all items in your bags available for scrapping and lets you queue items.
Features:
- See all items you can scrap without having to look in your bags and search for even faster results.
- Queue up items and have them automatically placed into the scrapper when the scrapper is empty again.
- Create a keybinding for the scrap button. Look under Key Bindings->Addons->Easy Scrap
- Hide specific items you do not want to see in the "Eligible" tab by right clicking them.
- With the default filter automatically hides all gear that is used in an equipment set.
- Create custom filters to automatically ignore items. Leave a comment if you have a specific filter request.
If you want to macro the scrap button create a macro with the following text:
/click EasyScrap_ScrapKeybindFrame
Please report any weird behavior if you see any and always make sure you're not scrapping an item you want to keep.
Ever since the new update, anytime I mouse over something not a Player/NPC, as the tooltip is opening on my screen the game will do a split-second pause.
I also have this issue when scrapping items, that as the scrapping of said single item finishes, the game does a split-second pause/skip and my framerate at that moment shoots down from in the 130 range to a mere 65-70 and climbs back up til the next finishes scrapping.
I didn't have this issue using the previous version, or even with the workaround that the other player posted here in the comments, but now this is just how things are if I have the addon active.
In reply to Vx_Odessa_xV:
That's odd! The new version I've uploaded is pretty much identical to what has been posted below. I also havent touched anything regarding tooltips. Perhaps you could try doing the changes you did earlier to see if that fixes it again?
Sorry for the slow update everyone, I honestly didn't realize the addon would still be used by this many people. I've updated what I think are all the errors let me know if anything else is broken!
In reply to Loelalol:
Thanks for all the hard work!
Updated, and scrapped ~100 items. Works well so far. :)
In reply to Loelalol:
It's working now, but does not recognize all of my Tidespray Bracers. Please ignore. I can't delete the post else I would.
You can do a workaround to get the addon working until an official fix is done.
Head to your EasyScrap folder (e.g. Battle.Net\World of Warcraft\_retail_\Interface\AddOns\EasyScrap) and go to the Frames folder. Now open EasyScrapEditFilterFrame.lua in a text editor and add "-- " in front of the lines 16-21.
filterEntriesFrame:SetBackdrop({ -- bgFile="Interface\\FrameGeneral\\UI-Background-Marble", edgeFile='Interface/Tooltips/UI-Tooltip-Border', tile = false, tileSize = 16, edgeSize = 16, insets = { left = 4, right = 4, top = 4, bottom = 4 }}) filterEntriesFrame:SetBackdropBorderColor(.9, .9, .9, 1)turns in to
-- filterEntriesFrame:SetBackdrop({ -- -- bgFile="Interface\\FrameGeneral\\UI-Background-Marble", -- edgeFile='Interface/Tooltips/UI-Tooltip-Border', -- tile = false, tileSize = 16, edgeSize = 16, -- insets = { left = 4, right = 4, top = 4, bottom = 4 }}) -- filterEntriesFrame:SetBackdropBorderColor(.9, .9, .9, 1)Now repeat the same for the files EasyScrapFilterFrame.lua, EasyScrapItemFrame.lua, and EasyScrapMainFrame.lua. Note that it's the "SetBackDrop" and "SetBackdropBorderColor" you're looking for, not the "filterEntriesFrame" as that will change for each of the files.
diff patch to fix nil frame:SetBackdrop errors
Frames/EasyScrapEditFilterFrame.lua | 2 +- Frames/EasyScrapFilterFrame.lua | 2 +- Frames/EasyScrapItemFrame.lua | 2 +- Frames/EasyScrapMainFrame.lua | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Frames/EasyScrapEditFilterFrame.lua b/Frames/EasyScrapEditFilterFrame.lua index 51d366b..4241edf 100644 --- a/Frames/EasyScrapEditFilterFrame.lua +++ b/Frames/EasyScrapEditFilterFrame.lua @@ -10,7 +10,7 @@ editFilterFrame.header:SetFontObject('GameFontNormalLarge') editFilterFrame.header:SetText('Edit Filter') editFilterFrame.header:SetPoint('TOP', 0, -24) -local filterEntriesFrame = CreateFrame('Frame', nil, editFilterFrame) +local filterEntriesFrame = CreateFrame('Frame', nil, editFilterFrame, "BackdropTemplate") filterEntriesFrame:SetPoint('TOPLEFT', 12, -50) filterEntriesFrame:SetSize(273, 204) filterEntriesFrame:SetBackdrop({ diff --git a/Frames/EasyScrapFilterFrame.lua b/Frames/EasyScrapFilterFrame.lua index fd9c69d..11bb88a 100644 --- a/Frames/EasyScrapFilterFrame.lua +++ b/Frames/EasyScrapFilterFrame.lua @@ -10,7 +10,7 @@ filterFrame.header:SetFontObject('GameFontNormalLarge') filterFrame.header:SetText('Manage Filters') filterFrame.header:SetPoint('TOP', 0, -24) -local filterListFrame = CreateFrame('Frame', 'EasyScrapFilterListFrame', filterFrame) +local filterListFrame = CreateFrame('Frame', 'EasyScrapFilterListFrame', filterFrame, "BackdropTemplate") filterListFrame:SetPoint('TOPLEFT', 12, -50) filterListFrame:SetSize(273, 200) filterListFrame:SetBackdrop({ diff --git a/Frames/EasyScrapItemFrame.lua b/Frames/EasyScrapItemFrame.lua index c896319..2759a66 100644 --- a/Frames/EasyScrapItemFrame.lua +++ b/Frames/EasyScrapItemFrame.lua @@ -1,4 +1,4 @@ -local itemFrame = CreateFrame('Frame', 'EasyScrapItemFrame', EasyScrapMainFrame) +local itemFrame = CreateFrame('Frame', 'EasyScrapItemFrame', EasyScrapMainFrame, "BackdropTemplate") itemFrame:SetPoint('TOPLEFT', 12, -50) --itemFrame:SetPoint('BOTTOMRIGHT', -32, 42) itemFrame:SetSize(273, 172) diff --git a/Frames/EasyScrapMainFrame.lua b/Frames/EasyScrapMainFrame.lua index 3b4d971..0fec3cd 100644 --- a/Frames/EasyScrapMainFrame.lua +++ b/Frames/EasyScrapMainFrame.lua @@ -1,6 +1,6 @@ local EasyScrap = EasyScrap -local parentFrame = CreateFrame('Frame', 'EasyScrapParentFrame', ScrappingMachineFrame) +local parentFrame = CreateFrame('Frame', 'EasyScrapParentFrame', ScrappingMachineFrame, "BackdropTemplate") parentFrame:SetPoint('TOP', ScrappingMachineFrame, 'BOTTOM', 0, 16) parentFrame:SetSize(ScrappingMachineFrame:GetWidth()-16, 294) --264 parentFrame:EnableMouse(true)In reply to speedwayst4r:
the beast!
In reply to speedwayst4r:
what does this mean? Is this posting an error or a fix?
In reply to speedwayst4r:
Could you possibly document which file this code needs to be added to, and at which point? Many thanks.
In reply to speedwayst4r:
*edit*
ok my bad. this is a patchfile and I had to learn how to use a patchfile. Still I get this error:
diff: extra operand 'EasyScrapItemFrame.lua'
ok more edit.
apparently I dunno wtf I'm doing because I cant get patch or diff to work. Someone mind explaining to the dunce here?
In reply to JungleOrDodge:
file:
Frames\EasyScrapEditFilterFrame.luachange line 13 to:local filterEntriesFrame = CreateFrame('Frame', nil, editFilterFrame, "BackdropTemplate")file:
Frames\EasyScrapFilterFrame.luachange line 13 to:local filterListFrame = CreateFrame('Frame', 'EasyScrapFilterListFrame', filterFrame, "BackdropTemplate")file:
Frames\EasyScrapItemFrame.luachange line 1 to:local itemFrame = CreateFrame('Frame', 'EasyScrapItemFrame', EasyScrapMainFrame, "BackdropTemplate")file:Frames\EasyScrapMainFrame.luachange line 3 to:local parentFrame = CreateFrame('Frame', 'EasyScrapParentFrame', ScrappingMachineFrame, "BackdropTemplate")
Looking at it, if you get errors as well trying to do things in the options for easy scrap, you may need to change line 3 in that file and add theBackdropTemplateparam, but I didn't do that yet.In reply to Krudles:
I tried putting it in test.patch and tried doing "patch < test.patch" and it asks for file to patch and I press enter, then it asks if I want to skip patch, I said yes and it throws a "**** malformed patch at line 12: editFilterFrame.header:SetText('Edit Filter')" error.
Still learning some of this linux stuff. I figured out he created a diff patch using the original addon files and a modified addon file. Using diff he created a patch that contains the differences between the 2 files. Using the patch on the original file should produce the new modified file correct?
In reply to Krudles:
Krudles.. You are a SAINT!
You have save me sooooo much time and effort having to go through scrapping things manually click by click with this. ..Thank you so much for the input and "fix" to things while we wait for an updated release.
In reply to Krudles:
Actual hero dude, worked like a charm! Thanks to you both!
In reply to JungleOrDodge:
Yea, I thought that would work too. I have only ever worked with git patches... but that file is formatted differently (like the linux diff command you mentioned).
If I had a wild guess. I would think that "@@ -10,7 +10,7 @@ filterFrame.header:SetFontObject('GameFontNormalLarge')" needs to be on two lines, "@@ -10,7 +10,7 @@" being the first.
not working in prepatch =((
So yesterday, server shut down, and for i got forced log out, today my scrapper dosen't want to mark items anymore, i tried delete and unitstall, any ideea how i can make it work again?
Every time i press fk sell my 475 head get sold aswell even tho it isnt marked. so ive watied 4 weeks so restored an item since every time i restore it i fk sell it and ive to wait another FUCKING WEEK TO GET TIT BACK
This addon is awesome! Great job