Easy Scrap

Last Updated: Dec 16, 2018 Game Version: 8.1.0

Download

Install

828,663

Aug 9, 2018

Owner: Moootig

Easy Scrap adds a new frame to the Scrap interface that shows you all items in your bags available for scrapping and lets you queue items.

Features:

See all items you can scrap without having to look in your bags and search for even faster results.
Queue up items and have them automatically placed into the scrapper when the scrapper is empty again.
Create a keybinding for the scrap button. Look under Key Bindings->Addons->Easy Scrap
Hide specific items you do not want to see in the "Eligible" tab by right clicking them.
With the default filter automatically hides all gear that is used in an equipment set.
Create custom filters to automatically ignore items. Leave a comment if you have a specific filter request.

If you want to macro the scrap button create a macro with the following text:

/click EasyScrap_ScrapKeybindFrame

Please report any weird behavior if you see any and always make sure you're not scrapping an item you want to keep.

Comments

Hollo6
- Join Date: 11/3/2011
- Posts: 39
- Member Details
#117 Hollo6

View User Profile

Send Message

Posted Mar 21, 2019
Since 8.1.5, on the filter frame, item tooltips disappear when they are being refreshed. They are supposed to be redrawn:

https://github.com/arkayenro/arkinventory/issues/1167

Could you please look into this? Thanks!

Rollback Post to Revision RollBack
Moootig
- Join Date: 1/8/2015
- Posts: 127
- Member Details
#118 Moootig

View User Profile

Send Message

Posted Mar 21, 2019
In reply to Hollo6:

Hi, I'll have a look next time I'm playing, thanks for the link and asking more info from the author of AI.

Rollback Post to Revision RollBack
Hollo6
- Join Date: 11/3/2011
- Posts: 39
- Member Details
#119 Hollo6

View User Profile

Send Message

Posted Mar 21, 2019
In reply to Moootig:

Thank you, appreciate it!

Rollback Post to Revision RollBack
Smartie
- Join Date: 10/20/2006
- Posts: 52
- Member Details
#115 Smartie

View User Profile

Send Message

Posted Jan 21, 2019
The default filter just ignores items in your equipment sets?

Would be nice if it also excluded the highest item level for each slot? Even if your equipment set had 350, but you might have two 355s in your bag, it would also ignore those, as they're the highest item level for the slot?

Thanks

Last edited by Smartie: Jan 23, 2019

Rollback Post to Revision RollBack
Moootig
- Join Date: 1/8/2015
- Posts: 127
- Member Details
#116 Moootig

View User Profile

Send Message

Posted Jan 22, 2019
In reply to Smartie:

Hi, that's correct. Next time I do maintenance on the addon I can see if I can implement your request as an additional filter you can add, don't know when that will be though. Thanks for the suggestion!

Rollback Post to Revision RollBack
Hemar
- Join Date: 9/3/2006
- Posts: 36
- Member Details
#107 Hemar

View User Profile

Send Message

Posted Oct 22, 2018
I have a filter set up to filter out by itemlevel and items I have already collected the mog for.

However, EasyScrap is still filtering out items I have the mog for already (according to CanIMogIt).

See screenshot: https://pasteboard.co/HJIiweb.png

Last edited by Hemar: Oct 22, 2018

Rollback Post to Revision RollBack
Moootig
- Join Date: 1/8/2015
- Posts: 127
- Member Details
#108 Moootig

View User Profile

Send Message

Posted Oct 23, 2018
In reply to Hemar:

Is it doing it for all items or a couple?

Rollback Post to Revision RollBack
Hemar
- Join Date: 9/3/2006
- Posts: 36
- Member Details
#109 Hemar

View User Profile

Send Message

Posted Nov 1, 2018
In reply to Moootig:

Seems to be doing it to all the items

Rollback Post to Revision RollBack
Moootig
- Join Date: 1/8/2015
- Posts: 127
- Member Details
#110 Moootig

View User Profile

Send Message

Posted Nov 6, 2018
In reply to Hemar:

Sorry for the late reply! Well that's strange It was working fine for most items for me and when it didn't it gave the special error message. I'll have to look into it next time I'm working on the addon again, thanks for letting me know. I don't know if I'll ever get around to making it work as well as the CanIMogIt addon.

Rollback Post to Revision RollBack
Hemar
- Join Date: 9/3/2006
- Posts: 36
- Member Details
#111 Hemar

View User Profile

Send Message

Posted Nov 7, 2018
In reply to Moootig:

How about using CanIMogIt functions when it is loaded? Something in the lines of:

local transmogKnown = CanIMogIt and CanIMogIt:IsTransmogKnown(item) or MyOwnTransmogCheckFunction(item)

function names are made up and may not resemble what is actually there :)

Rollback Post to Revision RollBack

Moootig

Join Date: 1/8/2015
Posts: 127
Member Details

#112 Posted Nov 7, 2018

In reply to Hemar:

Well I haven't tried it but you could try pasting this at the bottom of EasyScrap_Filters.lua

filters['transmogKnown'].filterFunction = function(itemIndex, filterIndex)
    local item = EasyScrap.scrappableItems[itemIndex]
    local filterData = EasyScrap.saveData.customFilters[EasyScrap.activeFilterID].rules[filterIndex].data

    return CanIMogIt:PlayerKnowsTransmog(item.itemLink)
end

Last edited by Moootig: Nov 7, 2018

Hemar

Join Date: 9/3/2006
Posts: 36
Member Details

#113 Posted Nov 8, 2018

In reply to Moootig:

Yes, that seems to do the trick.

While debugging a bit I did find the culprit in your original code. C_TransmogCollection.GetAppearanceSources(z) returns nil if the source is unobtainable for the player (other armor type, or weapon type unusable for the player).

There is a C_TransmogCollection.PlayerHasTransmog(itemID) method available in the APIwhich you could potentially fall back on . CanIMogIt does use it, but it goes further than that when it looks for shared appearances.

This is what I ended up with:

filters['transmogKnown'].filterFunction = function(itemIndex, filterIndex)
    local item = EasyScrap.scrappableItems[itemIndex]
    
    if CanIMogIt then return CanIMogIt:PlayerKnowsTransmog(item.itemLink) or false end
 
    local z = C_TransmogCollection.GetItemInfo(item.itemLink)
    if not z then
        if item.itemClassID == LE_ITEM_CLASS_WEAPON or (item.itemClassID == LE_ITEM_CLASS_ARMOR and (item.itemSubClassID == LE_ITEM_ARMOR_CLOTH or item.itemSubClassID == LE_ITEM_ARMOR_LEATHER or item.itemSubClassID == LE_ITEM_ARMOR_MAIL or item.itemSubClassID == LE_ITEM_ARMOR_PLATE or item.itemSubClassID == LE_ITEM_ARMOR_SHIELD)) then 
            DEFAULT_CHAT_FRAME:AddMessage('Easy Scrap: Failed to obtain transmog information for item '..item.itemLink..'. Item will be ignored, please check it manually.')
            filters['transmogKnown'].filterMessage = 'unable to determine if appearance is known.\nThis happens for some items, please check it manually.'
            return false
        else
            return true 
        end
    end
    local sources = C_TransmogCollection.GetAppearanceSources(z)
    if sources then
        for k,v in pairs(sources) do
           if v.isCollected then return true end
        end
    elseif C_TransmogCollection.PlayerHasTransmog(item.itemID) then
        return true
    end
    filters['transmogKnown'].filterMessage = 'you don\'t have this appearance in your collection.'
    return false
end

Last edited by Hemar: Nov 8, 2018

Moootig
- Join Date: 1/8/2015
- Posts: 127
- Member Details
#114 Moootig

View User Profile

Send Message

Posted Nov 8, 2018
In reply to Hemar:

Ah cool I must've missed it when I (hastily) made the filter. I do remember running into a problem when a class couldn't equip an item. I guess you still prefer the use of the CanIMogIt function since it also differentiates between the shared appearances.

I'll update the addon on curse later with the fixes, thanks for the help!

Rollback Post to Revision RollBack
Chermtaka
- Join Date: 10/15/2011
- Posts: 38
- Member Details
#102 Chermtaka

View User Profile

Send Message

Posted Oct 12, 2018
Not an issue anymore,soz

Last edited by Chermtaka: Oct 12, 2018

Rollback Post to Revision RollBack
Chermtaka
- Join Date: 10/15/2011
- Posts: 38
- Member Details
#99 Chermtaka

View User Profile

Send Message

Posted Oct 9, 2018
Hi.

Great addon, makes my pixle life easier for sure.

Getting this error tho after latest update, hope this helps.

Date: 2018-10-09 09:27:58
ID: 2
Error occured in: Global
Count: 3
Message: ..\AddOns\EasyScrap\EasyScrap.lua line 57:
bad argument #1 to 'match' (string expected, got nil)
Debug:
[C]: ?
[C]: match()
EasyScrap\EasyScrap.lua:57:
EasyScrap\EasyScrap.lua:54
[C]: ?
[C]: ?
[C]: ?
[C]: ?
...face\AddOns\TradeSkillMaster\Core\Lib\TooltipLib.lua:85:
...face\AddOns\TradeSkillMaster\Core\Lib\TooltipLib.lua:82
MobInfo2\MI2_Events.lua:679:
MobInfo2\MI2_Events.lua:676
[C]: ?
[C]: ?
...e\AddOns\Enchantrix\Libs\LibExtraTip\LibExtraTip.lua:482: OnTooltipSetItem()
Enchantrix\EnxMain.lua:232:
Enchantrix\EnxMain.lua:228
[C]: ?
[C]: ?
[C]: ?
...face\AddOns\TradeSkillMaster\Core\Lib\TooltipLib.lua:95:
...face\AddOns\TradeSkillMaster\Core\Lib\TooltipLib.lua:93
[C]: ?
...e\AddOns\Enchantrix\Libs\LibExtraTip\LibExtraTip.lua:408:
...e\AddOns\Enchantrix\Libs\LibExtraTip\LibExtraTip.lua:402
[C]: ?
[C]: pcall()
AllTheThings\AllTheThings.lua:6744:
AllTheThings\AllTheThings.lua:6695
Locals:

AddOns:
MoncaiCompare, v7.2.0
Swatter, v8.0.6162 (SwimmingSeadragon)
Ace3, v
ACP, vr259
AllTheThings, v1.7.3b
AngryWorldQuests, v
AtlasLoot, vv8.08.01
AtlasLootBattleforAzeroth, vv8.08.01
AzerothAutoPilot, v0.180
BagBrother, v
BlizzMove, vv1.8
Combuctor, v8.0.2
Details, v
DetailsChartViewer, v
DetailsDeathGraphs, v
DetailsDmgRank, v
DetailsDpsTuning, v
DetailsEncounterDetails, v
DetailsRaidCheck, v
DetailsStreamer, v
DetailsTimeAttack, v
DetailsTimeLine, v
DetailsTinyThreat, v
DetailsVanguard, v
EasyScrap, v15
Enchantrix, v8.0.6158 (SwimmingSeadragon)
FBOutfitDisplayFrame, v1.9.1
FBTrackingFrame, v1.9
FishingBuddy, v1.9.19
HandyNotes, vv1.5.3
HandyNotesBrokenShore, vv1.29
HandyNotesDirections, v1
HandyNotesDungeonLocations, v1.42
HandyNotesGuild, v1.10
HandyNotesLegionMagePortals, v1.3
idTip, v8.0.0
LinkWrangler, v2.000
LinkWranglerAuctioneer, v1.67
LinkWranglerCompanion, v1.80
Ludwig, v8.0.0
MasterPlanA, vA
MobInfo2, v8.0.1
MonkeyClock, vv3.1.10
MountDropList, v8.0.1
MythicPlusLoot, v2.3
MythicPlusTimer, v2.3
Niggles, v5.00
NoTaintGlow, v1.02
Pawn, v2.2.29
Postal, vv3.6.0
Prat30, vr1193
Prat30Libraries, v
Raven, v
Rematch, v4.8.9
Scrap, v13.12
SilverDragon, vv4.0.13
SilverDragonBattleForAzeroth, vv4.0.13
SilverDragonBurningCrusade, vv4.0.13
SilverDragonCataclysm, vv4.0.13
SilverDragonLegion, vv4.0.13
SilverDragonMists, vv4.0.13
SilverDragonVanilla, vv4.0.13
SilverDragonWarlords, vv4.0.13
SilverDragonWrath, vv4.0.13
SimpleObjectives, v
Stubby, v8.0.6161 (SwimmingSeadragon)
TinyExtraBars, v1.56
TinyExtraBarsMacroTextHelpers, v1.00
Titan, v5.14.11.80000
TitanBag, v5.14.11.80000
TitanClock, v5.14.11.80000
TitanCurrency, v8.0.B
TitanGold, v5.14.11.80000
TitanItemLevel, v1.0.0.80000
TitanLootType, v5.14.11.80000
TitanPerformance, v5.14.11.80000
TitanProfession, vv1.13
TitanRepair, v5.14.11.80000
TitanReputations, vv1.17
TitanSocial, v8.0.1
TitanVolume, v5.14.11.80000
TitanXP, v5.14.11.80000
TomTom, vv80001-1.0.2
TooltipItemIcon, v1.75
TradeSkillMaster, vv4.4.5
TradeSkillMasterAppHelper, vv4.0
WorldQuestsList, v81
WorldQuestTab, v8.0.10c
Wyr3dIcyVeinsStats, v
xcalc, vv2.74
BlizRuntimeLib_enUS v8.0.1.80000 <none>
(ck=915)

Rollback Post to Revision RollBack
Moootig
- Join Date: 1/8/2015
- Posts: 127
- Member Details
#100 Moootig

View User Profile

Send Message

Posted Oct 9, 2018
In reply to Chermtaka:

Looks like it has to do with the new tooltip setting, do you have that enabled by any chance? I'll fix it soon!

Rollback Post to Revision RollBack
Moootig
- Join Date: 1/8/2015
- Posts: 127
- Member Details
#101 Moootig

View User Profile

Send Message

Posted Oct 9, 2018
In reply to Chermtaka:

Should be fixed in the new version, let me know if it still happens!

Rollback Post to Revision RollBack
Chermtaka
- Join Date: 10/15/2011
- Posts: 38
- Member Details
#103 Chermtaka

View User Profile

Send Message

Posted Oct 12, 2018
In reply to Moootig:

This has not happened again so seems you sorted it :) Thank you!

Rollback Post to Revision RollBack
Curseforge_user125843
- Location: Berlin
- Join Date: 8/29/2006
- Posts: 65
- Member Details
#97 Curseforge_user125843

View User Profile

Send Message

Posted Oct 8, 2018
Hi there,

Thank you for this great addon!

Can you please add the item sell value as filter condition?

Keep up the great work!

Rollback Post to Revision RollBack
Moootig
- Join Date: 1/8/2015
- Posts: 127
- Member Details
#98 Moootig

View User Profile

Send Message

Posted Oct 8, 2018
In reply to Curseforge_user125843:

Hi, glad you find it useful! I'll add the filter when I do some work on the addon again, I think I'll make it work like the item level filter as in you set a minimum and maximum sell price. That way it's most flexible.

Last edited by Moootig: Oct 8, 2018

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.