Easy Scrap

Last Updated: Apr 5, 2019 Game Version: 8.1.5

Download

Install

912,019

Aug 9, 2018

Owner: Loelalol

Easy Scrap adds a new frame to the Scrap interface that shows you all items in your bags available for scrapping and lets you queue items.

Features:

See all items you can scrap without having to look in your bags and search for even faster results.
Queue up items and have them automatically placed into the scrapper when the scrapper is empty again.
Create a keybinding for the scrap button. Look under Key Bindings->Addons->Easy Scrap
Hide specific items you do not want to see in the "Eligible" tab by right clicking them.
With the default filter automatically hides all gear that is used in an equipment set.
Create custom filters to automatically ignore items. Leave a comment if you have a specific filter request.

If you want to macro the scrap button create a macro with the following text:

/click EasyScrap_ScrapKeybindFrame

Please report any weird behavior if you see any and always make sure you're not scrapping an item you want to keep.

Comments

Hollo6
- Join Date: 11/3/2011
- Posts: 47
- Member Details
#117 Hollo6

View User Profile

Send Message

Posted Mar 21, 2019
Since 8.1.5, on the filter frame, item tooltips disappear when they are being refreshed. They are supposed to be redrawn:

https://github.com/arkayenro/arkinventory/issues/1167

Could you please look into this? Thanks!

Rollback Post to Revision RollBack
Loelalol
- Join Date: 1/8/2015
- Posts: 136
- Member Details
#118 Loelalol

View User Profile

Send Message

Posted Mar 21, 2019
In reply to Hollo6:

Hi, I'll have a look next time I'm playing, thanks for the link and asking more info from the author of AI.

Rollback Post to Revision RollBack
Hollo6
- Join Date: 11/3/2011
- Posts: 47
- Member Details
#119 Hollo6

View User Profile

Send Message

Posted Mar 21, 2019
In reply to Moootig:

Thank you, appreciate it!

Rollback Post to Revision RollBack
Loelalol
- Join Date: 1/8/2015
- Posts: 136
- Member Details
#120 Loelalol

View User Profile

Send Message

Posted Mar 25, 2019
In reply to Hollo6:

I'm unable to reproduce the error using the latest Ark Inventory, can you confirm it's still happening?

Edit: My bad I misread it's only happening on the filtered items.

Edit2: The only part that's dissapearing for me is the red text line that explains why an item was filtered, is that what you mean?

Last edited by Loelalol: Mar 25, 2019

Rollback Post to Revision RollBack
Hollo6
- Join Date: 11/3/2011
- Posts: 47
- Member Details
#121 Hollo6

View User Profile

Send Message

Posted Mar 26, 2019
In reply to Moootig:

It is still happening. And not only with the filtered items, but on all the frames Easy Scrap creates. All the tooltips are fine on the bags and on the upper frame where the queue is, and they disappear after 1s on the Eligible and Hidden frames. Some things other addons add to the tooltip (like icons from Pawn) stay there but the tooltip itself is gone. I also discovered that now I'm unable to hide the "Scrappable" text, I untick the box and then no matter what I do, reload relog restart, the box stays unchecked and the text is still there.

Edit: Now all of a sudden, I got this LUA error when opening the Scrapper:

Message: bad argument #1 to '?' (Usage: local tierInfo = C_AzeriteEmpoweredItem.GetAllTierInfo(azeriteEmpoweredItemLocation))
Debug:
[C]: ?
[C]: GetAllTierInfo()
EasyScrap\EasyScrap_Functions.lua:270: getTrueAzeriteItemLevel()
EasyScrap\EasyScrap_Functions.lua:381: itemInIgnoreList()
EasyScrap\EasyScrap_Functions.lua:173: filterScrappableItems()
...rface\AddOns\EasyScrap\Frames\EasyScrapMainFrame.lua:173:
...rface\AddOns\EasyScrap\Frames\EasyScrapMainFrame.lua:171
[C]: Show()
..\FrameXML\UIParent.lua:2632: SetUIPanel()
..\FrameXML\UIParent.lua:2477: ShowUIPanel()
..\FrameXML\UIParent.lua:2345:
..\FrameXML\UIParent.lua:2341
[C]: SetAttribute()
..\FrameXML\UIParent.lua:3173:
..\FrameXML\UIParent.lua:3161
[C]: ShowUIPanel()
..\FrameXML\UIParent.lua:1704:
..\FrameXML\UIParent.lua:1090
Locals:

Last edited by Hollo6: Mar 26, 2019

Rollback Post to Revision RollBack
Loelalol
- Join Date: 1/8/2015
- Posts: 136
- Member Details
#122 Loelalol

View User Profile

Send Message

Posted Mar 26, 2019
In reply to Hollo6:

Seems like the Scrappable text not being hidden is indeed broken. I cant' however reproduce the tooltips dissapearing bug, I only see the text that explains why an item was filtered dissapear. Not sure what's up with the error, if you're still getting it try moving azerite gear in your bank and see if it still happens, maybe it's a specific item.

I can fix the scrappable text and filter-text dissapearing but no clue why the whole item tooltip would dissapear for you since the addon isn't really doing anything crazy with tooltips.

Last edited by Loelalol: Mar 26, 2019

Rollback Post to Revision RollBack
Hollo6
- Join Date: 11/3/2011
- Posts: 47
- Member Details
#123 Hollo6

View User Profile

Send Message

Posted Mar 27, 2019
In reply to Moootig:

Is there any way I can debug this? Maybe somehow point out that it's caused by AI after all? It's extremely frustrating having to disable it every single time I want to scrap things. :(

Rollback Post to Revision RollBack
Loelalol
- Join Date: 1/8/2015
- Posts: 136
- Member Details
#124 Loelalol

View User Profile

Send Message

Posted Mar 29, 2019
In reply to Hollo6:

Apologies for the slow replies. I don't think there's an easy way for you to debug this, atleast Easy Scrap doesn't really have debugging built in. If I was able to reproduce the tooltip error it would probably be a fairly easy fix, are you sure it's Ark Inventory and not some other addon? Possibly there's a third addon that could be interfering with it when all 3 are enabled?

Regardless I'll try and update Easy Scrap soon and maybe it'll end up somehow fixing it...

Rollback Post to Revision RollBack
Hollo6
- Join Date: 11/3/2011
- Posts: 47
- Member Details
#125 Hollo6

View User Profile

Send Message

Posted Mar 30, 2019
In reply to Moootig:

Thank you for your efforts!

I'm pretty sure it's AI+EasyScrap together somehow, this started happening on patch day right away, before I updated any addons.

It's only happening with the extra frame that Easy Scrap adds, haven't seen this anywhere else.and if I disable AI only, it's good again.

Maybe it's connected to some settings? The only thing I could find out that if I disable the tooltips section in AI, the problem is not present (changing any sub-setting doesn't make any difference), and I don't know where else I could look. Did you test it with AI tooltips enabled?

Last edited by Hollo6: Mar 30, 2019

Rollback Post to Revision RollBack
Loelalol
- Join Date: 1/8/2015
- Posts: 136
- Member Details
#126 Loelalol

View User Profile

Send Message

Posted Mar 30, 2019
In reply to Hollo6:

Ah I bet that's why I was unable to relrodure it. I don't use AI myself so I just tested with stock settings, I'll have another look asap!

Rollback Post to Revision RollBack
Hollo6
- Join Date: 11/3/2011
- Posts: 47
- Member Details
#127 Hollo6

View User Profile

Send Message

Posted Mar 30, 2019
In reply to Moootig:

Thank you! Let me know if I can help with testing or anything!

Rollback Post to Revision RollBack
Loelalol
- Join Date: 1/8/2015
- Posts: 136
- Member Details
#128 Loelalol

View User Profile

Send Message

Posted Apr 1, 2019
In reply to Hollo6:

Try this version once it's been approved: https://wow.curseforge.com/projects/easy-scrap/files/2694513

The link won't work until it has been approved. If you're still getting that lua error close the scrapper and try typing:

/run EasyScrap.debugMode = true

It should print some info in chat when you get the error again.

Edit: Also the "Scrappable" text always appearing was probably because you had the scrapper window open, please check again with the Scrapper window closed to make sure it's not working. It was working for me I just forgot that the game automatically adds it when the scrapper is open.

Last edited by Loelalol: Apr 1, 2019

Rollback Post to Revision RollBack
Hollo6
- Join Date: 11/3/2011
- Posts: 47
- Member Details
#129 Hollo6

View User Profile

Send Message

Posted Apr 2, 2019
In reply to Moootig:

I'm trying out the new version.

1) I didn't get that LUA error since then, seems it was only that one time.

2) When I tried to disable the "Scrappable" text, it was happening with or without the scrapper open, but now I can disable it, works OK everywhere.

3) Now the tooltips are "invisible", it seems they would be there because I can see the frame of them, just nothing inside. Happening regardless of AI enabled.

Rollback Post to Revision RollBack
Loelalol
- Join Date: 1/8/2015
- Posts: 136
- Member Details
#130 Loelalol

View User Profile

Send Message

Posted Apr 2, 2019
In reply to Hollo6:

Honestly at this point I don't really know why you are having these issues. I can not think of any reason why Easy Scrap would be causing this problem, as far as I am aware it is showing tooltips the same way a bag addon would, it's less code than this reply. I'm really sorry but I don't think I'm going to be able to fix this unless I manage to somehow reproduce it myself. It really sounds like there's something else breaking things, I would've also expected more reports if the problem was happening for more people, really annoying!

Last edited by Loelalol: Apr 2, 2019

Rollback Post to Revision RollBack
Hollo6
- Join Date: 11/3/2011
- Posts: 47
- Member Details
#131 Hollo6

View User Profile

Send Message

Posted Apr 2, 2019
In reply to Moootig:

I have tried disabling every other addon and now I'm convinced this is not a clash. No matter the item or the position of the frame, it always looks like if the tooltips were getting hidden behind the scrapper frame.

Here's an example: https://imgur.com/a/2djqydM

You can see the frame of the tooltip (its top side is the most visible here, to the right of the scrapper frame), and now it's not disappearing like in the previous version, it stays there but its inside is empty.

Edit: what you can see to the right is actually the comparison tooltip, the item's actual tooltip is behind the scrapper frame.

Last edited by Hollo6: Apr 2, 2019

Rollback Post to Revision RollBack
Loelalol
- Join Date: 1/8/2015
- Posts: 136
- Member Details
#132 Loelalol

View User Profile

Send Message

Posted Apr 2, 2019
In reply to Hollo6:

Can you run this command and see if it makes a tooltip appear?

/run GameTooltip:Hide() GameTooltip:SetOwner(UIParent, "ANCHOR_NONE") GameTooltip:SetPoint("CENTER") GameTooltip:SetBagItem(0, 0) GameTooltip:Show()

Rollback Post to Revision RollBack
Hollo6
- Join Date: 11/3/2011
- Posts: 47
- Member Details
#133 Hollo6

View User Profile

Send Message

Posted Apr 3, 2019
In reply to Moootig:

Yes, shows a perfect tooltip.

Rollback Post to Revision RollBack
Loelalol
- Join Date: 1/8/2015
- Posts: 136
- Member Details
#134 Loelalol

View User Profile

Send Message

Posted Apr 3, 2019
In reply to Hollo6:

What about this one, you need to have the Scrapper open and dont have your mouse over an item for it to work.

/run GameTooltip:Hide() GameTooltip:SetOwner(EasyScrapItemButton1, "ANCHOR_RIGHT") GameTooltip:SetBagItem(0, 0) GameTooltip:Show()

Last edited by Loelalol: Apr 3, 2019

Rollback Post to Revision RollBack
Hollo6
- Join Date: 11/3/2011
- Posts: 47
- Member Details
#135 Hollo6

View User Profile

Send Message

Posted Apr 3, 2019
In reply to Moootig:

Shows a good tooltip at the good place (if it were the tooltip of the first item on the Easy Scrap frame).

Edit: aaaaaaaaand this just gave me the solution. Changing ANCHOR_NONE to ANCHOR_RIGHT in L102 fixed the problem.

Last edited by Hollo6: Apr 3, 2019

Rollback Post to Revision RollBack
Loelalol
- Join Date: 1/8/2015
- Posts: 136
- Member Details
#136 Loelalol

View User Profile

Send Message

Posted Apr 3, 2019
In reply to Hollo6:

Fingers crossed this version fixes it, might not be approved for download yet.

https://wow.curseforge.com/projects/easy-scrap/files/2695253

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.