This addon restores the old quest log with the familiar list of quests on the left and details on the right on retail servers.
Please note:
- This addon is not for Classic WoW. Classic WoW already has the classic quest log. This addon is for retail servers to restore a "classic" style of quest log.
This addon's initial behavior is to commandeer your quest log key binding and micro button to toggle the new log. It should be a familiar enough experience once you log in.
If you decide you want to keep using the new default log alongside this addon, you can:
- Open the map via key binding (M is default key) will display the new map+quest log hybrid.
- Click 'Show Map' in the upper right of the Classic Quest Log, it will jump to the map of the quest's zone with the attached new style quest log.
- If that's not enough and you only want to use the Classic Quest Log occasionally, go into Key Bindings -> AddOns -> Classic Quest Log and set a binding to toggle this addon's window. Once a binding is set, it will revert the behavior of the default quest log binding and quest micro button to its map+quest default behavior.
There are a few minor changes from the true old quest log:
- Instead of saying (Completed) or (Daily) beside each quest name, they are now represented by icons just like the new log.
- There are other options in the Options button at the bottom of the window, such as the ability to move the window around the screen or to resize the height of the window.
Mouse over quest rewards doesn't show tooltips
In reply to Drejjmit:
It shows for me:
Do you have any tooltip-related addons? I'd try disabling those. Unfortunately I can't do anything if I can't reproduce the problem.
In reply to gello3:
Sorry it was BankItems that had issues with GetQuestLogRewardCurrencyInfo. Fixed in their release from a few minutes ago.
Happy to see the addon working in the prepatch - clearly a large project for you to rewrite the addon from a monothlic single LUA file to the current form it is in now.
The integration element that Lightheaded used is no longer in the addon, and I'm wondering if you could provide some insight as to what function is the successor to it. In the old addon, Lightheaded hooked "SelectQuestIndex" in CQL (around line 96 in lightheaded.lua) so each time it was called, Lightheaded used the information in that function to bring up the same quest in its window, and it worked well. In the new code, that function no longer exists, and although I've read through some of the new code, I'm just not sure which function is its successor. Could you provide some insight, so I could see what change(s) would need to be made in Lightheaded to get them working together again? (Note: I'm not the author of Lightheaded, just comfortable working with code - although I'll post what changes need to be made to the Lightheaded comments page on Wowinterface once I've worked them out.)
Thanks!
In reply to Zeglar:
I wasn't aware of the integration. I'll take a look.
In reply to Zeglar:
Do you have a copy of Lightheaded that works on its own? The one at wowinterface has not been updated for the new quest API in 9.0.
I'm afraid Lightheaded requires some considerable work to get it working in 9.0, even before the minor fix for hooking into ClassicQuestLog. A lot of quest functions were deprecated and moved into their own namespaces, like C_QuestLog.
In reply to gello3:
I was unaware of that; I had been doing some quick lookups as I was working with it. (I 'broke' the hook section in lightheaded.lua by throwing a random character in the ClassicQuestLog string, and have been typing /lh show and then typing in the quest name in the search box and it was working fine from what I could see.). So no, no rewritten code yet. Without the hook, I am not sure how much deeper I'll get with Lightheaded, to be fair, since it is just less convenient to work with for now.
Sounds like the best method for now will be to just wait for an update for Lightheaded - they usually come after a major patch, but has often take some time for it to show up.
In reply to Zeglar:
Interesting. I saw a bunch of function calls in LightHeaded.lua that no longer exist (GetQuestLogTitle, GetQuestLogSelection) and didn't even try to run the addon because each of those will error out; but after commenting the ClassicQuestLog bit out, /lh show does work and it even works somewhat in the map quest log.
I'll take a closer look and see if I can make it easier to hook. The replacement for cql:SelectQuestIndex(index) is these two lines in cql.log:ListButtonOnClick:
C_QuestLog.SetSelectedQuest(info.questID)
cql:SetMode("detail")
C_QuestLog.SetSelectedQuest is a Blizzard function that takes a questID. cql:SetMode("detail") will switch to the detail mode (code for that at the end of main.lua) and updates its contents.
The only other place where a quest is selected in this addon is cql.detail:GetSelectedQuest() in detail.lua. If there's no quest selected, it will pick one.
I think hooking cql.log:ListButtonOnClick() may work but I'm not sure because of the cql.detail:GetSelectedQuest() above. The LightHeaded hook expects a log index and turns it into a questID. This addon now deals directly with questIDs where possible.
In reply to gello3:
If I have Classic Quest Log disabled Lightheaded works without a problem. Once i re-enable Classic Quest Log, I get this error:
In reply to tazrulez:
This will be "corrected" in a fix later tonight. It's an ugly workaround until LightHeaded is updated for 9.0/Shadowlands.
In reply to tazrulez:
how did you make lightheaded work it gives me crazy errors even when its the only quest addon loaded. and this is with it being the only addon running period
Message: Interface\AddOns\LightHeaded\LightHeaded.lua:162: attempt to call global 'GetQuestLogSelection' (a nil value)
Time: Mon Oct 26 18:14:32 2020
Count: 1
Stack: Interface\AddOns\LightHeaded\LightHeaded.lua:162: attempt to call global 'GetQuestLogSelection' (a nil value)
[string "@Interface\AddOns\LightHeaded\LightHeaded.lua"]:162: in function `GetCurrentQID'
[string "@Interface\AddOns\LightHeaded\LightHeaded.lua"]:275: in function `SelectQuestLogEntry'
[string "@Interface\AddOns\LightHeaded\LightHeaded.lua"]:269: in function `OpenQuestID'
[string "@Interface\AddOns\LightHeaded\LightHeaded.lua"]:58: in function <Interface\AddOns\LightHeaded\LightHeaded.lua:57>
[string "=[C]"]: in function `OnBlockHeaderClick'
[string "@Interface\AddOns\Blizzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua"]:686: in function <...zzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua:684>
Locals: self = <table> {
defaults = <table> {
}
EnableDebug = <function> defined @Interface\AddOns\LightHeaded\Dongle.lua:618
IterateQuestComments = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:399
QUEST_LOG_UPDATE = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:157
CancelTimer = <function> defined @Interface\AddOns\LightHeaded\Dongle.lua:605
ChangeFontSize = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:1705
GetQIDOffsets = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:219
LoadNames = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:170
OnHyperlinkEnter = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:1108
SavePosition = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:1611
quest_clicked = true
OnHyperlinkClick = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:885
GetQuestName = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:195
ScheduleTimer = <function> defined @Interface\AddOns\LightHeaded\Dongle.lua:558
LockUnlockFrame = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:1589
GetCurrentQID = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:161
RestorePosition = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:1629
RegisterMessage = <function> defined @Interface\AddOns\LightHeaded\Dongle.lua:412
UnregisterMessage = <function> defined @Interface\AddOns\LightHeaded\Dongle.lua:426
IterateNPCLocs = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:428
db = <table> {
}
uihistory = <table> {
}
TogglePages = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:1676
IterateModules = <function> defined @Interface\AddOns\LightHeaded\Dongle.lua:316
ToggleDebug = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:1741
SelectQuestLogEntry = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:272
GetCoordText = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:491
IsMessageRegistered = <function> defined @Interface\AddOns\LightHeaded\Dongle.lua:467
TriggerMessage = <function> defined @Interface\AddOns\LightHeaded\Dongle.lua:450
Enable = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:31
IsEventRegistered = <function> defined @Interface\AddOns\LightHeaded\Dongle.lua:396
Echo = <function> defined @Interface\AddOns\LightHeaded\Dongle.lua:696
ChangeBGAlpha = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:1712
ToggleSound = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:1666
GetNumQuestComments = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:370
ScheduleRepeatingTimer = <function> defined @Interface\AddOns\LightHeaded\Dongle.lua:589
UpdateFrame = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:793
PrintF = <function> defined @Interface\AddOns\LightHeaded\Dongle.lua:689
SearchQuests = <function> defined @Interface\AddOns\LightHeaded\LightHeaded.lua:1754
GetQIDDescription
In reply to gators7778:
The part I "fixed" was just the execution path where ClassicQuestLog is involved. It was enough so that clicking a quest in the log will display the LightHeaded window with the quest.
As mentioned above, I was surprised LightHeaded ran at all, there are many changes that need to happen to get LightHeaded fully working in 9.0. So I don't doubt there are tons of errors. I make no claims that I've somehow fixed LightHeaded.
Very cool! Completely understandable if it's too complicated of a task. I'm sure there aren't many of us with that use-case.
Is there a simple way to adjust the addon to not close the World Map when it's opened? I use Leatrix Maps so I can have a World Map that is always on screen but when I open CQL it closes the map.
In reply to Sails_TTV:
The quest details panel is a shared resource, shared between this addon and the map+hybrid.
No promises, but I can look into the possibility of letting both this addon and the map remain on screen and opening the map's quest panel will close this addon.
Hi gello3, thank you for all the work you've put into this addon!
Like several comments below, I was hoping that you could restore the quest log panel's default position to underneath the default health and resource bars (on the left of the screen) whenever I open the quest log.
As others have previously stated, the panel currently appears in the middle of the screen by default when I log onto a character that has not yet customized any settings for this addon.
If I recall correctly, previous versions from a while ago used to have an in-game setting called "Undock Window" where, if unchecked, automatically places the Classic Quest Log panel to exactly where the default character panel appears on the left. What was most convenient was the fact that these settings were global and carried over to all my alts, hence I need only customize them on one character only. In the live version, one has to manually adjust the quest panel's position on each alt.
Where possible, please do help to rectify both the default positioning and global settings issues. Much appreciated, thank you!
In reply to JerXX91:
Blizzard broke that functionality in 8.2 by kicking addons out of their pane management.
If there's a way for addons to be involved in that again, I'm not aware of it. Do you know of an existing addon that does not attach to an existing panel that can behave the way you describe? (eg, no addons that replace collections windows--but a fully standalone addon all its own).
Because I don't think this functionality is possible anymore, I've removed the option entirely to make it possible.
I'll be happy to be proved wrong.
For anyone interested, a Shadowlands version is posted here:
https://www.wowinterface.com/downloads/info25661-ClassicQuestLog-ShadowlandsBeta.html
Not sure how many will read this, but is there any objection to changing the name of this addon? I'm thinking something like Old Quest Log.
I'd like to drop the 'Classic' since it's confused with the classic client. And technically this is "WotLK Quest Log With Extras" than a pure vanilla WoW experience.
This addon has my focus now to update for Shadowlands, and I've decided to do a rewrite since the quest API has been moved into its own namespace.
In reply to gello3:
Yea the "Classic" in the name often made me confused when i was looking for it. I think there was a classic classic version too. OldSchool Quest log or Old Quest Log sounds fine to me.