From the same author of GarrisonCommander an addon dedicated to Class Halls
Comments policy
As soon as I fix bugs, comment reporting them are deleted, because they are no longer useful. Also, I really prefer bugs to be raised on curseforge:
OrderHallCommander
You CAN have both OrderHallCommander AND GarrisonCommander enabled. GarrisonCommander detects OrderHallCommander and steps back for Order Hall missions.
Description
This is addon is ONLY for Legion missions.
If you want an addon for Draneor missions, it's GarrisonCOmmander
If you want an addon for Battle for Azeroth missions, it's ChampionCommander
Completed mission
- You can have OHC complete mission for you with just one click
Available Missions
- Proposed Party graphically shown
- Clicking mission button autofill mission page
- Success chance
- Total xp gain projection
- Countered mechanics
- Enriched rewards
- Expire time
- Tooltip inform if a better party cpuld be available in next hours
- A bunch of switches allow to change party compositon based on expected mission results (favour xp, favour low cost, favour improved time and so on)
In progress Missions
- Running party graphically shown
Follower list
- A list of possible upgrades are showm, and you can apply them just with one click
Miscellaneous
- When you are in your Order Hall OHC notifies you if you have troops to collect. Notification repeated once a minute (Can be deactivated)
Feature requests or bugs
Please, use Curse Ticket Tracker
About me
I am a professional software developer, spacing from PHP web development to C + + Gaming Server Software.
Right now I’m working on this Real Time 4X MMO:
Last updated July 2021, seems like the project is dead. Getting the following LUA error when clicking the scouting map in the class hall:
Message: Interface\AddOns\OrderHallCommander\cache.lua:541: attempt to index field 'Background' (a nil value)
Time: Mon Jan 17 16:22:23 2022
Count: 11
Stack: Interface\AddOns\OrderHallCommander\cache.lua:541: attempt to index field 'Background' (a nil value)
[string "@Interface\AddOns\OrderHallCommander\cache.lua"]:541: in function `GetTroopsFrame'
[string "@Interface\AddOns\OrderHallCommander\cache.lua"]:665: in function `?'
[string "@Interface\AddOns\Bartender4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:119: in function <...er4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>
[string "=[C]"]: ?
[string "@Interface\AddOns\Bartender4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:29: in function <...er4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@Interface\AddOns\Bartender4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:64: in function `Fire'
[string "@Interface\AddOns\Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua"]:120: in function <...AddOns\Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua:119>
Locals: <none>
In reply to Fennycroft:
Go to the cache.lua file in the addon folder..
find the line 541..
replace the line:
frame.Background:Hide()
with
-- frame.Background:Hide()
Greetings.
Thanks for an awesome addon. Been using it steadily now for years. Made me a ton of gold when Legion was relevant. I just started using it again once Legion Timewalking went live.
I'm getting the exact same error as immortalimotion below. Hope you are still working on this because it is still a very useful addon.
Thanks.
3x OrderHallCommander\cache.lua:541: attempt to index field 'Background' (a nil value)
[string "@OrderHallCommander\cache.lua"]:541: in function `GetTroopsFrame'
[string "@OrderHallCommander\cache.lua"]:665: in function `?'
[string "@AllTheThings\lib\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:119: in function <...ings\lib\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>
[string "=[C]"]: ?
[string "@AllTheThings\lib\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:29: in function <...ings\lib\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@AllTheThings\lib\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:64: in function `Fire'
[string "@DataStore\libs\AceEvent-3.0\AceEvent-3.0-4.lua"]:120: in function <DataStore\libs\AceEvent-3.0\AceEvent-3.0.lua:119>
Hi,
Get the following error with patch 9.1.5
All the best
[15:31] Interface\AddOns\OrderHallCommander\cache.lua:541: attempt to index field 'Background' (a nil value)
[15:31] [string "@Interface\AddOns\OrderHallCommander\cache.lua"]:541: in function `GetTroopsFrame'
[string "@Interface\AddOns\OrderHallCommander\cache.lua"]:665: in function `?'
[string "@Interface\AddOns\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:119: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>
[string "=[C]"]: ?
[string "@Interface\AddOns\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:29: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@Interface\AddOns\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:64: in function `Fire'
[string "@Interface\AddOns\Ace3\AceEvent-3.0\AceEvent-3.0-4.lua"]:120: in function <Interface\AddOns\Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>
deleted
After increasing my companions to a total of 22, the addon companions selection GUI now reverts back to the traditional Blizzard UI with the unfiltered, messy companions list. Is it possible that at a certain high number the companions are too many to be listed in the addon GUI so it has to revert back?
If If that's the cause, it would be great if in the future there is the possibility of adding a scroll option or a way to reduce the scale of the companion icons so that you can still utilize the addon GUI for companion selection. It's been really helpful to have a full overview of their levels in descending order along with the easy indicators for troops that can be upgraded.
Hello,
Get the following error if you try to scroll the mission list when there are not enough to fill the window. It doesn't stop the addon working but thought id let you know. All the best.
Interface\AddOns\OrderHallCommander\missionlist.lua:1218: attempt to index field 'info' (a nil value)
[23:34] [string "@Interface\AddOns\OrderHallCommander\missionlist.lua"]:1218: in function <Interface\AddOns\OrderHallCommander\missionlist.lua:1216>
[string "=(tail call)"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function `xpcall'
[string "@Interface\SharedXML\FunctionUtil.lua"]:4: in function `ExecuteFrameScript'
[string "@Interface\AddOns\Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua"]:1045: in function `GarrisonMissionList_UpdateMouseOverTooltip'
[string "@Interface\AddOns\Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua"]:836: in function <...s\Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:836>
[23:34] self = <table> {
SetDefaultModuleLibraries = <function> defined @Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:367
EnableModule = <function> defined @Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:332
modules = <table> {
}
CancelTimer = <function> defined @Interface\AddOns\Ace3\AceTimer-3.0\AceTimer-3.0.lua:147
IterateEmbeds = <function> defined @Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:442
SecureHook = <function> defined @Interface\AddOns\Ace3\AceHook-3.0\AceHook-3.0.lua:336
MissionTip = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:1172
RawHookScript = <function> defined @Interface\AddOns\Ace3\AceHook-3.0\AceHook-3.0.lua:395
SortMissions = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:445
NoMartiniNoParty = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:619
SetDefaultModulePrototype = <function> defined @Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:409
Menu = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:697
IsEnabled = <function> defined @Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:451
ScheduleTimer = <function> defined @Interface\AddOns\Ace3\AceTimer-3.0\AceTimer-3.0.lua:94
DisableModule = <function> defined @Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:350
RegisterMessage = <function> defined @Interface\AddOns\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
UnregisterMessage = <function> defined @Interface\AddOns\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:153
IsHooked = <function> defined @Interface\AddOns\Ace3\AceHook-3.0\AceHook-3.0.lua:493
InitialSetup = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:726
SetEnabledState = <function> defined @Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:424
Hook = <function> defined @Interface\AddOns\Ace3\AceHook-3.0\AceHook-3.0.lua:274
enabledState = true
RegisterEvent = <function> defined @Interface\AddOns\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
IterateModules = <function> defined @Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:437
Dim = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:933
RawHook = <function> defined @Interface\AddOns\Ace3\AceHook-3.0\AceHook-3.0.lua:313
OnInitialized = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:197
OnInitialize = <function> defined @Interface\AddOns\ChampionCommander\libs\LibInit\LibInit.lua:388
UnregisterAllEvents = <function> defined @Interface\AddOns\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
GetModule = <function> defined @Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:210
LoadButtons = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:269
defaultModuleLibraries = <table> {
}
OnUpdate = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:368
ScheduleRepeatingTimer = <function> defined @Interface\AddOns\Ace3\AceTimer-3.0\AceTimer-3.0.lua:129
CancelAllTimers = <function> defined @Interface\AddOns\Ace3\AceTimer-3.0\AceTimer-3.0.lua:160
GetName = <function> defined @Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:279
baseName = "OrderHallCommander"
Enable = <function> defined @Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:294
AddThreats = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:1069
Events = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:254
AdjustMissionTooltip = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:1216
AddMembers = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:966
orderedModules = <table> {
}
MainOnShow = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:835
Disable = <function> defined @Interface\AddOns\Ace3\AceAddon-3.0\AceAddon-3.0.lua:314
SafeAddMembers = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:924
AdjustMissionButton = <function> defined @Interface\AddOns\OrderHallCommander\missionlist.lua:881
Adj
1x [ADDON_ACTION_FORBIDDEN] 插件 'OrderHallCommander' 尝试调用保护功能 'UseToy()'。
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: in function `UseToy'
[string "@Blizzard_Collections\Blizzard_ToyBox.lua"]:181: in function `ToySpellButton_OnClick'
[string "*:OnClick"]:4: in function <[string "*:OnClick"]:1>
Here are two pictures from your addons:
1) https://ibb.co/252Yhsm correct translation into the Russian language in Legion;
2) https://ibb.co/K00CJ2X text in translations is not exist - so not translated into Russian language and all languages in Battle for Azeroth.
The text is "and then by". It is related to sorting.
The current addon doesn't seem to be able to recognize the veterans of argus - it adds in no bonus for using them on a mission, even if the mission requires a veteran of argus.
as mentioned on garrisoncommander, there are issues here too.
some of them reference garrison but here are the ones referencing orderhall.
Message: Interface\AddOns\OrderHallCommander\cache.lua:901: attempt to compare number with nil
Time: Sun Jul 11 04:27:40 2021
Count: 1
Stack: Interface\AddOns\OrderHallCommander\cache.lua:901: attempt to compare number with nil
[string "=[C]"]: ?
[string "@Interface\AddOns\OrderHallCommander\cache.lua"]:901: in function `GetFullPermutations'
[string "@Interface\AddOns\OrderHallCommander\matchmaker.lua"]:691: in function `?'
[string "@Interface\AddOns\OrderHallCommander\missionlist.lua"]:544: in function <Interface\AddOns\OrderHallCommander\missionlist.lua:528>
[string "=(tail call)"]: ?
[string "@Interface\AddOns\OrderHallCommander\missionlist.lua"]:573: in function `ReloadMissions'
[string "@Interface\AddOns\OrderHallCommander\missionlist.lua"]:745: in function <Interface\AddOns\OrderHallCommander\missionlist.lua:726>
[string "=(tail call)"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function `Show'
[string "@Interface\FrameXML\UIParent.lua"]:2928: in function `SetUIPanel'
[string "@Interface\FrameXML\UIParent.lua"]:2734: in function `ShowUIPanel'
[string "@Interface\FrameXML\UIParent.lua"]:2641: in function <Interface\FrameXML\UIParent.lua:2637>
[string "=[C]"]: in function `SetAttribute'
[string "@Interface\FrameXML\UIParent.lua"]:3492: in function `ShowUIPanel'
[string "@Interface\FrameXML\UIParent.lua"]:1976: in function <Interface\FrameXML\UIParent.lua:1287>
Message: Interface\AddOns\OrderHallCommander\cache.lua:901: attempt to compare number with nil
Time: Sun Jul 11 04:30:19 2021
Count: 8
Stack: Interface\AddOns\OrderHallCommander\cache.lua:901: attempt to compare number with nil
[string "=[C]"]: ?
[string "@Interface\AddOns\OrderHallCommander\cache.lua"]:901: in function `GetFullPermutations'
[string "@Interface\AddOns\OrderHallCommander\matchmaker.lua"]:691: in function `?'
[string "@Interface\AddOns\OrderHallCommander\missionlist.lua"]:544: in function <Interface\AddOns\OrderHallCommander\missionlist.lua:528>
[string "=(tail call)"]: ?
[string "@Interface\AddOns\OrderHallCommander\missionlist.lua"]:585: in function `RedrawMissions'
[string "@Interface\AddOns\OrderHallCommander\missionlist.lua"]:369: in function <Interface\AddOns\OrderHallCommander\missionlist.lua:368>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `Update'
[string "@Interface\AddOns\Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua"]:1202: in function <...s\Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:1175>
[string "=[C]"]: ?
In reply to Deacontaylor:
Fixed GC right now, starting checking OC
Oddly enough, the addon works for me EXCEPT for certain classes: Warlock and Demon Hunter. Those two classes I have to completely disable the addon in order to send missions. Haven't tried every class yet, but that's what I noticed so far. Will update if there's another class that doesn't work, etc.
No longer allows auto fill of champions, does the same thing as the blizzard one now. And it is a really awesome addon, as they all are, when it functions correctly. I am hoping you are just waiting for blizzard to stop mini patches, before releasing. Also when I clicked open ticket for Championcommander, it brought me here.
In reply to gilezdavidson:
ChampionCommander, OrderHallCommander, GarrisonCommander share a lot of code because also a large part of Blizzard code is shared, so what affects one of them will probably affects the other ones, too.
I am busy in RL and indeed waiting for things to settle down after patcj
In reply to alarthedark:
I appreciate that, you are awesome, these addons are amazing, they sure save a lot of calculations, the latest one being super freaking awesome, they just keep getting better. I understand RL and if I still could code, I would have the fix for any of the broken parts, but my brain is now mush LOL. Anyway thanks for responding. Just wanted to make you aware, cheers.
Hello! I Thank you for the great addon! I just want to tell you that the sound when I choose missions (in Legion) is very loud. It would be nice if there was a way to adjust the sound volume.
Error with latest v1.8.5 dated 11/18/2020, when checking board at druid class order hall:
In reply to zultara1:
Cant replicate the issue. Are you sure youi have the 1.8.5?
I'm not the parent poster, but I'm also getting this same error and debug trace.
It looks like this can happen when missions don't have an expire time. For example, the Druid mission "Gathering the Dreamweavers: Thisalee Crow".
To test this, I modified line 913 to check if offerTimeRemaining is truthy:
... which resulted in the expected: