From the same author of GarrisonCommander an addon dedicated to Class Halls
Comments policy
As soon as I fix bugs, comment reporting them are deleted, because they are no longer useful. Also, I really prefer bugs to be raised on curseforge:
OrderHallCommander
You CAN have both OrderHallCommander AND GarrisonCommander enabled. GarrisonCommander detects OrderHallCommander and steps back for Order Hall missions.
Description
This is addon is ONLY for Legion missions.
If you want an addon for Draneor missions, it's GarrisonCOmmander
If you want an addon for Battle for Azeroth missions, it's ChampionCommander
Completed mission
- You can have OHC complete mission for you with just one click
Available Missions
- Proposed Party graphically shown
- Clicking mission button autofill mission page
- Success chance
- Total xp gain projection
- Countered mechanics
- Enriched rewards
- Expire time
- Tooltip inform if a better party cpuld be available in next hours
- A bunch of switches allow to change party compositon based on expected mission results (favour xp, favour low cost, favour improved time and so on)
In progress Missions
- Running party graphically shown
Follower list
- A list of possible upgrades are showm, and you can apply them just with one click
Miscellaneous
- When you are in your Order Hall OHC notifies you if you have troops to collect. Notification repeated once a minute (Can be deactivated)
Feature requests or bugs
Please, use Curse Ticket Tracker
About me
I am a professional software developer, spacing from PHP web development to C + + Gaming Server Software.
Right now I’m working on this Real Time 4X MMO:
4x OrderHallCommander\libs\LibInit\LibInit-60.lua:46: unexpected symbol near ']'
[string "=[C]"]: ?
[string "=[C]"]: in function `LoadAddOn'
[string "@WQAchievements\WQAchievements-v9.0.1-4release.lua"]:462: in function <WQAchievements\WQAchievements.lua:390>
[string "=[C]"]: ?
[string "@ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:70: in function <...s\ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:65>
[string "@ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:527: in function `EnableAddon'
[string "@ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:630: in function <...s\ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:615>
[string "=[C]"]: ?
[string "=[C]"]: in function `LoadAddOn'
[string "@FrameXML\UIParent.lua"]:495: in function `UIParentLoadAddOn'
[string "@Rarity\Core\Collections-Sammlungen.lua"]:63: in function `ScanToys'
[string "@Rarity\Core\Collections-Sammlungen.lua"]:307: in function `ScanExistingItems'
[string "@Rarity\Core.lua"]:198: in function `DoEnable'
[string "@Rarity\Core.lua"]:167: in function <Rarity\Core.lua:166>
[string "=[C]"]: ?
[string "@ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:70: in function <...s\ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:65>
[string "@ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:527: in function `EnableAddon'
[string "@ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:630: in function <...s\ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:615>
Locals:
(*temporary) = "Blizzard_GarrisonUI"
Message: Interface\AddOns\OrderHallCommander\libs\LibInit\LibInit.lua:46: unexpected symbol near ']'
Time: Wed Oct 21 22:45:51 2020
Count: 1
Stack: Interface\AddOns\OrderHallCommander\libs\LibInit\LibInit.lua:46: unexpected symbol near ']'
[string "=[C]"]: in function `LoadAddOn'
[string "@Interface\FrameXML\UIParent.lua"]:495: in function `UIParentLoadAddOn'
[string "@Interface\FrameXML\UIParent.lua"]:685: in function `Garrison_LoadUI'
[string "@Interface\FrameXML\UIParent.lua"]:1940: in function <Interface\FrameXML\UIParent.lua:1258>
Locals: (*temporary) = "Blizzard_GarrisonUI"
This is regarding the function to Shift Click or Ctrl Click the Minimap icon to access legion mission preview/garrison mission preview
the previous macro or command to open garrison missions was
/run ShowGarrisonLandingPage(LE_GARRISON_TYPE_6_0)the previous macro or command to open orderhall missions was
/run ShowGarrisonLandingPage(LE_GARRISON_TYPE_7_0)these are now invalid
functionally commands are now
/run ShowGarrisonLandingPage(Enum.GarrisonType.Type_6_0)
and
/run ShowGarrisonLandingPage(Enum.GarrisonType.Type_7_0)/run ShowGarrisonLandingPage(2) also works for garrison
and /run ShowGarrisonLandingPage(3) for legion order hall
i have no idea if this is a problem for anyone else but me, but this is based on my own experience
Hello,
Probably the same error as posted in the comments below. Pops up when clicking on the follower tab.
Message: Interface\AddOns\OrderHallCommander\followerpage.lua:328: attempt to compare nil with number
Time: Sun Oct 18 11:53:52 2020
Count: 1
Stack: Interface\AddOns\OrderHallCommander\followerpage.lua:328: attempt to compare nil with number
[string "@Interface\AddOns\OrderHallCommander\followerpage.lua"]:328: in function <Interface\AddOns\OrderHallCommander\followerpage.lua:235>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `GarrisonMission_SetFollowerModel'
[string "@Interface\AddOns\Blizzard_GarrisonTemplates\Blizzard_GarrisonSharedTemplates.lua"]:1763: in function `ShowFollowerModel'
[string "@Interface\AddOns\Blizzard_GarrisonTemplates\Blizzard_GarrisonSharedTemplates.lua"]:2220: in function `ShowFollower'
[string "@Interface\AddOns\Blizzard_GarrisonTemplates\Blizzard_GarrisonSharedTemplates.lua"]:1356: in function `ShowFollower'
[string "@Interface\AddOns\Blizzard_GarrisonTemplates\Blizzard_GarrisonSharedTemplates.lua"]:132: in function <...rrisonTemplates\Blizzard_GarrisonSharedTemplates.lua:112>
[string "=[C]"]: in function `Show'
[string "@Interface\AddOns\Blizzard_GarrisonTemplates\Blizzard_GarrisonMissionTemplates.lua"]:69: in function `SelectTab'
[string "@Interface\AddOns\Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua"]:184: in function `SelectTab'
[string "@Interface\AddOns\Blizzard_GarrisonUI\Blizzard_OrderHallMissionUI.lua"]:226: in function `SelectTab'
[string "@Interface\AddOns\Blizzard_GarrisonTemplates\Blizzard_GarrisonMissionTemplates.lua"]:2342: in function <...risonTemplates\Blizzard_GarrisonMissionTemplates.lua:2338>
Locals: self = <table> {
OnInitialized = <function> defined @Interface\AddOns\OrderHallCommander\followerpage.lua:118
SetDefaultModuleLibraries = <function> defined @Interface\AddOns\!KalielsTracker\Libs\AceAddon-3.0\AceAddon-3.0.lua:367
AcquireButton = <function> defined @Interface\AddOns\OrderHallCommander\followerpage.lua:354
Enable = <function> defined @Interface\AddOns\!KalielsTracker\Libs\AceAddon-3.0\AceAddon-3.0.lua:294
NewModule = <function> defined @Interface\AddOns\!KalielsTracker\Libs\AceAddon-3.0\AceAddon-3.0.lua:235
EnableModule = <function> defined @Interface\AddOns\!KalielsTracker\Libs\AceAddon-3.0\AceAddon-3.0.lua:332
modules = <table> {
}
GetModule = <function> defined @Interface\AddOns\!KalielsTracker\Libs\AceAddon-3.0\AceAddon-3.0.lua:210
IterateEmbeds = <function> defined @Interface\AddOns\!KalielsTracker\Libs\AceAddon-3.0\AceAddon-3.0.lua:442
baseName = "Blizzard_OrderHallUI"
SecureHookScript = <function> defined @Interface\AddOns\Bartender4\libs\AceHook-3.0\AceHook-3.0.lua:410
defaultModuleLibraries = <table> {
}
TimeLeft = <function> defined @Interface\AddOns\DataStore\libs\AceTimer-3.0\AceTimer-3.0.lua:172
DrawButton = <function> defined @Interface\AddOns\OrderHallCommander\followerpage.lua:396
RenderButton = <function> defined @Interface\AddOns\OrderHallCommander\followerpage.lua:382
RawHookScript = <function> defined @Interface\AddOns\Bartender4\libs\AceHook-3.0\AceHook-3.0.lua:395
ScheduleRepeatingTimer = <function> defined @Interface\AddOns\DataStore\libs\AceTimer-3.0\AceTimer-3.0.lua:129
CancelAllTimers = <function> defined @Interface\AddOns\DataStore\libs\AceTimer-3.0\AceTimer-3.0.lua:160
CancelTimer = <function> defined @Interface\AddOns\DataStore\libs\AceTimer-3.0\AceTimer-3.0.lua:147
SendMessage = <function> defined @Interface\AddOns\PetTracker\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:59
GetName = <function> defined @Interface\AddOns\!KalielsTracker\Libs\AceAddon-3.0\AceAddon-3.0.lua:279
RefreshUpgrades = <function> defined @Interface\AddOns\OrderHallCommander\followerpage.lua:235
CheckEquipment = <function> defined @Interface\AddOns\OrderHallCommander\followerpage.lua:202
RenderUpgradeButton = <function> defined @Interface\AddOns\OrderHallCommander\followerpage.lua:184
name = "OrderHallCommander_Followerpage"
RenderEquipmentButton = <function> defined @Interface\AddOns\OrderHallCommander\followerpage.lua:1
updated to the prepatch version, is anyone else not able to swap between orderhall/garrison/bfa,
Shift/ctrl click does nothing and it only goes to bfa
Thank you very much sir! We will let you know if we find anything!
In reply to dblanch369:
Found one! When clicking tab for Followers, this was caught by bug sack...
1x OrderHallCommander\followerpage.lua:328: attempt to compare nil with number
[string "@OrderHallCommander\followerpage.lua"]:328: in function <OrderHallCommander\followerpage.lua:235>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `GarrisonMission_SetFollowerModel'
[string "@Blizzard_GarrisonTemplates\Blizzard_GarrisonSharedTemplates.lua"]:1763: in function `ShowFollowerModel'
[string "@Blizzard_GarrisonTemplates\Blizzard_GarrisonSharedTemplates.lua"]:2220: in function <...rrisonTemplates\Blizzard_GarrisonSharedTemplates.lua:2212>
[string "=[C]"]: in function `ShowFollower'
[string "@Blizzard_GarrisonTemplates\Blizzard_GarrisonSharedTemplates.lua"]:1356: in function <...rrisonTemplates\Blizzard_GarrisonSharedTemplates.lua:1354>
[string "=[C]"]: in function `ShowFollower'
[string "@Blizzard_GarrisonTemplates\Blizzard_GarrisonSharedTemplates.lua"]:125: in function <...rrisonTemplates\Blizzard_GarrisonSharedTemplates.lua:112>
[string "=[C]"]: in function `Show'
[string "@Blizzard_GarrisonTemplates\Blizzard_GarrisonMissionTemplates.lua"]:69: in function `SelectTab'
[string "@Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua"]:184: in function `SelectTab'
[string "@Blizzard_GarrisonUI\Blizzard_OrderHallMissionUI.lua"]:226: in function `SelectTab'
[string "@Blizzard_GarrisonTemplates\Blizzard_GarrisonMissionTemplates.lua"]:2342: in function <...risonTemplates\Blizzard_GarrisonMissionTemplates.lua:2338>
Locals:
self = <table> {
OnInitialized = <function> defined @OrderHallCommander\followerpage.lua:118
SetDefaultModuleLibraries = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:367
AcquireButton = <function> defined @OrderHallCommander\followerpage.lua:354
Enable = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:294
NewModule = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:235
EnableModule = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:332
modules = <table> {
}
GetModule = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:210
IterateEmbeds = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:442
baseName = "Blizzard_OrderHallUI"
SecureHookScript = <function> defined @Ace3\AceHook-3.0\AceHook-3.0.lua:410
defaultModuleLibraries = <table> {
}
TimeLeft = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:172
DrawButton = <function> defined @OrderHallCommander\followerpage.lua:396
RenderButton = <function> defined @OrderHallCommander\followerpage.lua:382
RawHookScript = <function> defined @Ace3\AceHook-3.0\AceHook-3.0.lua:395
ScheduleRepeatingTimer = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:129
CancelAllTimers = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:160
CancelTimer = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:147
SendMessage = <function> defined @Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:59
GetName = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:279
RefreshUpgrades = <function> defined @OrderHallCommander\followerpage.lua:235
CheckEquipment = <function> defined @OrderHallCommander\followerpage.lua:202
RenderUpgradeButton = <function> defined @OrderHallCommander\followerpage.lua:184
name = "OrderHallCommander_Followerpage"
RenderEquipmentButton = <function> defined @OrderHallCommander\followerpage.lua:163
IsEnabled = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:451
orderedModules = <table> {
}
ScheduleTimer = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:94
DisableModule = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:350
GARRISON_FOLLOWER_UPGRADED = <function> defined @OrderHallCommander\followerpage.lua:150
ShowFollowerData = <function> defined @OrderHallCommander\followerpage.lua:143
Events = <function> defined @OrderHallCommander\followerpage.lua:138
Disable = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:314
RegisterMessage = <function> defined @Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
HookScript = <function> defined @Ace3\AceHook-3.0\AceHook-3.0.lua:366
IsHooked = <function> defined @Ace3\AceHook-3.0\AceHook-3.0.lua:493
OnInitialize = <function> defined @OrderHallCommander\libs\LibInit\LibInit.lua:404
ReleaseButton = <function> defined @OrderHallCommander\followerpage.lua:376
IsModule = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:217
defaultModuleState = true
SetDefaultModuleState = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:387
UnregisterAllEvents = <function> defined @Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
UpgradeTooltip = <function> defined @OrderHallCommander\followerpage.lua:339
SetEnabledState = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:424
Hook = <function> defined @Ace3\AceHook-3.0\AceHook-3.0.lua:274
enabledState = true
UnregisterMessage = <function> defined @Ace3\CallbackHandler-1.0\Ca
Release, please check it!
In reply to alarthedark:
did you check the pull i made ?
In reply to gaver_sh:
Yes I had a look at it but i think I already made all the changes on my side.
When I attempted to check the PR it was full of conflicts, probably because I saw it only AFTER I pushed my modifications OR beacuse the line ending from your PC was not the right one.
All files looked completely changed so reviewing changes was hard
In reply to alarthedark:
Thank you dude. You are doing lord's work. Among all mission table managers I found this one the most useful to me. Thanks again for all three addons.
Pls fix this
Thx
1x OrderHallCommander\cache.lua:712: Usage: GetCurrencyTypes(garrType)
[string "=[C]"]: in function `GetCurrencyTypes'
[string "@OrderHallCommander\cache.lua"]:712: in function <OrderHallCommander\cache.lua:710>
[string "=(tail call)"]: ?
[string "=[C]"]: ?
[string "@Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:70: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:65>
[string "@Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:498: in function `InitializeAddon'
[string "@Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:623: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:615>
[string "=[C]"]: in function `LoadAddOn'
[string "@FrameXML\UIParent.lua"]:495: in function `UIParentLoadAddOn'
[string "@FrameXML\UIParent.lua"]:685: in function `Garrison_LoadUI'
[string "@FrameXML\UIParent.lua"]:1940: in function <FrameXML\UIParent.lua:1258>
championcommander, garrisoncommander, and orderhallcommander are not working as of prepatch for shadowlands
In reply to jamesmevarts3:
Hi all, while I am no longer playing wow a lot, I will have a look on this in a couple of day.
Addon code is on githubg so if anyone want to help.. feel free
In reply to alarthedark:
https://github.com/gaveer/OrderHallCommander
In reply to gaver_sh:
your code changes, do they work?
In reply to Ashardiss:
not full , still missing few , but i was helping alarthedarkala
Broken in 9.0.1
In reply to FERALMODE:
Confirmed - completely borked in 9.0.1
With some class hall missions, I have to manually fill the empty slots to get the success chance over 100%. I'm not sure I have it configured correctly, but I don't remember having this issue before. Anyone have an idea?