After increasing my companions to a total of 22, the addon companions selection GUI now reverts back to the traditional Blizzard UI with the unfiltered, messy companions list. Is it possible that at a certain high number the companions are too many to be listed in the addon GUI so it has to revert back?

If If that's the cause, it would be great if in the future there is the possibility of adding a scroll option or a way to reduce the scale of the companion icons so that you can still utilize the addon GUI for companion selection. It's been really helpful to have a full overview of their levels in descending order along with the easy indicators for troops that can be upgraded.

Hello,

Get the following error if you try to scroll the mission list when there are not enough to fill the window. It doesn't stop the addon working but thought id let you know. All the best.

1x [ADDON_ACTION_FORBIDDEN] 插件 'OrderHallCommander' 尝试调用保护功能 'UseToy()'。
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: in function `UseToy'
[string "@Blizzard_Collections\Blizzard_ToyBox.lua"]:181: in function `ToySpellButton_OnClick'
[string "*:OnClick"]:4: in function <[string "*:OnClick"]:1>

The current addon doesn't seem to be able to recognize the veterans of argus - it adds in no bonus for using them on a mission, even if the mission requires a veteran of argus.

as mentioned on garrisoncommander, there are issues here too. 

some of them reference garrison but here are the ones referencing orderhall. 

Message: Interface\AddOns\OrderHallCommander\cache.lua:901: attempt to compare number with nil
Time: Sun Jul 11 04:27:40 2021
Count: 1
Stack: Interface\AddOns\OrderHallCommander\cache.lua:901: attempt to compare number with nil
[string "=[C]"]: ?
[string "@Interface\AddOns\OrderHallCommander\cache.lua"]:901: in function `GetFullPermutations'
[string "@Interface\AddOns\OrderHallCommander\matchmaker.lua"]:691: in function `?'
[string "@Interface\AddOns\OrderHallCommander\missionlist.lua"]:544: in function <Interface\AddOns\OrderHallCommander\missionlist.lua:528>
[string "=(tail call)"]: ?
[string "@Interface\AddOns\OrderHallCommander\missionlist.lua"]:573: in function `ReloadMissions'
[string "@Interface\AddOns\OrderHallCommander\missionlist.lua"]:745: in function <Interface\AddOns\OrderHallCommander\missionlist.lua:726>
[string "=(tail call)"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function `Show'
[string "@Interface\FrameXML\UIParent.lua"]:2928: in function `SetUIPanel'
[string "@Interface\FrameXML\UIParent.lua"]:2734: in function `ShowUIPanel'
[string "@Interface\FrameXML\UIParent.lua"]:2641: in function <Interface\FrameXML\UIParent.lua:2637>
[string "=[C]"]: in function `SetAttribute'
[string "@Interface\FrameXML\UIParent.lua"]:3492: in function `ShowUIPanel'
[string "@Interface\FrameXML\UIParent.lua"]:1976: in function <Interface\FrameXML\UIParent.lua:1287>

Message: Interface\AddOns\OrderHallCommander\cache.lua:901: attempt to compare number with nil
Time: Sun Jul 11 04:30:19 2021
Count: 8
Stack: Interface\AddOns\OrderHallCommander\cache.lua:901: attempt to compare number with nil
[string "=[C]"]: ?
[string "@Interface\AddOns\OrderHallCommander\cache.lua"]:901: in function `GetFullPermutations'
[string "@Interface\AddOns\OrderHallCommander\matchmaker.lua"]:691: in function `?'
[string "@Interface\AddOns\OrderHallCommander\missionlist.lua"]:544: in function <Interface\AddOns\OrderHallCommander\missionlist.lua:528>
[string "=(tail call)"]: ?
[string "@Interface\AddOns\OrderHallCommander\missionlist.lua"]:585: in function `RedrawMissions'
[string "@Interface\AddOns\OrderHallCommander\missionlist.lua"]:369: in function <Interface\AddOns\OrderHallCommander\missionlist.lua:368>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `Update'
[string "@Interface\AddOns\Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua"]:1202: in function <...s\Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:1175>
[string "=[C]"]: ?

Oddly enough, the addon works for me EXCEPT for certain classes: Warlock and Demon Hunter. Those two classes I have to completely disable the addon in order to send missions. Haven't tried every class yet, but that's what I noticed so far. Will update if there's another class that doesn't work, etc.

No longer allows auto fill of champions, does the same thing as the blizzard one now. And it is a really awesome addon, as they all are, when it functions correctly. I am hoping you are just waiting for blizzard to stop mini patches, before releasing. Also when I clicked open ticket for Championcommander, it brought me here. 

In reply to alarthedark:

 I appreciate that, you are awesome, these addons are amazing, they sure save a lot of calculations, the latest one being super freaking awesome, they just keep getting better. I understand RL and if I still could code, I would have the fix for any of the broken parts, but my brain is now mush LOL. Anyway thanks for responding. Just wanted to make you aware, cheers. 

Hello! I Thank you for the great addon! I just want to tell you that the sound when I choose missions (in Legion) is very loud. It would be nice if there was a way to adjust the sound volume.

Error with latest v1.8.5 dated 11/18/2020, when checking board at druid class order hall:

14x OrderHallCommander\missionlist.lua:913: bad argument #3 to 'SetFormattedText' (string expected, got nil)
[string "=[C]"]: in function `SetFormattedText'
[string "@OrderHallCommander\missionlist.lua"]:913: in function `AdjustMissionButton'
[string "@OrderHallCommander\missionlist.lua"]:407: in function `OnSingleUpdate'
[string "@OrderHallCommander\missionlist.lua"]:589: in function `RedrawMissions'
[string "@OrderHallCommander\missionlist.lua"]:369: in function <OrderHallCommander\missionlist.lua:368>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `Update'
[string "@Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua"]:921: in function <...s\Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:901>
[string "=(tail call)"]: ?
[string "@Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua"]:448: in function `UpdateMissions'
[string "@Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua"]:96: in function `OnEventMainFrame'
[string "@Blizzard_GarrisonUI\Blizzard_OrderHallMissionUI.lua"]:119: in function <...\Blizzard_GarrisonUI\Blizzard_OrderHallMissionUI.lua:115>

Locals:
(*temporary) = <unnamed> {
 0 = <userdata>
}
(*temporary) = "%s
%s"
(*temporary) = "Mission Expires"
(*temporary) = nil
(*temporary) = "string expected, got nil"

I'm not the parent poster, but I'm also getting this same error and debug trace.

It looks like this can happen when missions don't have an expire time. For example, the Druid mission "Gathering the Dreamweavers: Thisalee Crow".

To test this, I modified line 913 to check if offerTimeRemaining is truthy:

    if mission.offerTimeRemaining then
        stats.Expire:SetFormattedText("%s\n%s",GARRISON_MISSION_AVAILABILITY,mission.offerTimeRemaining)
    else
        stats.Expire:SetFormattedText("%s\n%s",GARRISON_MISSION_AVAILABILITY,"???")
    end

... which resulted in the expected:

I don't know what 1.8.5 fixed, but it did not include a nil check for mission remaining and end times in missionlist.lua, so that error should still pop.  I put my own nil check in and the board lists perfectly.

In reply to alarthedark:

 Just very basic using local variables, starting at line 900:

	local stats=missionstats[frame]
	local aLevel,aIlevel=addon:GetAverageLevels()
	local remaining,endtime
	if mission.offerTimeRemaining == nil then
		remaining = ""
	else
		remaining = mission.offerTimeRemaining
	end
	if mission.offerEndTime == nil then
		endtime = ""
	else
		endtime = mission.offerEndTime
	end
	if mission.isMaxLevel then
		frame.Level:SetText(mission.iLevel)
		frame.Level:SetTextColor(addon:GetDifficultyColors(math.floor((aIlevel-750)/(mission.iLevel-750)*100)))
	else
		frame.Level:SetText(mission.level)
		frame.Level:SetTextColor(addon:GetDifficultyColors(math.floor(aLevel/mission.level*100)))
	end
	if mission.inProgress then
		stats:SetPoint("LEFT",48,14)
		stats.Expire:Hide()
	else
		stats.Expire:SetFormattedText("%s\n%s",GARRISON_MISSION_AVAILABILITY,remaining)
		stats.Expire:SetTextColor(addon:GetAgeColor(endtime))
		stats:SetPoint("LEFT",48,0)