Waterproof 2: And This Time, It's Serious

1,643 Downloads Last Updated: Oct 25, 2018 Game Version: 1.12.2

Water. The bane of redstone engineers and tracklayers everywhere. It flows all over your builds and causes everything to fall off... Right?

putting the "oof" in waterproof

Not anymore! Waterproof 2 simply blocks water (and other fluids) from flowing into redstone and rails. The list of blocks is configurable; the defaults are shown in the above image. Or, if you will, it puts the "oof" in "waterproof".

This makes use of a class transformer; it's a coremod, so keep that in mind.

Waterproof 2: And This Time It's Serious is a continuation/port/recode/whatever of Waterproof, by Vazkii.

Of course you can use this in your modpack. Idk is having to beg modders for modpack permissions still a thing? I hope not.

Questions? Comments? Just lonely? Join me on Discord: https://discord.gg/V7MHuTW

Comments

Dimentive
- Join Date: 12/4/2017
- Posts: 971
- Member Details
Dimentive

View User Profile

Send Message

Posted Apr 1, 2019 #8
If they don’t incorporate this very change into vanilla, I will lose all faith in Mojang. (Okay, not really, but still, pls, Mojang.)

Rollback Post to Revision Rollback
yekulten
- Join Date: 6/5/2018
- Posts: 299
- Member Details
yekulten

View User Profile

Send Message

Posted Feb 14, 2019 #7
This is actually really useful.

Rollback Post to Revision Rollback
roko_lol
- Join Date: 9/25/2018
- Posts: 212
- Member Details
roko_lol

View User Profile

Send Message

Posted Feb 11, 2019 #4
can you make it work with secret rooms with secret rooms the levers and buttons just break in water

thanks

Rollback Post to Revision Rollback
quat1024
- Join Date: 4/16/2016
- Posts: 190
- Member Details
quat1024

View User Profile

Send Message

Posted Feb 11, 2019 #5
did you try adding their item IDs to the config file?

Rollback Post to Revision Rollback
roko_lol
- Join Date: 9/25/2018
- Posts: 212
- Member Details
roko_lol

View User Profile

Send Message

Posted Feb 11, 2019 #6
In reply to quat1024:

i was gonna make a underwater base

but i changed my mind.

Rollback Post to Revision Rollback
RedstoneRebel67
- Join Date: 11/16/2013
- Posts: 2
- Member Details
RedstoneRebel67

View User Profile

Send Message

Posted Oct 25, 2018 #1
Great idea! I have never built anything with redstone that hasn't been messed up by water at least once. And the few times I have tried to build something under water were so frustrating. I bet even the under water redstone experts will appreciate this mod.

Can you dumb this down for me please?

quote;

"This makes use of a class transformer; it's a coremod, so keep that in mind."

Last edited by RedstoneRebel67: Oct 25, 2018

Rollback Post to Revision Rollback
quat1024
- Join Date: 4/16/2016
- Posts: 190
- Member Details
quat1024

View User Profile

Send Message

Posted Oct 25, 2018 #2
So basically, when the game is on (or is about to be on) the loading screen, it loads each of the game classes, one by one, in turn. Classes contain executable Java code. Eventually it gets to this vanilla class called BlockDynamicLiquid, which is the class that the vanilla water and lava blocks are instances of. When it does, I just add an additional line of code to it - there's this method called "canFlowInto" which returns "true" for blocks like air, plants, rails, redstone; and "false" on solid blocks that block a fluid. I simply patch that method to blacklist a few more blocks.

That's a class transformer, since it's "transforming" the class into something else. The term coremod refers to a mod that uses 1 or more of these class transformers. (The name "coremod" is a bit weird; I think it's a holdover from when you couldn't put class transformers and other mods in the same JAR file? Sometimes they are referred to as ASM, after ObjectWeb ASM, the Java library often used to write class transformers.)

They are a bit dangerous, since if I screw up the patch the game can fail to load, and they can cause debugging headaches since the Minecraft source code no longer matches the code in the running game. It's customary to mention their use for that reason, and that's why all Forge crash logs prominently list the loaded coremods.

InsomniaKitten pointed out that I'd be able to registry replace the water and lava blocks instead. Instead of changing the vanilla fluid block, I just make a new one with the changed fluid flow behavior, and replace the vanilla one with mine. That sounds a lot less hacky.

Hopefully that makes sense. Btw, I only need the class transformer for the 2 vanilla fluids. Forge has its own ready-to-use fluid blocks, pretty much everyone who makes a modded fluid just uses one of those blocks. And those block classes have a convenient list of blocks they will ignore. I can just add entries to the list ezpz ;)

Last edited by quat1024: Oct 25, 2018

Rollback Post to Revision Rollback
RedstoneRebel67
- Join Date: 11/16/2013
- Posts: 2
- Member Details
RedstoneRebel67

View User Profile

Send Message

Posted Oct 26, 2018 #3
In reply to quat1024:

Thanks for the explanation. Kind of took me back to the old days and how we had to extract the class files and delete the meta_inf file. I remember the controversy about how it was hacky and troublesome, often having to delete the whole .minecraft folder to fix the errors. I lost many maps during that time. Can't even remember what versions that was.

Thanks again.

Rollback Post to Revision Rollback
To post a comment, please login or register a new account.

About Project

Report

Project ID 305564

Created Oct 25, 2018

Updated Oct 25, 2018

Total Downloads 1,643

License Custom License

Members

quat1024

Owner

Vazkii_

Former Author