As you wander around Azeroth, your reputation bar will switch depending on where you are, not by which quest gave you a faction bump.
Supports:
- Gained Retail WoW support! It is incomplete, but I'm working on it.
- Zones by faction: Stormwind, Darkspear Trolls, Gnomeregan Exiles, Orgrimmar, etc.
- Instances by faction: Hydraxian Waterlords, Brood of Nozdormu, etc
- Battlegrounds by faction: Silverpike Guard, Warsong Outriders, etc
- Subzones by faction: several little areas in various zones have pockets of faction hubs
Missing data:
- If you find any subzones that have quest hubs I've missed, I need the text from the minimap in ENGLISH, your basic faction (Horde or Alliance), and the proper faction in ENGLISH to match. To get the instanceIDs for me: when you enter an instance that is missing a reputation or is incorrect, type into chat
/rdump select(8, GetInstanceInfo())and send me the number printed to chat. - Some retail maps are "recycled" depending on the phase you are, like Vale of Eternal Blossoms. To get the correct UiMapID, I need data from
/dump WorldMapFrame:GetMapID()please and thank you.
Open the options:
/rbz/repbyzoneESC, Interface, AddOns, RepByZone
Translate:
RepByZone has its own translations and LibAboutPanel-2.0's localizations.
Known Issues:
- In some rare cases, characters have not learned their racial or class reputation because they have not interacted with an NPC from that faction. This causes the Default Watched Reputation menu to have nothing selected. For example, my Rogue has never interacted with Ravenholdt. I could go down the rabbit hole and provide workarounds, but upon testing, this proved to be a bad idea. Please check this menu when you first log into a character, and if required, select a Default Watched Reputation if you wish. Not selecting one will do no harm, and once your character learns the reputation, RepByZone will fix itself.
- It is not possible to display zone or subzone data for reputations the character has not yet discovered. Examples would be Gurubashi Arena and Bloodsail Buccaneers faction, or Arathi Highlands and Wildhammer Clan faction. Once a character gains or loses any amount of reputation with that faction and moves around the zone, RBZ will update. Discovering the faction may require the character to explore other zones or even continents.
Every time I think I've fixed an error, another one seems to crop up. The main issue stems from when Blizzard provides access to the faction data that players know. I keep delaying when I am accessing it, but I've run out of options. That said, I am not giving up, because I know it can be done. I just have to work around Blizzard's incompetent design.
For example, you can get data about reputations almost as early in the load process as possible, but you cannot get that same data about the reputations a player character knows until near the end of the load process. This causes a mismatch because of when zone data and where the player character is during login doesn't mesh with what the UI displays, or knows.
One of the few options left to me is to artificially delay setting the watched faction by a second or two after the players logs in or enters a zone or subzone. I'm looking into that as a possibility.
In other words, except when I actually write a bug into the code (and I have, see 1.19.5 as proof that I don't catch all of my bugs), most of the problems are Blizzard not knowing how to write code logically.
Anyway, I'm spinning a lot of plates here, but I haven't given up. I wanted this addon, so I'll hammer at it until it works, one way or another.
In reply to Sygon_Paul:
Incidentally, if the player character knows a faction that I associate with a zone, there doesn't seem to be any errors or issues. It's only when a player hasn't discovered a faction that I get "comparing number with nil" type of errors, which I try to address by assigning backup, racial, reputations, but I haven't always been successful. This is because I added support for class-based reputations, which the player character may or may not know.
One solution is to remove support for class-based reputations, or default to basic factions like Stormwind, Orgrimmar, etc, which all characters know. Both of those ideas are on the table, but that does force removal of a feature just to resolve Blizzard's weird code.
Message: Interface\AddOns\RepByZone\Core-BCC.lua:120: Usage: GetFactionInfoByID(id)
Time: Mon Jun 7 12:38:12 2021
Count: 1
Stack: Interface\AddOns\RepByZone\Core-BCC.lua:120: Usage: GetFactionInfoByID(id)
[string "=[C]"]: in function `GetFactionInfoByID'
[string "@Interface\AddOns\RepByZone\Core-BCC.lua"]:120: in function <Interface\AddOns\RepByZone\Core-BCC.lua:116>
[string "=[C]"]: ?
[string "@Interface\AddOns\Attune\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:70: in function <...ace\AddOns\Attune\Libs\AceAddon-3.0\AceAddon-3.0.lua:65>
[string "@Interface\AddOns\Attune\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:527: in function `EnableAddon'
[string "@Interface\AddOns\Attune\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:630: in function <...ace\AddOns\Attune\Libs\AceAddon-3.0\AceAddon-3.0.lua:615>
Locals: <none>
I have the BCC thing fixed on my end, but Curseforge is crashing today, preventing an upload. You can edit your Core-BCC.lua and Core-Classic.lua files and remove this line in function RepByZone:OnEnable()
self.covenantRepID = self:CovenantToFactionID()
And that will fix the issue until Curseforge is working again. It was a copy and paste error on my behalf. RBZ 1.19.6 will have the fix, whenever I can upload to Curseforge.
In reply to Sygon_Paul:
Nice! Cheers <3
In reply to Sygon_Paul:
Now I have a new error message
Message: Interface\AddOns\RepByZone\Core-BCC.lua:120: Usage: GetFactionInfoByID(id)
Time: Sun Jun 6 18:24:09 2021
Count: 1
Stack: Interface\AddOns\RepByZone\Core-BCC.lua:120: Usage: GetFactionInfoByID(id)
[string "@Interface\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:70: in function <...face\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua:65>
[string "@Interface\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:527: in function `EnableAddon'
[string "@Interface\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:630: in function <...face\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua:615>
Locals: <none>
In reply to doktore1100:
I'm also experiencing this same error. Shame because the addon is a great idea but has stopped working now because of this.
In reply to DomDashSix:
You can delete the code in line 120
db.watchedRepName = GetFactionInfoByID(db.watchedRepID)
But then it no longer works in the inis. At least not in Sethekk. I haven't been to another ini for the last few day.
Stopped working for me a few days ago.
1x RepByZone\Core-BCC.lua:119: attempt to call method 'CovenantToFactionID' (a nil value)
[string "@RepByZone\Core-BCC.lua"]:119: in function `OnEnable'
[string "@RepByZone\Options-Options.lua"]:24: in function <RepByZone\Options.lua:21>
[string "=[C]"]: ?
[string "@Attune\Libs\AceConfig-3.0-3\AceConfigDialog-3.0\AceConfigDialog-3.0-81.lua"]:51: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:49>
[string "@Attune\Libs\AceConfig-3.0-3\AceConfigDialog-3.0\AceConfigDialog-3.0-81.lua"]:847: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:668>
[string "=[C]"]: ?
[string "@Attune\Libs\AceGUI-3.0\AceGUI-3.0-41.lua"]:72: in function <Attune\Libs\AceGUI-3.0\AceGUI-3.0.lua:70>
[string "@Attune\Libs\AceGUI-3.0\AceGUI-3.0-41.lua"]:306: in function `Fire'
[string "@Attune\Libs\AceGUI-3.0-41\widgets\AceGUIWidget-CheckBox.lua"]:68: in function <...ne\Libs\AceGUI-3.0\widgets\AceGUIWidget-CheckBox.lua:57>
In reply to Trouler_Darkhand:
Same issue. "CovenantToFactionID" sounds like a retail setting to me.
Doesnt work for me, seems like it is bugged, have installed latest from curseforge.
Another missing ,
https://github.com/Myrroddin/repbyzone/blob/master/Core-BCC.lua#L255
There should be a comma at the end of that entry.
In reply to TorakTheUnprepared:
Man, I gotta stop coding when I am half asleep. Thank you.
For those of you playing TBC Classic, I desperately need the uiMapIDs for the zones introduced, like Exodar, Silverymoon, Ghostlands, TBC Draenor, etc. I am 99% certain that the retail WoW uiMapIDs are not the same, because they weren't the same for WoW Classic.
To get the numbers, use /dump WorldMapFrame:GetMapID() and make a note of the number and zone name, and write them here. The subzone data hasn't changed, and I am using that without issue, and the instanceIDs also work correctly. I'm asking about the world zones.
In reply to Sygon_Paul:
Nevermind. Ketho found them all for me! TBC Classic is complete as of 1.19.3, barring localization updates.
Message: Interface\AddOns\RepByZone\Data-BCC.lua:288: '}' expected (to close '{' at line 135) near '['
Time: Thu May 20 18:22:24 2021
Count: 1
Stack: Interface\AddOns\RepByZone\Data-BCC.lua:288: '}' expected (to close '{' at line 135) near '['
Locals:
Message: Interface\AddOns\RepByZone\Core-BCC.lua:101: attempt to call method 'InstancesAndFactionList' (a nil value)
Time: Thu May 20 18:22:24 2021
Count: 1
Stack: Interface\AddOns\RepByZone\Core-BCC.lua:101: attempt to call method 'InstancesAndFactionList' (a nil value)
[string "@Interface\AddOns\RepByZone\Core-BCC.lua"]:101: in function <Interface\AddOns\RepByZone\Core-BCC.lua:64>
[string "=[C]"]: ?
[string "@Interface\AddOns\Attune\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:70: in function <...ace\AddOns\Attune\Libs\AceAddon-3.0\AceAddon-3.0.lua:65>
[string "@Interface\AddOns\Attune\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:498: in function `InitializeAddon'
[string "@Interface\AddOns\Attune\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:623: in function <...ace\AddOns\Attune\Libs\AceAddon-3.0\AceAddon-3.0.lua:615>
Locals: <none>
Message: Interface\AddOns\RepByZone\Core-BCC.lua:293: bad argument #1 to 'pairs' (table expected, got nil)
Time: Thu May 20 18:22:25 2021
Count: 1
Stack: Interface\AddOns\RepByZone\Core-BCC.lua:293: bad argument #1 to 'pairs' (table expected, got nil)
[string "=[C]"]: in function `pairs'
[string "@Interface\AddOns\RepByZone\Core-BCC.lua"]:293: in function `SwitchedZones'
[string "@Interface\AddOns\RepByZone\Core-BCC.lua"]:168: in function `?'
[string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:119: in function <...sic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>
[string "=[C]"]: ?
[string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:29: in function <...sic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:64: in function `Fire'
[string "@Interface\AddOns\Attune\Libs\AceEvent-3.0\AceEvent-3.0.lua"]:120: in function <...ace\AddOns\Attune\Libs\AceEvent-3.0\AceEvent-3.0.lua:119>
Locals: <none>
Message: Interface\AddOns\RepByZone\Data-BCC.lua:288: '}' expected (to close '{' at line 135) near '['
Time: Thu May 20 18:22:25 2021
Count: 3
Message: Interface\AddOns\RepByZone\Core-BCC.lua:293: bad argument #1 to 'pairs' (table expected, got nil)
Time: Thu May 20 18:23:11 2021
Count: 3
Stack: Interface\AddOns\RepByZone\Core-BCC.lua:293: bad argument #1 to 'pairs' (table expected, got nil)
[string "=[C]"]: in function `pairs'
[string "@Interface\AddOns\RepByZone\Core-BCC.lua"]:293: in function `?'
[string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:119: in function <...sic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>
[string "=[C]"]: ?
[string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:29: in function <...sic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:64: in function `Fire'
[string "@Interface\AddOns\Attune\Libs\AceEvent-3.0\AceEvent-3.0.lua"]:120: in function <...ace\AddOns\Attune\Libs\AceEvent-3.0\AceEvent-3.0.lua:119>
Locals: <none>
In reply to Trouler_Darkhand:
FYI, this is caused by line 287 of Data-BCC.lua having a '.' instead of a ',' after the reputation identifier.
The line looks like this:
And should look like this:
In reply to TorakTheUnprepared:
I'm pushing 1.19.2 to fix that error. Thank you for the quick report!
Myrroddin,
The DB bug was squashed, but not getting the following errors with 1.18.1-17-g64ad8dd on retail:
Count: 1
Message: ..\AddOns\RepByZone\Data-Retail.lua line 373:
'}' expected (to close '{' at line 136) near '['
Debug:
[string "=[C]"]: ?
----
Message: ..\AddOns\RepByZone\Core-Retail.lua line 118:
attempt to call method 'ZoneAndFactionList' (a nil value)
Debug:
[string "=(tail call)"]: ?
[string "@RepByZone\Core-Retail.lua"]:118:
RepByZone\Core-Retail.lua:83
[string "=[C]"]: ?
[string "@Bazooka\libs\Ace3\AceAddon-3.0\AceAddon-3.0.lua"]:70:
...dOns\Bazooka\libs\Ace3\AceAddon-3.0\AceAddon-3.0.lua:65
[string "@Bazooka\libs\Ace3\AceAddon-3.0\AceAddon-3.0.lua"]:498: InitializeAddon()
[string "@Bazooka\libs\Ace3\AceAddon-3.0\AceAddon-3.0.lua"]:623:
...dOns\Bazooka\libs\Ace3\AceAddon-3.0\AceAddon-3.0.lua:615
Locals:
None
-----
Message: ..\AddOns\RepByZone\Core-Retail.lua line 356:
bad argument #1 to 'pairs' (table expected, got nil)
Debug:
[string "=(tail call)"]: ?
[string "=[C]"]: pairs()
[string "@RepByZone\Core-Retail.lua"]:356: SwitchedZones()
[string "@RepByZone\Core-Retail.lua"]:208: JoinedCovenant()
[string "@RepByZone\Core-Retail.lua"]:137:
RepByZone\Core-Retail.lua:122
[string "=[C]"]: ?
[string "@Bazooka\libs\Ace3\AceAddon-3.0\AceAddon-3.0.lua"]:70:
...dOns\Bazooka\libs\Ace3\AceAddon-3.0\AceAddon-3.0.lua:65
[string "@Bazooka\libs\Ace3\AceAddon-3.0\AceAddon-3.0.lua"]:527: EnableAddon()
[string "@Bazooka\libs\Ace3\AceAddon-3.0\AceAddon-3.0.lua"]:630:
...dOns\Bazooka\libs\Ace3\AceAddon-3.0\AceAddon-3.0.lua:615
Locals:
None
In reply to Nechckn:
Weird. I'm not getting any errors on Retail. I'll see if I can replicate it with only BugSack and RepByZone enabled.