PapaGreet

tag 05ff5aeea0d0b06f78f9af7ced11d23c49bcdb0d v1.2.2
Author:    Alan Denniston <alan.denniston@gmail.com>
Date:    Mon Oct 13 02:54:40 2025 -0400

Version 1.2.2 - Fix menu popups and improve delete dropdown UX

Major Fixes:
- Fixed editBox access in all StaticPopupDialogs (was causing all add buttons to fail)
- All menu buttons now functional (Create Profile, Add Greeting/Goodbye/Emotes)
- Default profile is now read-only (cannot be modified)

UI Improvements:
- Removed overlapping delete labels
- Delete dropdowns now show 'Delete [item]' format
- Cleaner menu layout with proper spacing
- Improved popup visibility with proper frame strata

Bug Fixes:
- Fixed goodbye message/emote not sending in dungeons (leave timer now waits for message)
- Fixed cooldown system initialization
- Fixed memory leak in menu frame creation

commit 3d1abc6dbaeba6719657ac3031f17c3f43a072fa
Author: Alan Denniston <alan.denniston@gmail.com>
Date:   Mon Oct 13 02:49:10 2025 -0400

    Improve delete dropdown UX - remove labels, show 'Delete [item]'

    Changes:
    - Removed yellow label text above delete dropdowns
    - Changed dropdown items from just showing item name to 'Delete [item]'
    - Changed default dropdown text from 'Select to Delete' to 'Delete...'
    - Removed label parameter from createDeleteDropdown function
    - Dropdowns now align directly with Add buttons (no extra spacing)

    This provides clearer UX without overlapping text.

commit a38e016f3245ba37d41c780fe98d4f79a7d9cc41
Author: Alan Denniston <alan.denniston@gmail.com>
Date:   Mon Oct 13 02:44:02 2025 -0400

    Increase spacing between delete labels and dropdowns

    Changed dropdown Y offset from -25 to -35 to prevent text overlap with dropdown buttons.

commit 72834e666cca6f08d833033da121b034692e7ecd
Author: Alan Denniston <alan.denniston@gmail.com>
Date:   Mon Oct 13 02:40:41 2025 -0400

    Fix editBox access in all StaticPopupDialogs

    THE BUG: self.editBox is nil in StaticPopup OnAccept/OnShow handlers
    THE FIX: Access editBox via _G[self:GetName().."EditBox"]

    Fixed all popups:
    - PAPA_GREET_CREATE_PROFILE
    - PAPA_GREET_COPY_PROFILE
    - PAPA_GREET_ADD_GREETING
    - PAPA_GREET_ADD_GOODBYE
    - PAPA_GREET_ADD_GREETING_EMOTE
    - PAPA_GREET_ADD_GOODBYE_EMOTE

    All add buttons should now work properly!

commit e3f682587746922289957bc6b63228942460adc4
Author: Alan Denniston <alan.denniston@gmail.com>
Date:   Mon Oct 13 02:34:30 2025 -0400

    Add better error handling in OnAccept to diagnose editBox issue

    The OnAccept handler is being called but crashing immediately after.
    Added checks to see if editBox exists and has GetText method.

commit be66b20bfd43b4450dceee637794a85cdba0b6d5
Author: Alan Denniston <alan.denniston@gmail.com>
Date:   Mon Oct 13 02:31:53 2025 -0400

    Add debug output to OnAccept handler for Create Profile popup

    This will help diagnose if the popup's Create button is actually triggering OnAccept or if there's an issue with the button handler itself.

commit 6b75f31503625fa279d94ddd4311f8302bbe8a73
Author: Alan Denniston <alan.denniston@gmail.com>
Date:   Mon Oct 13 02:27:30 2025 -0400

    Bump version to 1.2.2 to force WoW to reload addon

    Version bump should force WoW to recognize the addon has changed and reload the new code with all the debugging features.

commit 4b99d73e49ca74ab646a8d550c12e77cfe7d653c
Author: Alan Denniston <alan.denniston@gmail.com>
Date:   Mon Oct 13 02:16:37 2025 -0400

    Add button creation debugging and change template

    Button Creation Debug:
    - Added debug output when buttons are created
    - Shows button name and text after creation
    - Added OnEnter handler to test if buttons are interactive

    Template Change:
    - Changed from GameMenuButtonTemplate to UIPanelButtonTemplate
    - UIPanelButtonTemplate is more reliable for click handling

    This will help identify if:
    1. Buttons are being created at all
    2. Buttons are interactive (mouse enter works)
    3. Different template fixes click issues

commit 9ef8a0f66e0710566919ccb1d97e5d5817e2de34
Author: Alan Denniston <alan.denniston@gmail.com>
Date:   Mon Oct 13 02:13:10 2025 -0400

    Add extensive button click debugging

    Enhanced button click debugging to diagnose why Create Profile button doesn't work:
    - Added clear separator with ===== BUTTON CLICKED =====
    - Shows button text, popup, current profile
    - Shows button state (enabled, visible, shown)
    - Special debug message for Create Profile button specifically

    This will help identify if:
    1. Button clicks are registering at all
    2. Button is in correct state
    3. Create Profile button specifically is being clicked

commit 254e318eccd8d4344e0dbdee19534bf4a303bc60
Author: Alan Denniston <alan.denniston@gmail.com>
Date:   Mon Oct 13 02:10:23 2025 -0400

    Fix dropdown label overlap and popup positioning

    Dropdown Fix:
    - Increased Y offset from -20 to -25 to prevent label overlap
    - Labels now properly clear the dropdown buttons

    Popup Positioning Fix:
    - Force popup to center of screen with ClearAllPoints/SetPoint
    - Set frame level to 1000 to ensure it's on top
    - Force scale to 1.0 and call Show() explicitly
    - Added debug message when popup is positioned

    This should resolve both the visual overlap and the invisible popup issues.

commit 09c6ea17a51270e7414bf70217318e3d8f9ea578
Author: Alan Denniston <alan.denniston@gmail.com>
Date:   Mon Oct 13 02:03:13 2025 -0400

    Add frame strata fixes and extensive popup debugging

    Frame Strata Fixes:
    - Added preferredIndex = 3 to all StaticPopup dialogs
    - Set frame strata to TOOLTIP in OnShow to ensure popups appear on top
    - Auto-focus editboxes when popups open
    - Call Raise() on dialog to bring to front
    - Hide existing popup before showing (prevents conflicts)

    Enhanced Debug Output:
    - Shows dialog frame strata
    - Shows if dialog thinks it's visible
    - Checks for conflicting StaticPopup dialogs (1-4)
    - Lists which dialogs are already shown

    This should resolve popup visibility issues and help diagnose any remaining problems.

commit 293f8e111fa82a904445f2e337812c90f1a79a20
Author: Alan Denniston <alan.denniston@gmail.com>
Date:   Mon Oct 13 01:57:48 2025 -0400

    Add extensive debug output for button clicks

    Added detailed debugging to diagnose menu button issues:
    - Prints button name and popup being triggered
    - Shows current profile
    - Verifies popup definition exists
    - Shows all available PAPA_GREET popups if not found
    - Tracks StaticPopup_Show success/failure

    This will help identify exactly where the button clicks are failing.

commit 3ba323b86626250d9460e10b47f06a37e9eaa5d8
Author: Alan Denniston <alan.denniston@gmail.com>
Date:   Mon Oct 13 01:45:45 2025 -0400

    Add debug output for popup buttons

    Added debug messages to help diagnose menu button issues:
    - Prints which popup is being shown
    - Prints error if popup definition not found
    - Will help identify if StaticPopupDialogs are properly registered

commit 72a7764364c3a8959e55daa59fa6c91f5bb6dd56
Author: Alan Denniston <alan.denniston@gmail.com>
Date:   Mon Oct 13 01:45:11 2025 -0400

    Protect Default profile and improve delete dropdown UX

    Default Profile Protection:
    - Default profile is now read-only
    - Cannot add/delete greetings, goodbyes, or emotes in Default profile
    - Shows clear error message when attempting to modify
    - Users must create a new profile to customize

    Delete Dropdown Improvements:
    - Added clear labels above each dropdown ("Delete Greeting:", etc.)
    - Dropdown now shows "Select to Delete" as button text
    - Shows "Cannot modify Default profile" when Default is selected
    - Shows "No items to delete" when list is empty
    - Automatically closes dropdown after deleting an item
    - Much more obvious what the dropdowns are for

    This ensures users don't accidentally break their Default profile
    and makes the UI much more intuitive.

commit d878390c0c3df7c1fc61e66aa5dccecffbc49dc4
Author: Alan Denniston <alan.denniston@gmail.com>
Date:   Mon Oct 13 01:39:22 2025 -0400

    Fix menu buttons not working

    Issue: Create Profile, Add Greeting/Goodbye/Emote buttons were non-functional

    Root Cause:
    - StaticPopupDialogs were defined inside ShowPapaGreetMenu function
    - With the memory leak fix (v1.1.0), the function returns early if menu exists
    - This meant popups were only defined the first time menu was created
    - On subsequent opens, buttons tried to show popups that didn't exist

    Fix:
    - Moved all StaticPopupDialogs definitions outside ShowPapaGreetMenu
    - Now defined at module level, always available
    - Removed duplicate definitions that were inside the function
    - All menu buttons now work correctly on every open

    Affected buttons:
    - Create Profile
    - Delete Profile
    - Copy Profile
    - Add Greeting
    - Add Goodbye
    - Add Greeting Emote
    - Add Goodbye Emote

    Delete dropdowns already worked (they don't use StaticPopups).