HideBattleNetFriends

tag e038e1ee067c9d91a067b6f7929fd183c52c7521 v2.3.0
Author:    Metalhearf <6446231+Metalhearf@users.noreply.github.com>
Date:    Sat Nov 7 12:56:32 2026 +0100

v2.3.0

commit ae55d9ab342f788d243ca820a22807103ece261f
Author: Metalhearf <6446231+Metalhearf@users.noreply.github.com>
Date:   Sat Nov 7 12:51:28 2026 +0100

    Release 2.3.0: classic friends window option on Forever, ClassicUI Forever support

    Handoff note for whoever applies this patch (human or agent)
    =============================================================

    What this is
    ------------
    One commit on top of v2.2.0 (the 2.2.1 patch prepared earlier was never
    applied; its changes are included here).

    - Core.lua: the FriendsList_Update post-hook is installed on Forever too,
      so the old FriendsFrame is filtered when it opens (ClassicUI Forever,
      or the new option below). filteredOut() keeps Title friends (Forever's
      in-game friends) and, where BNGetNumFriends is not replaced (Forever),
      drops Battle.net friends itself; filtering() includes hideFriends.
    - Title friends keep their character name with "BattleTags instead of
      real names" (old window rows/tooltip, Social UI cards/tooltip).
    - ns.FriendsHost() returns FriendsFrame while it is shown, else the
      Social UI.
    - Options.lua:
      - New option "Use the classic friends window" (classicWindow, Display
        group, Forever only, hidden when ClassicUI Forever is loaded, not
        part of profiles). It binds the TOGGLESOCIAL / TOGGLEFRIENDSTAB keys
        over (SetOverrideBindingClick) to a button that opens FriendsFrame;
        Blizzard's opener is never replaced (that would get the Social UI
        blocked). Rebinds on UPDATE_BINDINGS, waits for combat to end. A
        chat line says to reopen the friends list after toggling it.
      - Friends list button on FriendsFrame and on the Social UI; with
        ClassicUI Forever loaded it sits left of that addon's lock button,
        one step further left while its reset button shows (found by
        position, it is unnamed).
      - The settings window closes when the friends list it is docked to
        closes.
      - /hbnf with the friends list closed no longer opens the Social UI from
        addon code (that gets its list blocked); it only opens FriendsFrame.
    - New strings in all 11 locales; README updated (Display options, WoW
      Forever section with the option and ClassicUI Forever).
    - TOC Version 2.3.0 in all five TOCs; Interface numbers unchanged.

    Tested in game
    --------------
    - Forever: ClassicUI Forever window (filters, profiles, names, button
      next to lock and reset), the classic window option on and off, the
      settings window closing with the friends list.
    Not tested
    ----------
    - Retail and Classic after these changes (small: an extra filter pass
      that finds nothing to drop there).

    Remaining work
    --------------
    1. Apply: git am --keep-cr HideBattleNetFriends-2.3.0.patch
       If a CI "Update TOC" commit landed first and conflicts, keep the newer
       Interface numbers and Version 2.3.0.
    2. Push, then tag v2.3.0 and publish by hand.

    Draft release notes
    -------------------
    - WoW Forever: new option "Use the classic friends window" to open the
      old friends window with the friends key.
    - Works with ClassicUI Forever's old friends window: filters and profiles
      apply, Hide Battle.net friends keeps your in-game friends, and the
      HideBattleNetFriends button no longer overlaps its lock button.
    - In-game friends keep their character name with BattleTags instead of
      real names.
    - The settings window closes together with the friends list.
    - Opening the settings with the friends list closed no longer risks an
      empty friends list on Forever.