EasyDisenchant

Last Updated: Aug 25, 2018 Game Version: 8.0.1

Download

Install

88,903

Nov 5, 2016

Owner: Kruithne

EasyDisenchant

This project is open-source and maintained on GitHub here: https://github.com/Kruithne/EasyDisenchant

This add-on provides a quality-of-life interface for disenchanting items. To access the interface, simply type '/disenchant' in chat, or use the button provided on the enchanting trade skill window.

Comments

akira410
- Join Date: 3/15/2019
- Posts: 3
- Member Details
#60 akira410

View User Profile

Send Message

Posted Mar 19, 2019
Last edited by akira410: Mar 19, 2019

Rollback Post to Revision RollBack
emmetotter26467
- Join Date: 4/2/2017
- Posts: 37
- Member Details
#56 emmetotter26467

View User Profile

Send Message

Posted Mar 14, 2019
Addon broken by template changes in 8.1.5

Rollback Post to Revision RollBack
akira410
- Join Date: 3/15/2019
- Posts: 3
- Member Details
#57 akira410

View User Profile

Send Message

Posted Mar 14, 2019
In reply to emmetotter26467:

Edit EasyDisenchant.lua

change line 189 from:

type = "BUTTON"

to:

type = "ItemButton"

Change line 192 from:

inherit = "ItemButtonTemplate, SecureActionButtonTemplate",

to:

inherit = "SecureActionButtonTemplate",

Rollback Post to Revision RollBack
Yttrius37096
- Join Date: 3/18/2019
- Posts: 1
- Member Details
#58 Yttrius37096

View User Profile

Send Message

Posted Mar 17, 2019
In reply to akira410:

This worked for me. Thanks a lot. I'm curious to know how you figured this out though...

Rollback Post to Revision RollBack
rondowar
- Join Date: 10/15/2012
- Posts: 31
- Member Details
#59 rondowar

View User Profile

Send Message

Posted Mar 19, 2019
In reply to Yttrius37096:

that change was required for all addons, so Google gave a ton of results

blizzard quietly releases a list of deprecated functions, but this wasn't in there, so I'm not quite sure how the first guy figured out this change

all in all, blizzard removed so many things this patch, nearly half my addons were broken -.-

Rollback Post to Revision RollBack
akira410
- Join Date: 3/15/2019
- Posts: 3
- Member Details
#61 akira410

View User Profile

Send Message

Posted Mar 19, 2019
In reply to Yttrius37096:

I just looked up the error and saw the API had changed. I wrote up a patch and sent it to the author of this addon.

It has been accepted on github but looks like they haven't pushed out a new release for whatever reason so I came here to post the fix as well. Thankfully it was just an easy little two liner. :)

(The more detailed answer as to what changed: Addons like EasyDisenchant which show clickable items in the form of "item buttons" made use of standard button frames with some additional templating from an "item button template". In 8.1.5 the 'item button template" was removed and promoted to a first class frame type of "ItemButton". That ended up breaking a bunch of items. )

Rollback Post to Revision RollBack
nirran
- Join Date: 9/20/2005
- Posts: 186
- Member Details
#55 nirran

View User Profile

Send Message

Posted Mar 13, 2019
getting thsi erro wiht new patch :

Put your spoiler here.

Date: 2019-03-13 10:50:34
ID: 2
Error occured in: Global
Count: 2
Message: ..\AddOns\EasyDisenchant\Krutilities.lua line 171:
CreateFrame(): Couldn't find inherited node "ItemButtonTemplate"
Debug:
[C]: ?
EasyDisenchant\Krutilities.lua:171: Frame()
EasyDisenchant\EasyDisenchant.lua:224: GetItemButton()
EasyDisenchant\EasyDisenchant.lua:328: UpdateItems()
EasyDisenchant\EasyDisenchant.lua:509: OpenWindow()
EasyDisenchant\EasyDisenchant.lua:557: InvokeWindowOpen()
EasyDisenchant\EasyDisenchant.lua:525: ?()
..\FrameXML\ChatFrame.lua:4721:
..\FrameXML\ChatFrame.lua:4668
[C]: ChatEdit_ParseText()
..\FrameXML\ChatFrame.lua:4382:
..\FrameXML\ChatFrame.lua:4381
[C]: ChatEdit_SendText()
MacroTalk\MacroTalk.lua:25: MacroTalk_DoCommand()
MacroTalk\MacroTalkCommands.lua:47: ?()
..\FrameXML\ChatFrame.lua:4721:
..\FrameXML\ChatFrame.lua:4668
[C]: ChatEdit_ParseText()
..\FrameXML\ChatFrame.lua:4382:
..\FrameXML\ChatFrame.lua:4381
[C]: ChatEdit_SendText()
..\FrameXML\ChatFrame.lua:2895:
..\FrameXML\ChatFrame.lua:2888
[C]: ?
[C]: UseAction()
..\FrameXML\SecureTemplates.lua:345: handler()
..\FrameXML\SecureTemplates.lua:632:
..\FrameXML\SecureTemplates.lua:580
[C]: ?
..\FrameXML\SecureHandlers.lua:266:
..\FrameXML\SecureHandlers.lua:263
[C]: ?
..\FrameXML\SecureHandlers.lua:296:
..\FrameXML\SecureHandlers.lua:279
(tail call): ?
Locals:
(*temporary) = "BUTTON"
(*temporary) = "$parentItemButton0"
(*temporary) = EasyDisenchantFrame {
0 = <userdata>
glow = <unnamed> {
}
SpawnTexture = <function> defined @Interface\AddOns\EasyDisenchant\Krutilities.lua:233
SpawnText = <function> defined @Interface\AddOns\EasyDisenchant\Krutilities.lua:282
SpawnFrame = <function> defined @Interface\AddOns\EasyDisenchant\Krutilities.lua:152
header = <unnamed> {
}
}
(*temporary) = "ItemButtonTemplate,SecureActionButtonTemplate"

AddOns:
Swatter, v8.1.6241 (SwimmingSeadragon)
WowheadLooter, v80100
solsnoxxicstats, v1.2.3
AngryKeystones, v
ArkInventory, v30821
ArkInventoryRules, v10300
ArkInventoryRulesExample, v10000
ArkInventorySearch, v10300
AucAdvanced, v8.1.6201 (SwimmingSeadragon)
AucFilterBasic, v8.1.6228 (SwimmingSeadragon)
AucScanData, v8.1.6229 (SwimmingSeadragon)
AucStatHistogram, v8.1.6230 (SwimmingSeadragon)
AucStatiLevel, v8.1.6234 (SwimmingSeadragon)
AucStatPurchased, v8.1.6231 (SwimmingSeadragon)
AucStatSimple, v8.1.6232 (SwimmingSeadragon)
AucStatStdDev, v8.1.6233 (SwimmingSeadragon)
AucUtilFixAH, v8.1.6235 (SwimmingSeadragon)
AuctionHouseMessages, v
Bartender4, v4.8.2
BeanCounter, v8.1.6236 (SwimmingSeadragon)
bobSatchels, v1.23
Capping, vv8.1.0
DBMCore, v8.1.11
DBMDefaultSkin, v
DBMPartyBfA, v
DBMStatusBarTimers, v
DejaCharacterStats, v800r120
Details, v
DetailsEncounterDetails, v
DetailsRaidCheck, v
DetailsStreamer, v
DetailsTinyThreat, v
DetailsVanguard, v
EasyDeleteConfirm, v
EasyDisenchant, v1.1.7
Enchantrix, v8.1.6237 (SwimmingSeadragon)
ExaltedPlus, v15
expr, v1.1
FasterLoot, v2.01
FishingBuddy, v1.9.27
GTFO, v4.46.17
InFlight, v8.0.006
InFlightLoad, v8.0.006
Informant, v8.1.6246 (SwimmingSeadragon)
InProgressMissions, v8.0.24
Inspector, v3.1
InstancePortals, v21
ItemRack, v
LoomXP, v
MacroTalk, v2.3.4
MacroToolkit, vv7.3.0.2
MacroToolkitIcons, v7.2.0.0
MoreStopwatches, vv1.12
MoveAnything, v17.0.3
NameplateSCT, v1.14
Oilvl, v8.0.2
Paste, v1.4.10
Pawn, v2.2.38
PersonalLootHelper, v2.19
Postal, vv3.6.0
Prat30, vr1195
Prat30Libraries, v
Quartz, v3.4.0
Quester, v8.0.1.1
RSA, vr514-Release
RSAPriest, v
SavedInstances, v8.1.0
SayMyName, v1.0.1
SexyMap, vv8.0.8
SlideBar, v8.1.6239 (SwimmingSeadragon)
Stubby, v8.1.6240 (SwimmingSeadragon)
TinyPad, v2.1.8
Titan, v5.17.0.80100
TitanBag, v5.17.0.80100
TitanClock, v5.17.0.80100
TitanGold, v5.17.0.80100
TitanLocation, v5.17.0.80100
TitanLootType, v5.17.0.80100
TitanMail, v7.35
TitanPerformance, v5.17.0.80100
TitanPoints, v8.0.1
TitanRepair, v5.17.0.80100
TitanSocial, v8.0.1
TitanSpeed, v7.3.001
TitanVolume, v5.17.0.80100
TitanXP, v5.17.0.80100
TomTom, vv80100-1.0.1
WeakAuras, v2.11.6
WorldQuestTab, v8.1.02
ZPerl, v5.7.2
ZPerlArcaneBar, v
ZPerlCustomHighlight, v
ZPerlParty, v
ZPerlPartyPet, v
ZPerlPlayer, v
ZPerlPlayerBuffs, v
ZPerlPlayerPet, v
ZPerlRaidAdmin, v
ZPerlRaidFrames, v
ZPerlRaidHelper, v
ZPerlRaidMonitor, v
ZPerlRaidPets, v
ZPerlTarget, v
ZPerlTargetTarget, v
BlizRuntimeLib_enUS v8.1.5.80100 <none>
(ck=a8a)

Last edited by nirran: Mar 13, 2019

Rollback Post to Revision RollBack
Sunflwrgirl74
- Join Date: 10/30/2011
- Posts: 1
- Member Details
#51 Sunflwrgirl74

View User Profile

Send Message

Posted Sep 27, 2018
I like the addon, but how do you remove an item that is on the blacklist?

Rollback Post to Revision RollBack
angryhordegoy
- Join Date: 12/1/2018
- Posts: 2
- Member Details
#53 angryhordegoy

View User Profile

Send Message

Posted Dec 1, 2018
Citation de Sunflwrgirl74 >>

I like the addon, but how do you remove an item that is on the blacklist?

Yeah it's cool and all but I can't figure out how to remove items from the blacklist either... addon should come with a widget that gives acces to both addon and blacklist panels

Rollback Post to Revision RollBack
ByucknahTheRed
- Location: Idaho
- Join Date: 10/17/2011
- Posts: 19
- Member Details
#54 ByucknahTheRed

View User Profile

Send Message

Posted Dec 2, 2018
In reply to angryhordegoy:

I would love to see a more expansive options menu for this addon. I mean, its lightweight and simple in what it does but its a pain to edit blacklists and such.

I would also honestly really love to see some generalized filter options. Stuff like "Don't show items below ilvl X" or "Ignore Equipment Manager Set Items" or "Hide Non-Soulbound Items" or "Highlight Non-Soulbound items"

An options menu in Interface would be so handy with things like displaying a list of Blacklisted items that you can easily add, remove, or reset as well as various other filters and options.

Still, even without any of that, this addon is a must have for me and I am thankful that it exists haha. Makes my life so much easier XD

Rollback Post to Revision RollBack
nirran
- Join Date: 9/20/2005
- Posts: 186
- Member Details
#50 nirran

View User Profile

Send Message

Posted Sep 20, 2018
nic eadon,makes de much easier,thxn for ur wwork

Rollback Post to Revision RollBack
Grim131313
- Location: Pittsburgh
- Join Date: 9/27/2007
- Posts: 6
- Member Details
#48 Grim131313

View User Profile

Send Message

Posted Sep 10, 2018
Does not seem to be working with the current version of Bagnon

Edit: Nevermind, seems to be working after a reload of the game.

Last edited by Grim131313: Sep 10, 2018

Rollback Post to Revision RollBack
emmetotter26467
- Join Date: 4/2/2017
- Posts: 37
- Member Details
#45 emmetotter26467

View User Profile

Send Message

Posted Aug 25, 2018
I noticed that if I click on an item while another is in progress of being disenchanted, it will equip that item.

Rollback Post to Revision RollBack
ByucknahTheRed
- Location: Idaho
- Join Date: 10/17/2011
- Posts: 19
- Member Details
#43 ByucknahTheRed

View User Profile

Send Message

Posted Aug 10, 2018
Easy Disenchant does not seem to work with the addon "Adibags" is there any chance for a fix?

EDIT: Upon further inspection, even with every other addon disabled, does not seem to be working at all for me.

Last edited by ByucknahTheRed: Aug 12, 2018

Rollback Post to Revision RollBack
fostot
- Location: Seattle
- Join Date: 6/7/2008
- Posts: 67
- Member Details
#44 fostot

View User Profile

Send Message

Posted Aug 21, 2018
In reply to ByucknahTheRed:

I second this, even using the GitHub version that's updated to fix the scanning it doesn't seem to work.

Rollback Post to Revision RollBack
ByucknahTheRed
- Location: Idaho
- Join Date: 10/17/2011
- Posts: 19
- Member Details
#47 ByucknahTheRed

View User Profile

Send Message

Posted Aug 26, 2018
As of today's update its working for me again, dunno about anyone else.

Rollback Post to Revision RollBack
emmetotter26467
- Join Date: 4/2/2017
- Posts: 37
- Member Details
#41 emmetotter26467

View User Profile

Send Message

Posted Aug 4, 2018
Request for Feature Enhancement

Make the window moveable or smaller.

Rollback Post to Revision RollBack
Theroxis
- Location: Aurora
- Join Date: 8/4/2012
- Posts: 16
- Member Details
#42 Theroxis

View User Profile

Send Message

Posted Aug 9, 2018
In reply to emmetotter26467:

To build on this:

Can we get an options panel with some basic settings:

Wipe blacklist
Escape closes window (toggle this, some people won't like it)
Moveable window
Window scale

Rollback Post to Revision RollBack
Icemelt
- Location: North America
- Join Date: 10/16/2008
- Posts: 4
- Member Details
#46 Icemelt

View User Profile

Send Message

Posted Aug 26, 2018
In reply to Theroxis:

"Wipe Blacklist"

I second this!

There needs to be an actual list you can see and remove items from.

Rollback Post to Revision RollBack
BubosBamba
- Join Date: 7/21/2016
- Posts: 14
- Member Details
#49 BubosBamba

View User Profile

Send Message

Posted Sep 14, 2018
In reply to emmetotter26467:

Honestly just use Molinari. Its this, but for every profession and with a blacklist

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.