Majestic Structures

v0.0.0-beta.5 - The mineshaft has a biome

Fixed

• There would have been no mineshafts at all, and nothing would have said so. The biome tag file was named majestic_structures_mineshaft.json, and a tag's id comes from its path: that defines majestic_structures:has_structure/majestic_structures_mineshaft. The structure asks for #majestic_structures:has_structure/mineshaft, so the tag it named did not exist and the biome set resolved to nothing at all. No crash, no error — a structure that can never generate, in any world, forever. Renamed to mineshaft.json, the name every other structure in the pack uses.

Notes

• Three data-shape bugs in one file, across four releases. start_height under a key that does not exist (beta.3), spawn_overrides flattened instead of nested (beta.4), and this one. All three were found by reading, none by playing. The tag one is the nasty kind: it does not fail loudly, it just quietly produces nothing.
• The tag warning in the log was the whole clue. Not all defined tags for registry ... worldgen/biome are present in data pack: majestic_structures:has_structure/mineshaft appeared on the last run and names the file that was missing.

Not our bug, but you will hit it

• Minecraft crashes on world creation in this pack, in ModernFix. After the registry problem was out of the way, world creation died with a NullPointerException in ChunkGeneratorStructureState.generateRingPositions, right after ModernFix logs "Failed to create cache key for concentric structure placement". That path is ModernFix's stronghold cache (perf.cache_strongholds) wrapping vanilla minecraft:strongholds, the structure set that uses concentric_rings. Nothing from this mod is in the stack, and no mod in the pack registers a concentric-rings placement. Workaround: add mixin.perf.cache_strongholds=false to config/modernfix-mixins.properties before starting.

Known issues

• Still unverified in-game. The tag fix is the first change here that has been seen working — and it has not been seen at all.
• The chain is probably shorter than the 7–13 pieces quoted in 0.0.0-beta.2: the expansion radius cannot exceed 128 blocks and bury spends 12, so the 32 chunks the workshop asked for is out of reach. 116 is the ceiling.
• Overlapping other structures, and mineshafts sealed under solid rock, are both unfixable in code. Depth is the lever for the second.

Beta. If a mineshaft now turns up and looks wrong, we want the seed and where you found it. If it does not turn up at all, that is also worth reporting — it means a fourth thing is wrong.