• 0.96165191740413

    posted a message on Big problem: Localization substitution syntax and other errors

    This is even worse than I thought. I looked over another of my localization files from the commit, this one from the main addon folder (not one of the load-on-demand components that use a special namespace like "Tabs"). This line:

    [email protected](locale="deDE", format="lua_additive_table", handle-subnamespaces="none")@

    ... gives, through CurseForge's localization substitution, things like this:

     

    -- snip
    L["WILDPET"] = "Wildtier"
    L["YOURPROGRESS"] = "Dein Fortschritt"
    
    -- Tabs
    L["EVENTNOTICE_ENDED_TODAY"] = "|cffff2020Dieses Ereignis endete|r heute frühzeitig."
    L["EVENTNOTICE_ENDS_DATETIME"] = "Es endet am %1$02d.%2$02d um %3$s (Serverzeit)."
    L["EVENTNOTICE_ENDS_DAYS"] = "Es endet in|cffff2020 %s |4Tag:Tagen;|r."
    -- snip

     

    It's not supposed to include the Tabs namespace. Isn't the whole point of handle-subnamespaces="none" that it won't output anything from other namespaces contained within this, the main one? And the funny thing is, here it DOES insert sub-namespaces of Tabs as a sub-table, like I gave an example for above ("SUBZONES"). But it doesn't even get that right, sticking a comma on the end of the table, causing a syntax error:

     

    L["WATCH_TAB"] = "Suivi"
    	L["SUBZONES"] = {
    		["Argent Pavilion"] = "Pavillon d'Argent",
    		["Argent Tournament Grounds"] = "Enceinte du tournoi d'Argent",
    	},
    

     So, where it shouldn't output sub-namespaces, it does, and worse, it does so improperly which creates an error that grinds the whole addon to a halt. Where it should do it, not only does it fail to do so but it creates another addon-breaking syntax error as outlined in my first post.

    Posted in: WoW Sites Feedback
  • 0

    posted a message on Big problem: Localization substitution syntax and other errors

    I have the following lines in my localization file:

    if (locale == "deDE") then  -- German
    [email protected](locale="deDE", format="lua_additive_table", namespace="Tabs", handle-subnamespaces="subtable")@
    
    elseif (locale == "frFR") then  -- French
    [email protected](locale="frFR", format="lua_additive_table", namespace="Tabs", handle-subnamespaces="subtable")@

    Etc.

     

    I've used this same code for years without any changes and it has been fine. But now, my latest commit is outputting something like this:

     

    if (locale == "deDE") then  -- German
    L["Tabs"] = {
    	["EVENTNOTICE_ENDED_TODAY"] = "|cffff2020Dieses Ereignis endete|r heute frühzeitig."
    	["EVENTNOTICE_ENDS_DATETIME"] = "Es endet am %1$02d.%2$02d um %3$s (Serverzeit)."
    	["EVENTNOTICE_ENDS_DAYS"] = "Es endet in|cffff2020 %s |4Tag:Tagen;|r."
    	["EVENTNOTICE_ENDS_HOURS"] = "Es endet in|cffff2020 %s |4Stunde:Stunden;|r."
    	["EVENTNOTICE_ENDS_MINUTES"] = "Es endet in|cffff2020 %s |4Minute:Minuten;|r."
    
    -- snip
    
    }
    
    elseif (locale == "frFR") then  -- French
    L["Tabs"] = {
    
    -- snip

     

    Clearly, this is not going to work. Not only is there no comma separating the different elements of the table (resulting in a syntax error), but I wasn't expecting you to try to stuff it all into the "Tabs" key to begin with. The handle-subnamespaces="subtable" bit is there to handle SUB-namespaces, namespaces within Tabs, not the Tabs namespace (which is a namespace, not a SUB-namespace).

     

    I'm expecting something more like this:

     

    if (locale == "deDE") then  -- German
    L["EVENTNOTICE_ENDED_TODAY"] = "|cffff2020Dieses Ereignis endete|r heute frühzeitig."
    L["EVENTNOTICE_ENDS_DATETIME"] = "Es endet am %1$02d.%2$02d um %3$s (Serverzeit)."
    L["EVENTNOTICE_ENDS_DAYS"] = "Es endet in|cffff2020 %s |4Tag:Tagen;|r."

    ... with subnamespaces handled as part of that, maybe something like:

     

    L["SUBZONES"] = {
    	["key"] = "value",
    }

     

    This is a huge problem for me. It means I either cannot release my addon or I have to release an alpha version, manually correct the issue, and then release a new file which doesn't use your localization substitution.

    Posted in: WoW Sites Feedback
  • 0

    posted a message on Commit has duplicated previous release, has no change log

    I know this is an old thread, but I think it makes sense to post here instead of starting a new one.

     

    I just wanted you to know that there is still a problem with no changelog being provided on commits. Example: https://wow.curseforge.com/projects/overachiever/files/2434843

     

    However, it does appear that the duplicates issue has been resolved.

    Posted in: WoW Sites Feedback
  • 0

    posted a message on Commit has duplicated previous release, has no change log

    FYI, this problem is still happening.  I've taken to archiving the duplicate files so you may not immediately see it on my project, but the duplicates are definitely still being generated every time there's an alpha commit (perhaps other kinds, too) that follows a (intended, properly tagged through SVN client) release commit.

    Posted in: WoW Sites Feedback
  • 0

    posted a message on Import localization and "Needs Review" status

    It used to be that when you use the import localization feature to update the primary localization of the project (generally enUS), any changed phrases would, for all the other languages (e.g. non-enUS), get marked as needing review. This was a very handy feature since when I update the base phrase, I would expect that any translations may need to be updated as well. As is, I'm not sure how to easily flag every translation as needing a review; the method I see would be to look up that phrase for every single localization and edit each one individually, which is much too time-consuming.

    Posted in: WoW Sites Feedback
  • 0

    posted a message on Commit has duplicated previous release, has no change log

    A small update on this. It seems to only happen if the previous file was a release version. At least, it doesn't seem to duplicate the previous release version if the last file was in alpha.

    Posted in: WoW Sites Feedback
  • 0

    posted a message on Localization namespaces not being added

    I just wanted to add that the "handle-subnamespaces" directive doesn't seem to be doing its job in the case of a line like the following, either, where I use "subtable" instead of "concat" (and which also includes the "namespace" directive, though that may not be a factor) :

    [email protected](locale="deDE", format="lua_additive_table", namespace="Tabs", handle-subnamespaces="subtable")@

    That line worked fine before the migration.

    Posted in: WoW Sites Feedback
  • 0

    posted a message on Commit has duplicated previous release, has no change log

    It looks like this is partially a duplicate report. They seem to be talking about the first part of the problem in this thread. Still, the bit about changelogs isn't mentioned there and hopefully the rest is still of some use to you.

    Posted in: WoW Sites Feedback
  • 0

    posted a message on Commit has duplicated previous release, has no change log

    I just made a commit to an addon repository and found that not only did it create a new file for the new commit, but a copy of the previous release seems to have been made. See here. There is the new commit, r172-alpha, and it is followed by two files called v0.99.1, the first of which has the same creation time as r172 (and the second of which is the actual previous release). The duplicate release seems to have propagated over to Curse, as well, since I manually edit change logs for release versions and I see the unedited version (which the duplicate uses since I didn't edit it) appears on Curse instead.

     

    Also, if you click on r172-alpha, you'll see that the page says "No changelog provided." But I did provide changes when I made the commit, and even if I left that blank, it should still show recent parts of the commit log like previous alpha releases have done.

    Posted in: WoW Sites Feedback
  • 0

    posted a message on Issues - Sort by updated

    Would it be possible to sort a project's Issues by updated time instead of creation time? This could perhaps be implemented as an option instead of being the only way to do it, though I think that making it the default way to sort would be sensible.

     

    If it is to be an option and not the default, then I would request that it either remember the setting I had it on (so it sorts that way for me without me needing to click something each time to change the option) or at least put the sort mode in the URL so I can bookmark a page that will always sort as I like without needing any extra clicks.

    Posted in: WoW Sites Feedback
  • 0

    posted a message on [pkgmeta] Solved - Libraries not being bundled

    Instead of ignoring the folder in your .pkgmeta, try setting your SVN client to ignore that folder.

    Posted in: Addon Help
  • 0

    posted a message on Packager rejected file due to localization namespace issue

    Thanks for your help. There is another issue now; it might be related to previous issues here (at least indirectly) so I thought I'd keep it in this thread. Users on my project's Curse comments are reporting that Overachiever is showing as needing an update again and again, 6+ times per day, even though I have not updated it again.

     

    Some of them think it might be related to the fact that two different versions show, one of them being nolib. Funny thing is, I don't even see the nolib version in the Files section of the project. I do remember seeing a notice that the nolib file was marked as Approved, though.

    Posted in: WoW Sites Feedback
  • 0

    posted a message on Packager rejected file due to localization namespace issue

    The file still shows as "New". Do I need to make another commit?

    Posted in: WoW Sites Feedback
  • 0

    posted a message on Packager rejected file due to localization namespace issue

    I made another commit and the packager seems to have built the file fine but it has been in "New" status for several hours, so other users cannot see or download it. We'll see if this is corrected in the morning, I suppose.

    Posted in: WoW Sites Feedback
  • 0

    posted a message on Packager rejected file due to localization namespace issue

    I successfully committed a change to my CurseForge repo but soon after I received this notification:

    The status of the file r163-alpha (Overachiever - achievement tools and tweaks) has been changed to Rejected
    Non-existent localization namespace "ToC" for locale "enUS."

    I don't know what is causing this. I haven't made any changes to my localization namespaces nor to any of the special comments in my source code that refer to them since before the repo migration.

     

    There is no "ToC" namespace for this project and I'm pretty sure there never has been. Is that now required? Is it expecting me to have some sort of localization for the .toc files, for the title or notes? I don't refer to any "ToC" localization namespace in any of my files, .toc or otherwise. (The Knowledge Base doesn't seem to help in that regard, either. I don't see the old entry about Repository Keyword Substitutions, for starters, but even the old one was lacking when it came to localization; nothing about how to use it for TOC title and notes, for example.)

     

    I also noticed that while the "normal" r163 file was quickly rejected, the nolib version was sent for approval and eventually was marked as approved -- though it, like the normal version, doesn't show on the project's Files list. (The normal r163 file did briefly, and I'm guessing only for me since it's my project, but disappeared soon afterward.)

    Posted in: WoW Sites Feedback
  • To post a comment, please or register a new account.