What's new
tag cb1cfb524b06b9ee2ff23451e2f28889f374c015 v3.3.1
Author: Vebjørn Baustad <vBaustad@users.noreply.github.com>
Date: Wed Sep 2 23:43:53 2026 +0200
v3.3.1 - The ring that paid for the other one
Three fixes found in one character's high-water-mark dump.
A duplicate ring in the bags was counted as a second ring, so the good
ring on one finger offered free ranks on the other. Rings share one
bucket and it already holds the pair-aware number; the wrong figure came
from the addon's own fallback, which now counts once per item.
"(1 free via Champion)" was never free -- those ranks are free only as a
promotion, and a piece that dropped inside the band pays full price.
An enchant's quality icon made eight slots read as crafted, which
silently marked their crafted-gear advice as already done. Crafted is
read off the item now, not the tooltip.
Verified in the client before tagging.
commit 6ee35d7b655f04c68558047cca55c31b19f99cb0
Author: Vebjørn Baustad <vBaustad@users.noreply.github.com>
Date: Wed Sep 2 23:43:36 2026 +0200
Stop a duplicate ring paying for the other finger
A Hero ring at 311 on one finger and a Champion ring at 295 on the
other, and the Champion row read "Free upgrade! All remaining ranks are
free -- free to 308". The vendor charges for those ranks.
The client was not the one saying it. Rings get one redundancy bucket
between the two slots and it already holds the pair-aware number: with
those two rings worn, Finger read 295. Confirmed by walking
Enum.ItemRedundancySlot itself rather than a fixed range -- it names
nothing above Offhand, so there is no FingerSecond and no TrinketSecond,
and both rings answer to bucket 9.
The 308 came from the addon's own fallback, which runs away from the
upgrade vendor -- worn gear plus anything bound in the bags, second
highest. The bags held a second copy of the ring already worn, one rank
lower at 308, and it was counted as a piece of its own. It is the same
ring. BoundBagFloor now counts once per item.
Two more things the same character's dump turned up:
"(1 free via Champion)" was never free. Those ranks are free only as a
promotion -- take a Champion piece to 6/6 and it arrives at Hero 2/6
without a Hero crest. A piece that dropped at Hero 1/6 has no promotion
left to collect and pays Hero crests like any other. It now states the
true part, "(1 rank Champion also reaches)", and leaves the conclusion
to the row's own "Wasteful crest spend".
Crafted was read off the tooltip, which cannot answer it: the profession
quality atlas was matched anywhere in the text, and an enchant carries
one. "Enchanted: Enchant Helm - Empowered Rune of Avoidance" brings the
enchant's own quality rank with it, so an ordinary helm read as crafted.
Ten of sixteen slots came back crafted; two of them were, and the other
eight were the enchanted ones. That is not just a label -- a crafted
piece counts as the craft already done, so every enchanted slot dropped
off the list of things to make. Read off the item now, through
C_TradeSkillUI.GetItemCraftedQualityByItemInfo.
Also: /yh marks loops the client's own enum instead of a hardcoded
0..16, which is what let the range be checked at all.
Verified in the client by the user before tagging.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This mod has no additional files