Weapon Swing Timer - Sixx Fix
Continuing my improvements of the WST addon originally by LeftHandedGlove. Huge thanks to him for starting it! Description from original WST for simplicity.
WeaponSwingTimer is an addon for WoW Classic that tracks your's and your target's swing timers.
If you're a hunter, it tracks Auto Shot timing and castable shots cast time.
If you use a wand, it also tracks when your shots will go off.
Melee Bars
The melee bars track the player's and target's main-hand and off-hand swings.
It resets on abilities that would reset a swing timer, such as Warrior's Slam, and also takes parry haste into account.
Both frames can be moved around with the typical click-and-drag.
A configuration window can be brought up with /wst where more visual options are available.
Hunter / Wand Bars
The shot bars track the player's Auto Shot / Shoot timing and also track the cast time for Aimed Shot and Multi-Shot. The shot bar turns white when an Auto Shot / Shoot projectile leaves the player.
While the bar is white, the player can move and cast freely without clipping their next Auto Shot or Shoot.
When the white bar is depleted, the player should stand still while their Auto Shot or Shoot is 'casting'.
Installation
- Download the latest .zip file for your WoW version.
- Wait for the zip file to download.
- Unzip the WeaponSwingTimer folder into Interface\Addons.
- It should look like Interface\Addons\WeaponSwingTimer\WeaponSwingTimer.toc
A summary of the changes can be found below:
07/29/2020 v 5.0
- Aimed Shot and Multi-shot cast bars now properly show haste effects
- Successfully casting an ability even with aimed/multi cast bars turned off will no longer show a green overlapping bar
- "Failed" will no longer display (It was driving me nuts saying failed right after a successful cast)
- Added in extra timer to show the auto shot delay while moving. It sometimes looks funny but know that it's just showing you it is delayed and you can continue to move based on the retry timer, toggleable in the options
- haste is now applied ON NEXT SHOT rather than immediately in the bar
- Added swing timer resets upon feign death, casting true shot aura, or moving after feign death
- Fixed an issue where the swing timer would reset itself while either casting an ability or just in general randomly
- Modified the multi-shot clip bar to better reflect where you would clip an auto by casting multi-shot.
- changed default setting to not have the ugly borders
- Cast times of auto shot is now properly reflected on the small timer display inside the bar, based on haste, rather than arbitrarily using 0.6 or 0.7
10/5/2020 v 5.1
- Adjust range speed to be current ranged speed on initialize rather than arbitrary 3 (helps with wands and initial auto cast after reload)
- Added additional checks for FD status to reset swing timer properly
- Attempted pushback logic but couldn't get oncombatlogunfiltered to work
- Adjusted Aimed Shot's swing timer reset to actually set the auto cast time to show that it's always ready to start from casting aimed
- Added additional check for Shoot (mostly just for wands)
- commented out some logic that set rangespeed to 3 if it was 0 (shouldn't be needed anymore)
- Changed visual multi-shot clip bar to also adjust with haste
- Added several fixes presented by someone on the WST github for improving casting, the "succeeded", "interrupted", and "failed" display.
- Inverted anchor points for auto shot bar and cast bar, so that the cast bar always appears above the auto shot bar and the auto shot bar is not shifted.
- Added a fix for gaining haste in same batch as cast, it wouldn't update the cast time even though it would be applied to the actual cast time.
- Made minor adjustment to aimed shot cast time to be closer to actual cast time (3.05 instead of 3.0)
- Fixed wands not working properly, seems to be working now.
10/6/2020 v 5.1.1
- Fixed an issue with the cast bar overlays for success, fail, interrupt to display even when cast bars are disabled in settings.
10/6/2020 v 5.1.2
- Fixed lua error for undefined "setting" variable.
Translit down below, only for russians.
Zdarova slavyane, t.k my "osobennye" blizzard zapilili dlya nas "osobennyj" defoltnyj shrift eshchyo so vremyon pandarii (derzhu v kurse), poetomu my vidim voprosy, a ne nazvaniya spela. A sho delot'?
Otkryvaem v papke addona WeaponSwingTimer_Hunter.lua ishchem strochki s shriftami FRIZQT__.ttf zamenyaem na FRIZQT___CYR.ttf, vam ne pokazalos', nuzhno dobavit' eshchyo odno nizhnee podcherkivanie.
esli pisat' tekst na russkom, kidaet v spam, coolstorybob
What would it take to control the anchor of the bars so that they "grow up" or "grow down" or "grow from middle" (as they do now)?
a suggestion: use the wand display as a gcd display when not wanding. I fondly remember the gcd spark of quartz, I think this would be a nice addition to wst
Hiho :)
Just wanted to let you know that since the latest update i get a lua error everytime i use multishot with my hunter.
Only have Hunter bar and enemy swing timer enabled.
In reply to IF_Arakash:
Fixed in 5.1.2
Hey cheers for updating the addon, is there a way to make the target swing bar fill from the right to the left. i want my bars to meet in the middle of my screen when they finish the swing so it's like |---->|<----|
Hey man. One question. I want to do something very specific, i wonder if you could tell me where to look.
Im a developer but im not real savvy with wow addons or lua. What file and part of it, can i find where the mainhand bar refreshes (for melee)? I want to have the bar change color when the swing is below 0.5 second.
Thanks!
In reply to pete_bmw:
There is a wst_player.lua and wst_target.lua, those have the melee swing timers.
If you come up with something that works you can push it to my github and I can review and merge, I have that on my to do list actually
- "Failed" will no longer display (It was driving me nuts saying failed right after a successful cast)
I don't believe that this was a bug, it just means that you are not timing your aimed shot correctly. The aimed shot is supposed to be casted when the bar is red (just before the auto shot goes out, i tested this), in this case there was never a "Failed" message. I think this message is about timing rather than showing a successful cast of aimed shot.
In reply to Forge_User_44841302:
I re-added that and corrected some code for cast detection credit to a poster on the original wst github in my next version.
working on an update FYI. Trying to get pushback working now.
Please consider adding an option to disable the login message and an option to raise or lower the strata.
In reply to jym_:
What is "the strata"? Never heard that term before. Also I guess I can see about adding a toggle for the login message.. but why would you want it? You only see it when you first log in (or reload) :P
In reply to WatchYourSixx:
Strata is simply the level of overlap with respect to other UI addons, default or from addons. Occasionally I have boss mods or WAs that overlap The bar, and I’d like to just raise the strata of my swing timer because that to me is more important.
with the login message, you get enough of them (seems like every addon has them these days) and they push your gmotd up and away
In reply to jym_:
What would you recommend setting the Strata to? Also, weird this didn't come up in a quick google search... but there is a API command that sets this: https://wow.gamepedia.com/API_Frame_SetFrameStrata
Should have an option to turn off login message in next update :)
Tested and approved.
Thank you very much dear colleague.
Wand shot timer seems to be wrong; the bar is about 2/3rds of the way full when a wand shot goes off.
In reply to jym_:
I just noticed this as well on my warlock. I'll have to look into that... all of the ranged stuff I did was only tested with hunter. Might be a way to make it work with wands too.
In reply to WatchYourSixx:
seem to have fixed wands not working in my current test version. Will do an update soon once I figure out a weird swing reset that shouldn't happen...
In reply to WatchYourSixx:
thanks so much.