Recount Changelog

[v1.18.1] (2026-05-05) - Retail Midnight (12.0) support via C_DamageMeter

Bug Fixes

• Window color picker fixed on Classic Era and other Classic flavors. Reported by a user: "any chance of fixing the feature to change window colours?". Two bugs in one — both fixed:

  1. The picker code in colors.lua branched on WOW_RETAIL to choose between the new (Dragonflight-era) ColorPickerFrame.Content.ColorPicker API and the old OpacitySliderFrame / ColorPickerFrame.func API. But the new picker has since rolled out to every Classic flavor too — Vanilla Classic 11507/11508, Cata Classic, Wrath Classic, MoP Classic — leaving Classic clients in a half-migrated state where swatchFunc was set on Vanilla but the alpha read still went through the long-removed OpacitySliderFrame (which is nil). Replaced every WOW_RETAIL/WOW_VANILLA_CLASSIC/WOW_PANDA_CLASSIC flag check inside the picker with a runtime test for ColorPickerFrame.Content and ColorPickerFrame.Content.ColorPicker.

  2. Per-field assignment of swatchFunc / opacityFunc / cancelFunc on ColorPickerFrame followed by :Show() is silently dropped on the new picker — the OkayButton's OnClick reads from the info table the picker captured during setup, not from the frame's fields. Confirmed in-game: pressing OK on the new picker threw attempt to call field 'swatchFunc' (a nil value) from Blizzard's ColorPickerFrame.xml:79_OnClick. Refactored Colors:EditColor to use ColorPickerFrame:SetupColorPickerAndShow({r=, g=, b=, opacity=, hasOpacity=, swatchFunc=, opacityFunc=, cancelFunc=}) on the new picker (the documented Dragonflight+ pattern); the old per-field-then-Show path is preserved verbatim for any pre-Dragonflight client that still uses it. Position-relative-to-Attach moved to after Setup since the new picker re-anchors during its own setup.

  3. The first new-picker detector tested for ColorPickerFrame.Content.ColorPicker, but that field returned nil on at least Classic Era 11507/11508 even though the new-style OkayButton (which reads swatchFunc) was active — SetupColorPickerAndShow was never called and the second OK click reproduced the same error. Switched the detector to test for ColorPickerFrame.SetupColorPickerAndShow directly (the canonical 10.2.5+ method); if that method exists, the info-table contract is in force.

  4. Alpha reads in Color_Change and Opacity_Change previously reached into ColorPickerFrame.Content.ColorPicker:GetColorAlpha(). Switched to the documented top-level ColorPickerFrame:GetColorAlpha() so the same code works regardless of inner widget naming differences across Classic flavors.

  5. Color_Cancel no longer manually rewinds the picker's internal opacity slider — Colors:SetColor(Cur_Branch, Cur_Name, PreviousColor) already re-paints the registered visual elements via UpdateColor, and the picker frame is closing anyway. Removes the last ColorPickerFrame.Content.ColorPicker reference from the file.

  Also removed three now-unused project-flag locals from colors.lua (WOW_RETAIL, WOW_VANILLA_CLASSIC, WOW_PANDA_CLASSIC) and the dangling MoP-only swatchFunc = func post-Show fallback.

• No more ADDON_ACTION_FORBIDDEN Lua error at login on retail Midnight (12.0). A user reported 25x [ADDON_ACTION_FORBIDDEN] AddOn 'Recount' tried to call the protected function 'Frame:RegisterEvent()' traced to Recount.lua:1868 (the Recount.events:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED") call inside OnEnable). Root cause: in patch 12.0, Blizzard removed addon access to COMBAT_LOG_EVENT_UNFILTERED unconditionally. The call now fires ADDON_ACTION_FORBIDDEN in every context, including at login outside any combat / encounter / instance. Two prior research dead-ends ruled out before landing the real fix: (1) C_RestrictedActions.IsAddOnRestrictionActive(0..3) is not a useful gate — it reports "no restrictions" at login while the underlying call is still blocked. (2) pcall does not help — ADDON_ACTION_FORBIDDEN is dispatched asynchronously by Blizzard, not raised at the call site.

Retail Midnight scaffolding (data path NOT yet functional — tracked for v1.18.2)

• New file Tracker_Midnight.lua (loaded only on Mainline TOC, never on Classic flavors) is the intended CLEU-free data path. Subscribes to DAMAGE_METER_CURRENT_SESSION_UPDATED, DAMAGE_METER_COMBAT_SESSION_UPDATED, and DAMAGE_METER_RESET. On each session update, polls C_DamageMeter.GetCombatSessionSourceFromType(Current, metric, GUID) for every group member and would compute per-(player, datatype) deltas against a snapshot table, feeding them through the existing Recount:AddAmount(combatant, datatype, amount) so the rest of Recount (modes, fight history, bars, reports, etc.) works unchanged.
• In-game test outcome on retail Midnight (12.0.5.67314): source.totalAmount reads always come back as secret number values — not just during combat as the wiki's SecretWhenInCombat annotation suggested, but also after combat. Tainted addon code can hold a secret value but cannot do arithmetic on it ("attempt to perform arithmetic on local 'total' (a secret number value, while execution tainted by 'Recount')"). The first iteration of Tracker_Midnight.lua threw this Lua error every combat. The current iteration uses issecretvalue(total) to skip the metric and does NOT update the snapshot when the value is secret — eliminates the Lua error, but post-combat reads also come back secret in practice, so no deltas are ever applied and the Recount bars stay empty on retail Midnight.
• Net v1.18.1 effect on retail Midnight: addon loads cleanly, no Lua errors, settings / minimap / Titan Panel all work, but combat data does not populate. v1.18.2 will pursue the workaround — likely involving Skada's SecretValueHelper.lua pattern or finding a non-tainted code path the wiki documents elsewhere.
• Self-help warning kept in place: if C_DamageMeter.IsDamageMeterAvailable() returns false (in-game damage meter setting is OFF), Recount emits a yellow chat message at login telling the user to enable it under Options > Gameplay Enhancements > Damage Meter. (Won't matter until the secret-value problem is solved, but the warning is harmless and the setting is needed regardless.)

Implementation

• Recount.lua top-of-file — added local WOW_RETAIL = WOW_PROJECT_ID == WOW_PROJECT_MAINLINE (matching the convention in colors.lua) and local WOW_RETAIL_MIDNIGHT = WOW_RETAIL and ((select(4, GetBuildInfo()) or 0) >= 120000). GetBuildInfo and select cached as locals per project convention.

• Recount.lua new dispatcher Recount:RegisterCombatLogEvent — on Midnight, calls Recount:RegisterCombatLogEvent_Midnight() (defined in Tracker_Midnight.lua). On every other client, calls Recount.events:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED") exactly as before.

• Recount.lua OnEnable — line 1868 changed from Recount.events:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED") to Recount:RegisterCombatLogEvent(). The INSTANCE_ENCOUNTER_ENGAGE_UNIT registration on the next line is unchanged — that event is not subject to the CLEU restriction.

• Tracker_Midnight.lua (new file) — implements Recount:RegisterCombatLogEvent_Midnight(), the Recount:DAMAGE_METER_* event handlers, and the snapshot/diff polling. Uses synthesized COMBATLOG_OBJECT_* flags (Self/Party/Raid + Player + Friendly + ControlPlayer) when calling Recount:AddCombatant since real CLEU flags aren't available on this code path. Every C_DamageMeter call is wrapped in pcall, including the field access on the returned struct (the DamageMeterCombatSessionSource is marked SecretWhenInCombat).

• Secret-value handling — confirmed in-game on retail Midnight that source.totalAmount reads return secret number values during combat. Reading them does not throw, but arithmetic on them does ("attempt to perform arithmetic on local 'total' (a secret number value, while execution tainted by 'Recount')"). Worked around by checking issecretvalue(total) before any arithmetic and skipping the update when true. The snapshot is left alone in the secret case so the next non-secret read produces the correct delta against the last public total. Belt-and-suspenders pcall wraps the subtraction itself in case issecretvalue isn't reliable on a given build. Practical effect: bars don't tick up live during combat, but populate fully once the next post-combat session update fires.

• Recount_Mainline.toc — added Tracker_Midnight.lua immediately after Tracker.lua. The other four TOCs (Recount.toc for Classic Era, Recount_BCC.toc, Recount_Wrath.toc, Recount_Cata.toc) do NOT reference the new file, so Classic-flavor clients literally never load it. Zero risk of accidental cross-version interference.

• .luarc.json — added GetBuildInfo and C_DamageMeter to diagnostics.globals.

Behavior

• Pre-12.0 retail and all Classic flavors — no behavior change. CLEU registers immediately at OnEnable exactly as before. Tracker_Midnight.lua is not loaded.
• Midnight retail (12.0+) — login Lua error fixed; addon loads cleanly. Tracker_Midnight.lua registers the DAMAGE_METER_* events but in practice every poll returns secret values that we cannot operate on, so the Recount bars stay empty until v1.18.2 lands an actual workaround for secret values.
• No more login Lua error in any scenario, including on retail Midnight.

What's deferred to v1.18.2

• Get retail Midnight bars actually populating. The Tracker_Midnight.lua scaffolding is in place; the missing piece is a way to either (a) extract numeric values from secret-value returns, (b) call C_DamageMeter from a non-tainted execution path, or (c) display secret values directly via FontString widgets without the addon ever doing arithmetic. Likely path: study Skada's SecretValueHelper.lua (visible in zarnivoop/skada on GitHub) which is the only public reference for a working Midnight damage meter.
• Tracker modules on Midnight retail. Dispels, Interrupts, CC Breakers, Power Gains, Resurrections write to per-spell table-data structures (AddTableDataStats, AddTableDataSum) that don't have a 1:1 mapping to C_DamageMeter's combatSpells array. Will need module-specific shims once the basic data path works.
• Fight rotation alignment. Recount's fight boundaries come from PLAYER_REGEN_* (still works on Midnight), but Blizzard's session reset cadence may not match exactly. If the snapshots and Recount's CurrentFightData get out of sync at fight boundaries, follow-up tuning is required.

Files Changed

• Recount.lua — added Midnight version guard and the RegisterCombatLogEvent dispatcher; replaced the unconditional CLEU RegisterEvent call in OnEnable
• Tracker_Midnight.lua — new file, Midnight-only data collection via C_DamageMeter
• Recount_Mainline.toc — added Tracker_Midnight.lua to the load order
• colors.lua — replaced WOW_RETAIL / WOW_VANILLA_CLASSIC / WOW_PANDA_CLASSIC flag checks inside the color picker with a runtime test for the new ColorPickerFrame.Content.ColorPicker API; removed the three now-unused project-flag locals and the post-Show swatchFunc = func fallback
• .luarc.json — added GetBuildInfo, C_DamageMeter, and issecretvalue to diagnostics.globals

[v1.17.5] (2026-04-29) - Fix Bars Not Appearing on First Launch

Bug Fixes

• Main window bars now render on first launch without needing a manual mode pick. Three users reported installing Recount, entering combat, and seeing the window appear with no bars or numbers — the workaround was to right-click the title bar and pick a display mode from the dropdown. Root cause: Recount.MainWindow.GetData is the function pointer the 1-second refresh timer in GUI_Main.lua:RefreshMainWindow uses to read combat data, and it is only ever assigned inside Recount:SetMainWindowMode. That assignment normally happens during OnInitialize via the chain SetupMainWindow → LoadMainWindowData → SetMainWindowMode(MainWindowMode or 1). If any earlier call in the OnInitialize Create chain (CreateMainWindow → CreateDetailWindow → CreateGraphWindow → CreateFilterWeights → InitOrder → SetupMainWindow) threw a Lua error, SetupMainWindow never ran, GetData stayed nil, and the timer-driven refresh silently early-returned forever. The right-click trick worked because picking a mode from the dropdown invokes SetMainWindowMode directly, bypassing the broken init path.

Implementation

Two complementary additive fixes in OnInitialize and RefreshMainWindow:

• Recount.lua OnInitialize — the six-call init chain (CreateMainWindow, CreateDetailWindow, CreateGraphWindow, CreateFilterWeights, InitOrder, SetupMainWindow) is now individually wrapped in pcall via a local safeInit helper. A failure in any one step no longer prevents the others from running, so SetupMainWindow always gets a chance to bind GetData. Failures emit a yellow |cffff8800Recount init warning:|r <step> failed: <error> line to DEFAULT_CHAT_FRAME so users can screenshot and report the actual failing call instead of just "no numbers."

• GUI_Main.lua RefreshMainWindow — the function-entry gate if not MainWindow.GetData or not MainWindow:IsShown() then return end was split. The visibility check still early-returns. The GetData check now self-heals: if GetData is nil but Recount.MainWindowData has been populated, RefreshMainWindow calls Recount:SetMainWindowMode(Recount.db.profile.MainWindowMode or 1) to bind it before continuing. Worst case for the regression scenario: bars appear ~1 second later than they would on a healthy init (next timer tick instead of immediately). Healthy installs see no behaviour change.

Files Changed

• Recount.lua — OnInitialize Create chain wrapped in pcall via local safeInit helper
• GUI_Main.lua — RefreshMainWindow now self-heals when GetData is nil but MainWindowData is loaded

[v1.17.2] (2026-04-15) - Compare Graph Window

New Features

• Compare Graph window — A new multi-series time-series graph window accessible from the main toolbar. Add any number of player + metric combinations as overlaid lines and compare them side by side. Supports all 14 tracked metrics: Damage Done, DPS, Friendly Fire, Damage Taken, Healing Done, Absorbs, Healing Taken, Overhealing, Deaths, DOT Uptime, HOT Uptime, Activity, Threat (TPS), and Threat (Total).

• Fight Filter dropdown — Restrict the compare graph to a single recorded combat encounter using the Fight dropdown. Selecting a fight clamps the X axis to that window; "All Fights" shows the full session timeline.

• Per Fight mode — A "Per Fight" checkbox renders each recorded fight as a continuous sawtooth line on a shared session timeline. Each fight rises from 0 as the metric accumulates then snaps back to 0 at fight end, with flat-zero gaps between pulls. Useful for comparing output across an entire raid session.

• Crosshair cursor with live tooltip — Hovering over the compare graph draws a vertical hairline at the cursor and shows a ANCHOR_CURSOR tooltip with the interpolated value of every active series at that X position. Values are linearly interpolated between 1-second samples and formatted as raw, k, or m depending on magnitude. The X header shows elapsed seconds since the fight/session start.

• Normalize checkbox — Scales each series independently to 0–100% so metrics with vastly different magnitudes (e.g. 640k threat vs 11k damage) can be visually compared on the same axis.

• Integrate checkbox — Converts per-second rate data (DPS, TPS) into cumulative totals over time. Metrics that are inherently cumulative (Damage Done, Healing Done, Threat Total, etc.) integrate automatically regardless of this checkbox.

Improvements

• Threat time-series units corrected — TimeData["Threat"] now stores raw threat/s (matching TimeData["Damage"] units) instead of k-threat/s. After integration, Threat (Total) now correctly reaches the same magnitude shown on the bar chart (e.g. 614,000). Requires one fresh fight after updating; existing saved data will be on the old scale.

• Compare graph dropdown fix — UIDropDownMenu_Initialize was being called inside the Fight and Metric dropdown OnEnter handlers, causing dropdown lists to close as soon as the cursor moved toward them. Removed the re-initialize call from OnEnter; init functions already read live data on every open.

• Compare graph tooltip anchor — All three Compare window dropdowns (Player, Metric, Fight) changed from ANCHOR_LEFT to ANCHOR_TOPRIGHT so the hover tooltip no longer overlaps the dropdown list that opens to the left.

Files Changed

• GUI_CompareGraph.lua — New file; full Compare Graph window implementation
• TrackerModules/TrackerModule_Threat.lua — TPS units corrected to raw threat/s
• GUI_Main.lua — Compare button added to main window toolbar

[v1.17.1] (2026-03-31) - Minimap Button Toggle Option

New Features

• Minimap button toggle in settings — A checkbox has been added to the Recount settings panel (Options > Addons > Recount) to show or hide the minimap button. The checkbox calls Recount:ToggleMinimapButton(v) and the state is persisted in db.profile.minimapButton.hide so it survives reloads and is character-agnostic.

Files Changed

• Recount.lua — toggle entry added to consoleOptions.args for the minimap button visibility checkbox

[v1.17.0] (2026-03-30) - Minimap Button & Titan Panel Integration

New Features

• Minimap button (LibDBIcon-1.0) — A persistent minimap button is now registered via LibDataBroker-1.1 and LibDBIcon-1.0. Left-click toggles the main Recount window; Shift+Left-click toggles the configuration window; Right-click opens the WoW addon settings panel. Cross-version compatible: uses Settings.OpenToCategory on Interface 11508+ and falls back to InterfaceOptionsFrame_OpenToCategory on older clients. Button position and visibility are persisted per-profile in AceDB.

• Titan Panel integration (LibDataBroker data source) — A data source LDB object is registered under the name Recount_Stats. Any LDB display addon (Titan Panel, Bazooka, DockingStation, etc.) picks this up automatically. The plugin shows a live per-player stat (DPS: 842) updated every 1 second via C_Timer.NewTicker. Right-clicking opens a native UIDropDownMenu to switch between six display stats (DPS, Damage Done, HPS, Healing Done, Damage Taken, Deaths) and three datasets (Overall, Last Fight, Current Fight). Hovering shows a full tooltip with all six stats at once. The selected stat is persisted in Recount.db.profile.titanPanel.stat.

Files Changed

• GUI_Minimap.lua — New file; LibDataBroker launcher + LibDBIcon-1.0 minimap button
• GUI_TitanPanel.lua — New file; LibDataBroker data source for Titan Panel / LDB displays
• libs/LibDataBroker-1.1/LibDataBroker-1.1.lua — New bundled library
• libs/LibDBIcon-1.0/LibDBIcon-1.0.lua — New bundled library
• Recount.toc (and all 4 flavor TOCs) — Added new lib scripts and GUI files
• Recount.lua — InitMinimapButton() and InitTitanPanel() called from OnInitialize()

[v1.16.0] (2026-03-30) - CurseForge Publishing, Multi-Flavor TOCs & Code Quality

New Features

• CurseForge project integration — Added ## X-Curse-Project-ID: 1499579 to all TOC files and curseforge-project-id: 1499579 to .pkgmeta. Version field now uses the Recount-v1.18.1 packager token so releases are automatically versioned on CurseForge upload. Interface version updated to 11508 (Season of Discovery / Classic Era).

• Multi-flavor TOC support — Added separate TOC files for each WoW client flavor following the standard BigWigs Packager / CurseForge naming convention:

  • Recount_BCC.toc — Burning Crusade Classic (Interface 20505)
  • Recount_Wrath.toc — Wrath of the Lich King Classic (Interface 30403)
  • Recount_Cata.toc — Cataclysm Classic (Interface 40400)
  • Recount_Mainline.toc — Retail / The War Within (Interface 110207, 120001, 120000)

• CurseForge addon description — Created docs/Curseforge_Description.html with a full formatted addon description for the CurseForge project page, covering all display modes, tracker modules, features, slash commands, and credits.

Improvements

• Ace3 externalized — Removed bundled Ace3 library source files from the repository. Libraries are now declared as externals in .pkgmeta and fetched by the CurseForge packager at release time, keeping the repository lean and libraries up to date.

• VersionCheck-1.0 integrated — Added VersionCheck-1.0 as a dependency in Classic Era / BCC / Wrath / Cata TOC files for out-of-date addon notification. Omitted from the Mainline TOC where it is not applicable.

Bug Fixes

• table.getn() and table.maxn() deprecated calls removed — Replaced all occurrences with the # length operator across GUI_Config.lua, GUI_Detail.lua, GUI_Graph.lua, and GUI_Main.lua. These calls produce errors in modern Lua 5.1 environments and generate lint warnings.

• GUI_Graph.lua nil guard — Added Filtered and Filtered[1] and guard before #Filtered[1] access to prevent nil indexing when FilterDataByTime or DataCopy returns nil. Also applied or 0 fallback to Filtered[1][#Filtered[1]] and Filtered[1][1] arithmetic to prevent nil subtraction errors.

• GUI_Detail.lua row type mismatch — Changed Row = ... or 0 to Row = ... or {} so the LSP correctly infers Row as a table, preventing false type errors when fields like Row.Data are accessed.

• zonefilters.lua scenario type handling — Refactored C_Scenario.IsInScenario() assignment to use a separate scenarioType variable with or "none" fallback before assigning to instanceType, resolving a type-mismatch lint error. Added ---@diagnostic disable-next-line: deprecated suppression for the GetZonePVPInfo call which has no non-deprecated replacement in Classic Era.

• Tracker.lua duplicate table keys — Commented out duplicate spell ID entries [1463], [6229], and [31000] in the shield absorb duration table. Duplicate keys silently overwrite earlier values in Lua and generate lint warnings.

• TrackerModules/TrackerModule_CCBreakers.lua argument count mismatch — Added extraSpellId parameter to the AddCCBreaker function signature to match the 8-argument call site (previously declared with only 7 parameters).

Internal

• Lua Language Server configuration (.luarc.json) — Added 40+ WoW API globals to suppress false "undefined global" warnings, including all COMBATLOG_OBJECT_* filter constants, CombatLogGetCurrentEventInfo, GetSpellInfo, BNGetFriendInfo, BNSendWhisper, LE_PARTY_CATEGORY_INSTANCE, InterfaceOptionsFrame, ColorPickerFrame, C_Scenario, RecountDeathTrack, RecountTempTooltip, and WoW project version constants. Added "duplicate-set-field" to diagnostics.disable.

• markdownlint .pkgmeta suppression — Added **/.pkgmeta to both .markdownlintignore and .vscode/settings.json markdownlint.ignore to prevent YAML comment lines (# comment) from triggering false markdown heading warnings.