Hi, great addon here. Nice work! I have one small code change suggestion below. This is not nearly as complex as the request as Rubz_911 has below but I think would make the UI experience better. Once you have made the announcement and starting fighting the Addon UI is in the way so how about hiding the frame after the button is clicked. Thanks!
Module RareFrame.lua
--* Show frame by default frameButton:SetScript("OnClick", function() Addon:AnnounceRare(); frame:Hide(); end) frame:Hide();
Are the companion files for the rest of the BfA zones labeled differently? All I could find were the Nazjatar and Mechagon. Many thanks to anyone who knows.
Mechagon and Nazjatar are the only two supported modules as of right now. I personally didn't see the point of adding support for the regular zones as the rares there are relatively meaningless.
Thanks for the reply. I'm not aware of what it takes to create modules, but I thought I might try to use them for achievements I missed. I stopped playing BfA after I got about six of my alts up to 120, but after that it was too exhausting. Now that I have flying I'm going back through all the things I didn't get done and trying to catch up where I can.
Thanks for the wonderful program! Being able to see the percentages on the MOBs allows me to figure out if it's worth it trying to fly over before something dies. Especially before I got my flying. =)
Hi, I wanted to report that the "Enable on death announcements" is not working while CHECKED. I have killed 6 rares so far in Mechagon and it hasn't announced one death.
I would also like to make a recommendation: With the new pop-up button, can we make it disappear if I or someone else announces that rare, I don't know much about coding/programming but I remember this addon had its own feature where it told you if the rare was previously announce preventing it from announcing again, so maybe it can work off that so the Pop-up button doesn't show up.
Thank you for hearing me out, I love your addon for helping out the community even though others are ungrateful and calling it spam. I look forward to seeing your work.
The Death announcements have been removed in 8.2.5 as a result from the removed api functionality, the checkbox is however a leftover oversight on my behalf, I'll make sure to remove it in the next version.
As for the automatically hiding frame; I've been thinking about how to implement this functionality however because the addon needed to be refactored quite drastically and quickly I did not manage to squeeze that functionality in. I'll have a look at it though.
Yup. I know your a little gun shy about general chat because you got trolled. But, if it's manual now, give us manual control of it. On rares like Soundless, I usually type out the percentage in general chat as he's dying... but should be able just to smash that button again.
Another addon allowed that from the beginning, and many of us reported it as spam (as those people were spamming % for every rare, not just soundless/rustfeather) because their addon allowed them to manually smash the button over and over again, which is probably what led to blizzard breaking the addons -- too much spam.
Rollback Post to RevisionRollback
To post a comment, please login or register a new account.
Hi, great addon here. Nice work! I have one small code change suggestion below. This is not nearly as complex as the request as Rubz_911 has below but I think would make the UI experience better. Once you have made the announcement and starting fighting the Addon UI is in the way so how about hiding the frame after the button is clicked. Thanks!
Module RareFrame.lua
--* Show frame by default
frameButton:SetScript("OnClick", function()
Addon:AnnounceRare();
frame:Hide();
end)
frame:Hide();
Zim
Did they disable the ability to have automated announcements?
In reply to WhyDaRumGone:
Yes, unfortunately blizzard broke this functionality in 8.2.5.
Are the companion files for the rest of the BfA zones labeled differently? All I could find were the Nazjatar and Mechagon. Many thanks to anyone who knows.
In reply to CassieBanks:
Mechagon and Nazjatar are the only two supported modules as of right now. I personally didn't see the point of adding support for the regular zones as the rares there are relatively meaningless.
In reply to pffScrub:
Thanks for the reply. I'm not aware of what it takes to create modules, but I thought I might try to use them for achievements I missed. I stopped playing BfA after I got about six of my alts up to 120, but after that it was too exhausting. Now that I have flying I'm going back through all the things I didn't get done and trying to catch up where I can.
Thanks for the wonderful program! Being able to see the percentages on the MOBs allows me to figure out if it's worth it trying to fly over before something dies. Especially before I got my flying. =)
Hi, I wanted to report that the "Enable on death announcements" is not working while CHECKED. I have killed 6 rares so far in Mechagon and it hasn't announced one death.
I would also like to make a recommendation: With the new pop-up button, can we make it disappear if I or someone else announces that rare, I don't know much about coding/programming but I remember this addon had its own feature where it told you if the rare was previously announce preventing it from announcing again, so maybe it can work off that so the Pop-up button doesn't show up.
Thank you for hearing me out, I love your addon for helping out the community even though others are ungrateful and calling it spam. I look forward to seeing your work.
In reply to Rubz_911:
Hi Rubz,
The Death announcements have been removed in 8.2.5 as a result from the removed api functionality, the checkbox is however a leftover oversight on my behalf, I'll make sure to remove it in the next version.
As for the automatically hiding frame; I've been thinking about how to implement this functionality however because the addon needed to be refactored quite drastically and quickly I did not manage to squeeze that functionality in. I'll have a look at it though.
Now that we have a button to click, why not let us click it to show progress too?
Sparkqueen P'Emp 100.00% ~(82.1, 22.96)
Sparkqueen P'Emp 79.00% ~(82.1, 22.96)
Sparkqueen P'Emp 52.00% ~(82.1, 22.96)
Sparkqueen P'Emp 10.00% ~(82.1, 22.96)
In reply to kirbywankanobie:
You mean repeatedly send multiple messages to general chat in quick succession of one another?
In reply to pffScrub:
Yup. I know your a little gun shy about general chat because you got trolled. But, if it's manual now, give us manual control of it. On rares like Soundless, I usually type out the percentage in general chat as he's dying... but should be able just to smash that button again.
In reply to kirbywankanobie:
Another addon allowed that from the beginning, and many of us reported it as spam (as those people were spamming % for every rare, not just soundless/rustfeather) because their addon allowed them to manually smash the button over and over again, which is probably what led to blizzard breaking the addons -- too much spam.