MissingTradeSkillsList

I can't manage to remove the part where the addon keep resetting to default the search parameters (vendor/quests/trainer etc etc...)
Does anyone have an idea to do that?

The file should be still filter_frame.lua file located in World of Warcraft\_classic_era_\Interface\AddOns\MissingTradeSkillsList_TBC\ui\common

Quote from Face__ >>

In reply to Zereges:

 is there any way to remove the TBC items permanently for Season of Mastery servers? I can't figure out how to do it. I've tried changing all the expansion = 2 tags to expansion 3, but the addon still manages to find and display them.

Quote from Zereges >>

In reply to Face__:

 You can do that from UI by deselecting Burning Crusade, I would say. If you want to do it in code, I would probably try changing IsSkillAvailableInPhase in skill.lua and check that skill.expansion == 1 as a "hack". TBH I have little idea about how the addon works mostly :D

 
That same issue plagued me for so long, so now I decided to look into it and found a fix (use some program like notepad++ btw).
Open the filter_frame.lua file located in World of Warcraft\_classic_era_\Interface\AddOns\MissingTradeSkillsList_TBC\ui\common and replace line n°328:
table.insert(self.drop_down_lists.expansion, new_phase)

with this: (so just add 2 hypens in front of it)

-- table.insert(self.drop_down_lists.expansion, new_phase)

All TBC filters are finally gone ;)

Should this mod really be dead? :(

Author does not answer, other modders which fixed aspects of the mod don't answer or don't share their fixes... a pitty.

Plz update this addon <3

25x [ADDON_ACTION_FORBIDDEN] AddOn 'MissingTradeSkillsList_TBC' tried to call the protected function 'GuildControlSetRank()'.
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: in function `GuildControlSetRank'
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:2756: in function `GuildControlPopupFrameDropDownButton_ClickedRank'
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:2508: in function `GuildControlPopupFrame_Initialize'
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:966: in function `FriendsFrame_OnEvent'
[string "*:OnEvent"]:1: in function <[string "*:OnEvent"]:1>

Currently 2 major issues exist with the addon.

First is the TBC data was never fixed to be correct because of author's lack of time/motivation. There are many recipes with faulty data, leading to addon showing you haven't learned it even though you have, wrong phase for recipe, wrong source for recipe, etc. These are simple to fix, problem is gathering data about wrong recipes. But if anyone is interested to maintain the addon these can be fixed in couple seconds whenever someone from the community reports wrong data.

Second issue is the addon tainting dropdown menus. Easily reproduceable, just have this addon running and spam open/close the guild frame maybe 10-20 times, and you will hit an error. Fortunately, I managed to fix this issue simply by making the addon implement https://www.wowace.com/projects/libuidropdownmenu library. If anyone is interested in maintaining the addon I would recommend implementing this library.

In reply to Paaht:

 I'm not a developer... would you mind exchanging your fix with others or show in an example how you did it exactly? Would be great! ;-)

Ok seems like addon is broken. I shows that i havent learned any recipe, while i have only a couple left to collect... Filters works lameand not able to sort out learnd or unlearned recipes, seems like it is just broken.

Please update.

In reply to amour1398:

 Sadly, the author doesn't seem to be developing this addon anymore. I provided some fixes, but they won't appear here. You can download updated version from my fork (https://github.com/Zereges/MissingTradeSkillsList_TBC). If that doesn't work and you provide enough details where is the problem, I can try to fix the addon.

In reply to Zereges:

 is there any way to remove the TBC items permanently for Season of Mastery servers? I can't figure out how to do it. I've tried changing all the expansion = 2 tags to expansion 3, but the addon still manages to find and display them.

In reply to Face__:

 You can do that from UI by deselecting Burning Crusade, I would say. If you want to do it in code, I would probably try changing IsSkillAvailableInPhase in skill.lua and check that skill.expansion == 1 as a "hack". TBH I have little idea about how the addon works mostly :D

In reply to Zereges:

Date: 2022-05-08 22:55:54
ID: 1
Error occured in: AddOn: MissingTradeSkillsList_TBC
Count: 1
Message: Error: AddOn MissingTradeSkillsList_TBC attempted to call a forbidden function (GuildControlSetRank()) from a tainted execution path.
Debug:
[string "=[C]"]: GuildControlSetRank()
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:2779: GuildControlPopupFrameDropDownButton_ClickedRank()
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:2531: GuildControlPopupFrame_Initialize()
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:978: FriendsFrame_OnEvent()
[string "*:OnEvent"]:1:
[string "*:OnEvent"]:1
[string "=[C]"]: SortGuildRoster()
[string "*:OnClick"]:2:
[string "*:OnClick"]:1
Locals:
None
AddOns:
Swatter, v2.5.6773 (SwimmingSeadragon)
Ace3, vRelease-r1259
Altoholic, v2.5.007
AtlasLootClassic, vv2.4.2-bcc
AtlasLootClassicData, vv2.4.2-bcc
AtlasLootClassicDungeonsAndRaids, vv2.4.2-bcc
Attune, v253
AucAdvanced, v2.5.6733 (SwimmingSeadragon)
AucFilterBasic, v2.5.6759 (SwimmingSeadragon)
AucScanData, v2.5.6760 (SwimmingSeadragon)
AucStatHistogram, v2.5.6761 (SwimmingSeadragon)
AucStatiLevel, v2.5.6765 (SwimmingSeadragon)
AucStatPurchased, v2.5.6762 (SwimmingSeadragon)
AucStatSimple, v2.5.6763 (SwimmingSeadragon)
AucStatStdDev, v2.5.6764 (SwimmingSeadragon)
AucUtilFixAH, v2.5.6766 (SwimmingSeadragon)
BagBrother, v
Bagnon, v9.2.0
BeanCounter, v2.5.6767 (SwimmingSeadragon)
BigWigs, vv37.1-classic
CharacterStatsTBC, v1.2.4
ClassicCastbars, vv1.4.5
ClassicLootManager, vv1.8.0
DataStore, v2.5.006
DataStoreAgenda, v2.5.006
DataStoreAuctions, v2.5.006
DataStoreCharacters, v2.5.006
DataStoreContainers, v2.5.006
DataStoreCrafts, v2.5.006
DataStoreInventory, v2.5.006
DataStoreMails, v2.5.006
DataStoreQuests, v2.5.006
DataStoreReputations, v2.5.006
DataStoreSpells, v2.5.006
DataStoreTalents, v2.5.006
DBMCore, v7661e31
DBMStatusBarTimers, v7661e31
DBMVPVEM, v81c3e41
Decursive, v2.7.8.5
Enchantrix, v2.5.6768 (SwimmingSeadragon)
EnchantrixBarker, v2.5.6769 (SwimmingSeadragon)
ExtendedCharacterStats, v2.12.0
FishingBuddy, v0.7.5.5
FollowMePls, v2.3
GatherMate2, v1.46.0-classic
GSE, v3.0.61
GSEGUI, v3.0.61
GSELDB, v3.0.61
GTFO, v4.66.6
HealBarsClassic, v
Informant, v2.5.6770 (SwimmingSeadragon)
ItemRack, v
KillTrack, vv2.30.0
LeatrixMaps, v2.5.103
LeatrixPlus, v2.5.103
LFGBulletinBoard, v2.61
MaxCam, v2.5.1
MissingTradeSkillsListTBC, v2.5.1
NovaInstanceTracker, v1.28
NovaWorldBuffs, v2.26
Pawn, v2.5.37
PortalMage, v1.8-tbc
Prat30, v3.9.1-1-g6978fc8
Prat30Libraries, v
Questie, v6.10.0
Recount, vv2.5.3c
SimpleThreatPlates, v1.6
Stubby, v2.5.6772 (SwimmingSeadragon)
TargetHealth, v1.0.6-beta
ThreatClassic2, v2.44
TitanClassic, v1.5.2.20504
TitanClassicAmmo, v1.5.2.20504
TitanClassicBag, v1.5.2.20504
TitanClassicClock, v1.5.2.20504
TitanClassicGold, v1.5.2.20504
TitanClassicLocation, v1.5.2.20504
TitanClassicLootType, v1.5.2.20504
TitanClassicPerformance, v1.5.2.20504
TitanClassicRegen, v1.5.2.20504
TitanClassicRepair, v1.5.2.20504
TitanClassicVolume, v1.5.2.20504
TitanClassicXP, v1.5.2.20504
TomTom, vv3.0.6
WeakAuras, v3.7.16
WowUp, v1.0.9
wowupdataaddon, v1.0.9
BlizRuntimeLib_enUS v2.5.4.20504 <none>
(ck=a2a)

In reply to sikaniska42:

Same problem as described here: https://www.curseforge.com/wow/addons/missing-tradeskills-list?comment=607

In reply to Zereges:

 Thanks but I dont know what to do whit that lib. Not too skilled.

Using this addon since Classic it's was the best and very helpful who like to monitor all possible options to get all receipts for his professions.

When BCC start I figure out for some issues at Blacksmith and Engineering as below:

1. At list of receipts that I still need to learn it show me already existing receipts that I have and It's confusing

2. When I use filter to remove not relevant for me like Alliance/Horde or fraction it's still show me receipts on the list

Tried to reinstall addon or remove any data without success.

Last time addon was updated since June 19 is it will be fixed in next versions or there is some way to fix it without?

Thanks in advance

In reply to khitrikov:

Sadly, the author doesn't seem to be developing this addon anymore. I provided some fixes, but they won't appear here.

just installed this addon to keep track on missing JC Designs... and found out it need some work , in the list theres alot of designs that i already know so not much help from this addon :(

My MTSL (the Classic and TBC combo version) is failing to load on Season of Mastery. Is there any way to resolve this as it's one of my favortite addons. 

Is this Addon still worked on? I would love to see a Phase 2 Update. there are still some Bugs as well as Missing Stuff

 For those looking for the version that works in Classic the one marked for Classic isn't working. But installing the TBC version into the Classic seems to work fine.  Hope this help everyone.  :)