Krowi's Achievement Filter

Added

• 12.1.0 "The Curse of Ula'tek" patch data
  • Altar of Fangs dungeon: Normal, Heroic, Mythic, Keystone Hero and Keystone Victor
  • The Venomous Abyss raid: Normal, Heroic, Mythic, boss kills, Glory, Ahead of the Curve/Cutting Edge, Mythic: Ula'tek
  • Midnight Season 2 Mythic+ (Resilient Keystones, Keystone Hero/Victor for all 8 dungeons, Explorer/Conqueror/Master/Hero/Legend) and Delve tiers 4-11
  • Midnight Season 2 PvP ladder (Combatant through Gladiator/Legend/Strategist), Battle Mender, Hero of the Alliance/Horde, Weapons of Conquest, and season mount
  • The Coiled Isle zone: exploration, Curse Surges world event, Vaults of Atal'Utek, housing decor, and Souvenir Seeker achievements
  • Family Battler of Outland and Family Battler of Cataclysm pet battle achievements
  • A Round on the House in Midnight and Tricks and Treats of Midnight holiday achievements
  • Keystone Hero/Victor entries added to older dungeons rejoining the Season 2 rotation (Ruby Life Pools, Temple of Sethraliss, Kings' Rest)
• Pop Out: right-click an achievement to open it in its own standalone, movable and resizable window
  • Ctrl-click an achievement (rebindable) to pop it out directly, alongside the existing Paste to Chat/Toggle Tracking/Watch List/Exclude modifiers (Options -> General -> Key Binding -> Modifiers)
  • Snapping: drag a popped-out window close to another one to snap it into a stack below it; moving or resizing the top of a stack moves/resizes the whole stack, while moving or resizing any other window in it breaks it back out (hold Alt while dragging to bypass snapping)
  • Window position, size, and snap relationships can optionally persist across sessions
  • Remembers the position a window was last moved to, and opens the next window there when none are currently shown (Options -> Layout -> Pop Out -> Remember Last Position)
  • Auto-fade: windows can fade to a configurable opacity (and fade speed) when not moused over
  • Close and resize buttons can be set to auto-hide until moused over
  • Configurable default window width and snap distance
  • All Pop Out settings found under Options -> Layout -> Pop Out
• Reward Preview: 3D-model preview for mount, pet and housing decor rewards
  • An extra icon appears on achievements with a previewable reward (one icon per reward, for achievements granting multiple); click it, or use the right-click menu's Preview Reward option, to open the preview
  • Rotate and zoom the 3D model; pin the window to keep it open and move it around, or leave it unpinned to show on mouseover and close automatically when you move away
  • Options -> Layout -> Reward Preview: toggle the extra icon, toggle mouseover-to-show, invert the vertical rotation drag direction, and set the default window width/height

Changed

• Support for WoW 12.1.0 PTR (dev note: the Achievements frame's header details strip — Back button, filter dropdown, search box — moved into AchievementFrame.HeaderDetails.Filters; the addon's filter button, search box, summary/achievements frames, and browsing history buttons now anchor to it, falling back to the old layout when it's absent)

Fixed

• Filter dropdown and search box no longer error on the 12.1.0 layout
• Blizzard's search box no longer reappears after closing the addon's own search box
• Achievement button extra icons no longer show a stale tooltip from a previous achievement (e.g. leftover temporarily-obtainable text on a Warband icon)
• GW2_UI: no longer errors skinning the filter dropdown's backdrop on the 12.1.0 layout
• GW2_UI: no longer errors anchoring the browsing history buttons on the 12.1.0 layout

Removed

• Achievement 62413, The Curse of Ula'tek, to be replaced by 62297

Added (99.1)

• Reward Preview: several Midnight Season 2 achievements (mounts, pets, housing decor) now have reward data

Changed (99.1)

• Pop Out: opening a new window while others are already open now stacks it onto the end of a snap chain instead of reopening it dead-center (Options -> Layout -> Pop Out -> Remember Last Position); prefers the chain most recently moved, otherwise any other currently open chain

Fixed (99.1)

• They Burn, Burn, Burn marked unobtainable
• Pop Out: a window restored to a saved position could fail to reappear (and look like it silently didn't reopen) if that position fell off-screen, e.g. after changing resolution or UI scale

Fixed (99.2)

• Further taint fix attempt: attempt to compare a secret number value (execution tainted by 'Krowi_AchievementFilter') (dev note: an embedded AceGUI-3.0 tab widget called GameTooltip:Hide() directly instead of through securecall, same class of issue as the 97.3/98.1/98.4 attempts but in a different, previously-unaudited code path — every direct GameTooltip touch in the addon and its bundled libraries has now been reviewed)

• Pop Out: a window could fail to reappear after /reload due to a stale or cyclic snap-chain link left over from dragging a window onto an already-occupied slot (dev note: displacing an existing child during a snap now also persists that child's new parent link; loading also detects and breaks any already-corrupted cyclic chains from before this fix)

• Options -> General -> Debug: a small, capped, read-only diagnostic log (on by default) that helps track down the recurring "secret number value... execution tainted by 'Krowi_AchievementFilter'" errors reported by some players (dev note: previously this needed a separate standalone debug addon installed by the affected player; now the data is collected automatically and can be copied via the new "Export Taint Diagnostics" button, or disabled entirely via the new "Enable taint diagnostics" toggle)

Fixed (99.3)

• Pop Out: a window's saved position could be lost if it was hidden for any reason other than an explicit close
• Pop Out: an achievement re-triggering ACHIEVEMENT_EARNED after already being completed (e.g. an account-wide completion resync after a game/addon update) could incorrectly auto-close and lose a window when Close on Earn was enabled
• Pop Out: opening a new window could attach to a stale chain reference if the tracked "last moved" window had since been snapped under another chain
• Pop Out: snapping a window into a chain no longer leaves the "last moved" tracking pointing at a window that just lost its root status
• Pop Out: a window's close/resize buttons could stay hidden or faded while hovering them if another frame happened to be stacked on top
• Pop Out: further diagnostics added for the rare, not-yet-reproduced report of a window's saved data disappearing between sessions (dev note: nothing conclusively identified yet; a small capped lifecycle log is now kept in the addon's saved data to help narrow down whether a future occurrence happens in memory during a session or in the file write/read step itself)

Fixed (99.4)

• Further taint fix attempts, both found via the new Taint Diagnostics data added in 99.3 (dev note: first real-world exports confirming execution tainted by 'Krowi_AchievementFilter' from actual affected players, rather than guesswork):
  • attempt to compare a secret number value in the Objective Tracker's cooldown display, after tracking/untracking an achievement (dev note: AddTrackedAchievement/RemoveTrackedAchievement called Blizzard's content tracking API directly, which synchronously refreshes the tracker; now routed through securecall)
  • attempt to compare a secret number value on GameTooltip, from the achievement tooltip criteria addon (dev note: Blizzard's tooltip post-call hook runs our callback forced-insecure; the callback's own tooltip:AddLine write is now routed through securecall so it can no longer leave tainted state behind on the tooltip)

Added (99.5)

• EllesmereUI skin compatibility for Krowi's achievement tabs, categories, achievement rows, summary frames, progress bars and scrollbars

Fixed (99.5)

• EllesmereUI: summary, objective and category-tooltip progress fills remain visible when EllesmereUI refreshes its panel artwork

Changed (99.6)

• Diagnostic build for the recurring attempt to compare a secret number value... execution tainted by 'Krowi_AchievementFilter' reports (dev note: the 99.4 fix for the achievement-criteria tooltip addon was confirmed insufficient by a follow-up Taint Diagnostics export still showing self-tainted GameTooltip fields on that build; achievement criteria are temporarily NOT shown in unit/item/spell tooltips in this build so we can confirm or rule out that code path as the source before attempting another fix — if you were affected, please report back whether the error still occurs)

Fixed (99.7)

• GW2_UI: Action[SetPoint] failed because[Cannot anchor to a region dependent on it] error on the filter button when loading the achievement frame (dev note: on newer client layouts the search box starts anchored to our filter button, so re-anchoring the filter button to the search box before it was reparented created a circular anchor; the skinning order was adjusted so the search box is reparented first)

Fixed (99.8)

• EllesmereUI: the skin now covers the event reminder pop-ups and the event side strip, and matches EllesmereUI's colors, fonts and spacing across the rest of the achievement window
• Shiny Pet Charmer is marked no longer obtainable (unobtainable after 10.2.5)
• Several Brawler's Guild Season 2 achievements are marked as reintroduced in patch 11.2.7: You Are Not The Contents Of Your Wallet, I Am Thrall's Complete Lack Of Surprise (both Legion and Battle for Azeroth versions), and Haters Gonna Hate

Fixed (99.9)

• attempt to compare local 'start' (a secret number value, while execution tainted by 'Krowi_AchievementFilter') in the Objective Tracker's spell cooldowns, and the matching GetAuraDataByIndex(): Auras cannot be accessed when secret while tainted error, both spamming while in a delve or scenario (dev note: on login, every tracked achievement was untracked and immediately retracked. That ran from our own insecure context, so Blizzard's objective tracker container was marked dirty — and its whole deferred update pass, covering all tracker modules including the scenario module, ran tainted, permanently poisoning the scenario spell frame pool for the rest of the session. The untrack/retrack loop was left over from an older approach that overrode the achievement criteria API globally; those overrides were removed long ago, so the loop no longer did anything except cause this. Also note the 99.4 securecall change for this error was ineffective: securecall stops a called function from tainting us, it cannot make Blizzard's refresh run secure)

Fixed (99.10)

• attempt to compare field 'calendarType' (a secret string value, while execution tainted by 'Krowi_AchievementFilter') on login or /reload inside a dungeon or raid (dev note: C_Calendar.GetDayEvent is flagged SecretInChatMessagingLockdown, so every field of the returned event turns secret while the player is on a communication restricted map or under encounter, Mythic+ or PvP match restrictions. Building the calendar events cache compared calendarType, and would then have done arithmetic on startTime/endTime and stored a secret title. The build now probes canaccessvalue on the first field it reads, aborts the whole 13 month sweep, restores the calendar's month cursor, and re-arms itself on the next PLAYER_ENTERING_WORLD so the cache builds normally once the player leaves the instance)