Just ran a mission with Necrolord plaguesingers that the addon predicted would be a 100% success. My team got destroyed. I think it has to do with the logic of the plaguesingers. They're tagged as ranged, but they seem to follow melee attack logic, hitting the nearest target with auto attack and using Plague song on the back row. Attached is pic of first round of attacks, plaguesinger uses plage song and auto attacks on the back row, but UI shows they would attack the bat in front row

https://imgur.com/a/uiMjGt7

Quote from omicron_prime >>

I'm assuming a lot of people using this addon are running Venture Plan along with it for it's ui improvements so I'll ask this question here in hopes that someone has an answer and/or solution.  Has anyone noticed that after the reset the display when selecting companions for missions has reverted back to the default ui where you have to scroll to see all your companions? All the other Venture Plan UI improvements seem to be in place except this one.  Anyone got any ideas what happened or how to get that portion of the UI working the way it used to? 

 This happened to me when I unlocked my 21st companion, I assume it's a problem with the window size and having too many companions.

In reply to wriststrong:

 A fix to this problem with Venture Plan has been posted on Icy Veins this morning. It involves a small tweak to one of the lua files.

Venture Plan New Renown Level/Companion Issue Fix - News - Icy Veins (icy-veins.com)

In reply to AllatarLoE:

 Thanks!!!

In reply to wriststrong:

 Bingo! Ole Skeletor broke the display lol.  The lua fix posted below fixed it right up!

I'm assuming a lot of people using this addon are running Venture Plan along with it for it's ui improvements so I'll ask this question here in hopes that someone has an answer and/or solution.  Has anyone noticed that after the reset the display when selecting companions for missions has reverted back to the default ui where you have to scroll to see all your companions? All the other Venture Plan UI improvements seem to be in place except this one.  Anyone got any ideas what happened or how to get that portion of the UI working the way it used to? 

 Getting an issue after I installed the newest version of Covenant Mission Helper:

Message: Interface\AddOns\VenturePlan\Widgets.lua:543: attempt to index local 'self' (a nil value)
Time: Tue Aug 17 23:40:15 2021
Count: 1
Stack: Interface\AddOns\VenturePlan\Widgets.lua:543: attempt to index local 'self' (a nil value)
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function `Show'
[string "@Interface\AddOns\VenturePlan\Util.lua"]:205: in function `ShowMission'
[string "@Interface\AddOns\VenturePlan\Widgets.lua"]:235: in function <Interface\AddOns\VenturePlan\Widgets.lua:234>

Locals: (*temporary) = <function> defined =[C]:-1
 = <function> defined @Interface\AddOns\Blizzard_GarrisonUI\Blizzard_AdventuresBoard.lua:59
 = <function> defined @Interface\AddOns\VenturePlan\MissionView.lua:671

As well as...

Message: Interface\AddOns\VenturePlan\Widgets.lua:543: attempt to index local 'self' (a nil value)
Time: Tue Aug 17 23:40:41 2021
Count: 3
Stack: Interface\AddOns\VenturePlan\Widgets.lua:543: attempt to index local 'self' (a nil value)

Locals: 

 Any time I try using the Mission Table when sending out units.

I get the Venture Plan is on hiatus, but the previous CMH versions didn't have this problem.

- Cant you add that you complete ALL missions at once? Kinda annoying when you have to click each mission to complete.

- Sometimes click mission and it makes lag few seconds before it popups.

Thanks!

-delete-

Posted in issues instead.

Thank you so much for the update.  I love the new option to Optimize based on average health.  That makes it so they all finish naturally healing at about the same time.  The only issue I've seen so far is that the optimize buttons are a little wide, so they don't fit inside the frame (at least not on my screen... its not the biggest).  They are still clickable and usable, so its just cosmetic.  Again, thanks for your hard work.

Rare bug that only happens my Kyrian Monk alt:  The addon works for most of the mission planning but sometimes when I pick one mission, it bugs out and does not render the planning window.  The frame will show up but no other information.  If I pick another mission, the planning windows works as expected.

90x CovenantMissionHelper\Unit.lua:50: attempt to index field '?' (a nil value)
[string "@CovenantMissionHelper\Unit.lua"]:50: in function `getAttackType'
[string "@CovenantMissionHelper\Unit.lua"]:61: in function `setSpells'
[string "@CovenantMissionHelper\Unit.lua"]:43: in function `new'
[string "@CovenantMissionHelper\Board.lua"]:69: in function `new'
[string "@CovenantMissionHelper\CovenantMissionHelper-3.2.0.lua"]:51: in function <...dOns\CovenantMissionHelper\CovenantMissionHelper.lua:49>
[string "@CovenantMissionHelper\CovenantMissionHelper-3.2.0.lua"]:60: in function `simulateFight'
[string "@CovenantMissionHelper\CovenantMissionHelper-3.2.0.lua"]:43: in function <...dOns\CovenantMissionHelper\CovenantMissionHelper.lua:35>
[string "=[C]"]: ?
[string "=[C]"]: in function `UpdateAllyPower'
[string "@Blizzard_GarrisonUI\Blizzard_CovenantMissionUI.lua"]:341: in function <...s\Blizzard_GarrisonUI\Blizzard_CovenantMissionUI.lua:292>
[string "=[C]"]: in function `ShowMission'
[string "@VenturePlan\Util.lua"]:206: in function `ShowMission'
[string "@VenturePlan\Widgets.lua"]:242: in function <VenturePlan\Widgets.lua:241>

Locals:
self = <table> {
role = 1
ID = 3522524
reflect = 0
startHealth = 560
spells = <table> {
}
untargetable = false
currentHealth = 560
name = "Anima Smuggler"
boardIndex = 6
buffs = <table> {
}
maxHealth = 560
attack = 44
}
autoCombatSpells = <table> {
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field '?' (a nil value)"
CMH = <table> {
Spell = <table> {
}
Board = <table> {
}
isDebug = false
Unit = <table> {
}
log = <function> defined @CovenantMissionHelper\CovenantMissionHelper.lua:192
TargetManager = <table> {
}
MetaBoard = <table> {
}
Buff = <table> {
}
debug_log = <function> defined @CovenantMissionHelper\CovenantMissionHelper.lua:199
DataTables = <table> {
}
}

Great addon and i believed this error is the minor part..i`m not the developer so all i can assist is to post the error as below :-

49x CovenantMissionHelper\Unit.lua:50: attempt to index field '?' (a nil value)
[string "@CovenantMissionHelper\Unit.lua"]:50: in function `getAttackType'
[string "@CovenantMissionHelper\Unit.lua"]:61: in function `setSpells'
[string "@CovenantMissionHelper\Unit.lua"]:43: in function `new'
[string "@CovenantMissionHelper\Board.lua"]:69: in function `new'
[string "@CovenantMissionHelper\CovenantMissionHelper-3.2.0.lua"]:51: in function <...dOns\CovenantMissionHelper\CovenantMissionHelper.lua:49>
[string "@CovenantMissionHelper\CovenantMissionHelper-3.2.0.lua"]:60: in function `simulateFight'
[string "@CovenantMissionHelper\CovenantMissionHelper-3.2.0.lua"]:43: in function <...dOns\CovenantMissionHelper\CovenantMissionHelper.lua:35>
[string "=[C]"]: ?
[string "=[C]"]: in function `UpdateAllyPower'
[string "@Blizzard_GarrisonUI\Blizzard_CovenantMissionUI.lua"]:341: in function <...s\Blizzard_GarrisonUI\Blizzard_CovenantMissionUI.lua:292>
[string "=[C]"]: in function `ShowMission'
[string "@VenturePlan\Util.lua"]:206: in function `ShowMission'
[string "@VenturePlan\Widgets.lua"]:242: in function <VenturePlan\Widgets.lua:241>

Locals:
self = <table> {
role = 1
ID = 3522524
reflect = 0
startHealth = 560
spells = <table> {
}
untargetable = false
currentHealth = 560
name = "Anima Smuggler"
boardIndex = 6
buffs = <table> {
}
maxHealth = 560
attack = 44
}
autoCombatSpells = <table> {
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field '?' (a nil value)"
CMH = <table> {
Spell = <table> {
}
Board = <table> {
}
isDebug = false
Unit = <table> {
}
log = <function> defined @CovenantMissionHelper\CovenantMissionHelper.lua:192
TargetManager = <table> {
}
MetaBoard = <table> {
}
Buff = <table> {
}
debug_log = <function> defined @CovenantMissionHelper\CovenantMissionHelper.lua:199
DataTables = <table> {
}
}

I diagnosed one "A Few Too Many" prediction failure.  The problem is not randomness.  The problem is that the Unruly Patrons attack different targets than the predicted ones.  I typed in a long post with numbers and more data, but the site flagged it as spam.

 If you get this error: CovenantMissionHelper\Unit.lua:50: attempt to index field '?' (a nil value)

you can try this Do-it-yourself-correction:

1. Go to the Addon-Folder of this addon and open file Unit.lua with an text editor (like notepad):

2. Look for the following part in this file (it is not far from the beginning of the file);

function Unit:getAttackType(autoCombatSpells)

local spellID = autoCombatSpells[1].autoCombatSpellID
if CMH.DataTables.UnusualAttackType[spellID] ~= nil and CMH.DataTables.UnusualAttackType[spellID][self.ID] ~= nil then

return CMH.DataTables.UnusualAttackType[spellID][self.ID]

else

return (self.role == 1 or self.role == 5) and 11 or 15

end

end

3. Replace this part with the following:

function Unit:getAttackType(autoCombatSpells)

if #autoCombatSpells > 0 then

local spellID = autoCombatSpells[1].autoCombatSpellID
if CMH.DataTables.UnusualAttackType[spellID] ~= nil and CMH.DataTables.UnusualAttackType[spellID][self.ID] ~= nil then

return CMH.DataTables.UnusualAttackType[spellID][self.ID]

end

end
return (self.role == 1 or self.role == 5) and 11 or 15

end

4. Save your changes.

I am not the developper of this addon, so this is all on your own risk and I do not know, if the calculation of some missions are changed by this change.

If you encounter other problems after you changed that part, download the original version and wait till an offical fix is released by the addon developer.

In reply to RunawayFan:

 Worked for me!  Kept bugging out on "Catch the Anima Smugglers" and this fixed it.

For you non-coder-types out there, I highly recommend that instead of Notepad, use Notepad++ if you are on Windows, and BBEdit if you are using macOS.  Both are fantastic editors for coding, and show the line numbers for you to follow.

15x CovenantMissionHelper\Unit.lua:50: attempt to index field '?' (a nil value)
[string "@CovenantMissionHelper\Unit.lua"]:50: in function `getAttackType'
[string "@CovenantMissionHelper\Unit.lua"]:61: in function `setSpells'
[string "@CovenantMissionHelper\Unit.lua"]:43: in function `new'
[string "@CovenantMissionHelper\Board.lua"]:69: in function `new'
[string "@CovenantMissionHelper\CovenantMissionHelper-3.2.0.lua"]:51: in function <...dOns\CovenantMissionHelper\CovenantMissionHelper.lua:49>
[string "@CovenantMissionHelper\CovenantMissionHelper-3.2.0.lua"]:60: in function `simulateFight'
[string "@CovenantMissionHelper\CovenantMissionHelper-3.2.0.lua"]:43: in function <...dOns\CovenantMissionHelper\CovenantMissionHelper.lua:35>
[string "=[C]"]: in function `UpdateAllyPower'
[string "@Blizzard_GarrisonUI\Blizzard_CovenantMissionUI.lua"]:341: in function `ShowMission'
[string "@Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua"]:206: in function `OnClickMission'
[string "@Blizzard_GarrisonTemplates\Blizzard_CovenantMissionTemplates.lua"]:504: in function <...risonTemplates\Blizzard_CovenantMissionTemplates.lua:499>

Locals:
self = <table> {
role = 1
ID = 3522524
reflect = 0
startHealth = 525
spells = <table> {
}
untargetable = false
currentHealth = 525
name = "Anima Smuggler"
boardIndex = 6
buffs = <table> {
}
maxHealth = 525
attack = 30
}
autoCombatSpells = <table> {
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field '?' (a nil value)"
CMH = <table> {
Spell = <table> {
}
Board = <table> {
}
isDebug = false
Unit = <table> {
}
log = <function> defined @CovenantMissionHelper\CovenantMissionHelper.lua:192
TargetManager = <table> {
}
MetaBoard = <table> {
}
Buff = <table> {
}
debug_log = <function> defined @CovenantMissionHelper\CovenantMissionHelper.lua:199
DataTables = <table> {
}
}

I'm getting the same message as @crsn87, but I only see it one when accessing one companion.  The Maldraxis one called Gunn Gorgebone.  when I add him to a party, is when the LUA error occurs, and the helper window doesn't display (well, it's empty).

Message: Interface\AddOns\CovenantMissionHelper\Unit.lua:50: attempt to index field '?' (a nil value)
Time: Tue Jul 13 10:36:00 2021
Count: 1
Stack: Interface\AddOns\CovenantMissionHelper\Unit.lua:50: attempt to index field '?' (a nil value)
[string "=[C]"]: ?
[string "@Interface\AddOns\CovenantMissionHelper\Unit.lua"]:50: in function `getAttackType'
[string "@Interface\AddOns\CovenantMissionHelper\Unit.lua"]:61: in function `setSpells'
[string "@Interface\AddOns\CovenantMissionHelper\Unit.lua"]:43: in function `new'
[string "@Interface\AddOns\CovenantMissionHelper\Board.lua"]:69: in function `new'
[string "@Interface\AddOns\CovenantMissionHelper\CovenantMissionHelper.lua"]:51: in function <...dOns\CovenantMissionHelper\CovenantMissionHelper.lua:49>
[string "@Interface\AddOns\CovenantMissionHelper\CovenantMissionHelper.lua"]:60: in function `simulateFight'
[string "@Interface\AddOns\CovenantMissionHelper\CovenantMissionHelper.lua"]:43: in function <...dOns\CovenantMissionHelper\CovenantMissionHelper.lua:35>
[string "=[C]"]: ?
[string "=[C]"]: in function `UpdateAllyPower'
[string "@Interface\AddOns\Blizzard_GarrisonUI\Blizzard_CovenantMissionUI.lua"]:341: in function <...s\Blizzard_GarrisonUI\Blizzard_CovenantMissionUI.lua:292>
[string "=[C]"]: in function `ShowMission'
[string "@Interface\AddOns\Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua"]:206: in function `OnClickMission'
[string "@Interface\AddOns\Blizzard_GarrisonTemplates\Blizzard_CovenantMissionTemplates.lua"]:504: in function <...risonTemplates\Blizzard_CovenantMissionTemplates.lua:499>

Locals:

Message: Interface\AddOns\CovenantMissionHelper\Unit.lua:50: attempt to index field '?' (a nil value)
Time: Tue Jul 13 10:30:50 2021
Count: 1
Stack: Interface\AddOns\CovenantMissionHelper\Unit.lua:50: attempt to index field '?' (a nil value)
[string "@Interface\AddOns\CovenantMissionHelper\Unit.lua"]:50: in function `getAttackType'
[string "@Interface\AddOns\CovenantMissionHelper\Unit.lua"]:61: in function `setSpells'
[string "@Interface\AddOns\CovenantMissionHelper\Unit.lua"]:43: in function `new'
[string "@Interface\AddOns\CovenantMissionHelper\Board.lua"]:69: in function `new'
[string "@Interface\AddOns\CovenantMissionHelper\CovenantMissionHelper.lua"]:51: in function <...dOns\CovenantMissionHelper\CovenantMissionHelper.lua:49>
[string "@Interface\AddOns\CovenantMissionHelper\CovenantMissionHelper.lua"]:60: in function `simulateFight'
[string "@Interface\AddOns\CovenantMissionHelper\CovenantMissionHelper.lua"]:43: in function <...dOns\CovenantMissionHelper\CovenantMissionHelper.lua:35>
[string "=[C]"]: in function `UpdateAllyPower'
[string "@Interface\AddOns\Blizzard_GarrisonUI\Blizzard_CovenantMissionUI.lua"]:341: in function `ShowMission'
[string "@Interface\AddOns\Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua"]:206: in function `OnClickMission'
[string "@Interface\AddOns\Blizzard_GarrisonTemplates\Blizzard_CovenantMissionTemplates.lua"]:504: in function <...risonTemplates\Blizzard_CovenantMissionTemplates.lua:499>

Locals: self = <table> {
role = 1
ID = 3522524
reflect = 0
startHealth = 560
spells = <table> {
}
untargetable = false
currentHealth = 560
name = "Animaschmuggler"
boardIndex = 6
buffs = <table> {
}
maxHealth = 560
attack = 44
}
autoCombatSpells = <table> {
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field '?' (a nil value)"
CMH = <table> {
Spell = <table> {
}
Board = <table> {
}
isDebug = false
Unit = <table> {
}
log = <function> defined @Interface\AddOns\CovenantMissionHelper\CovenantMissionHelper.lua:192
TargetManager = <table> {
}
MetaBoard = <table> {
}
Buff = <table> {
}
debug_log = <function> defined @Interface\AddOns\CovenantMissionHelper\CovenantMissionHelper.lua:199
DataTables = <table> {
}
}

Message: ...dOns\CovenantMissionHelper\CovenantMissionHelper.lua:126: attempt to index local 'board' (a nil value)
Time: Tue Jul 13 07:32:37 2021
Count: 1
Stack: ...dOns\CovenantMissionHelper\CovenantMissionHelper.lua:126: attempt to index local 'board' (a nil value)
[string "=[C]"]: ?
[string "@Interface\AddOns\CovenantMissionHelper\CovenantMissionHelper.lua"]:126: in function <...dOns\CovenantMissionHelper\CovenantMissionHelper.lua:119>
[string "=[C]"]: in function `ShowRewardsScreen'
[string "@Interface\AddOns\Blizzard_GarrisonUI\Blizzard_AdventuresCompleteScreen.lua"]:558: in function `AdvanceStage'
[string "@Interface\AddOns\Blizzard_GarrisonUI\Blizzard_AdventuresCompleteScreen.lua"]:9: in function <...ard_GarrisonUI\Blizzard_AdventuresCompleteScreen.lua:8>

Locals: