CombatAnalytics

tag 93053a077614dbb2d877ad01938010ab37425e1a 1.4-release
Author:    Lazar Dilov <ldilov@yahoo.com>
Date:    Sun Mar 22 00:08:47 2026 +0200

1.4 Fix warnigns

commit 6355356fe922896571fce3f5381d31019c919ed7
Author: Lazar Dilov <ldilov@yahoo.com>
Date:   Sun Mar 22 00:06:58 2026 +0200

    fix(helpers): replace tostring with pcall+concat to strip secret string taint

    tostring() on a WoW secret string propagates the taint flag and returns
    another secret string — it does NOT produce a plain Lua string.  Subsequent
    calls to string.match() on the still-secret value then throw 'attempt to
    perform string conversion on a secret string value'.

    Fix getOrCreateBucket (CombatStore): use pcall + '.. ""' concatenation which
    forces a new plain-Lua-string allocation.  If even that fails the key is
    replaced with 'unknown'.

    Fix Helpers.Trim: wrap string.match in pcall so any secret string that reaches
    this utility returns the original value rather than crashing the session.