I haven't played much with shaders personally. It seems like for Forge, Optifine is still the only way to go. Given its closed and hacky nature, it'll be a huge pain to figure out why things aren't working.

I may look into this at some point, but for now it would really help to get some more info. What versions are you running (Minecraft, Optifine, Complementary, ...)? Does it work fine with Optifine with the shaders disabled? What does it look like? Just empty? Or a specific color? What if you attach a banner? (just right-click the mirror with a banner in your main hand) Are there any errors in the logs?

If you'd like to share a screenshot, the easiest way to do so would be in the GitHub issues (click the "Issues" link above).

I finally got around to trying this out. I ran the mod in 1.19.2 with Optifine installed and Complementary Shaders version 4.6 enabled, and it seemed to work perfectly fine. I have to admit, I was not expecting that to "just work", but it seems like it does.

Could you try again? It might have been fixed in either Optifine or the shaders since you last looked.

Please let me know if you manage to figure out what was causing the issue.

Ah! I haven't really been playing Minecraft lately, so I didn't realize that 1.19 is out. I played around with it for a little bit and got things mostly working. The only thing that seems actually broken is the rendering of banners, which I hope won't be too hard to fix. Expect an update within a few days.

Turns out it was simple to fix. I have a new version but the current CurseForge slowness is preventing me from publishing it, so later today.

I had been working of and on on a Fabric port, but it requires a lot of changes, and it has the additional difficulty that my other mod (The Magic Doorknob) depends on some very Forge-specific model code that I'd likely have to completely redo in Fabric.

I may continue and see how much I can get to work, but don't hold your breath. Having said that, my mods are open source, so I'd be happy to accept any contributions.

Haha, fortunately nothing reality-breaking!

The magic of these mirrors make them show only the closest player, not the world around them.

That doesn't sound like a great experience. Thanks for reporting!

I can definitely give it a shot, but I'll need to be able to reproduce it first. Could you provide a bit more information?

• What version of Minecraft are you playing? I've had to make some significant changes to the rendering code multiple times between Minecraft versions.
• Are you playing with any other mods? Anything that looks like it might have custom rendering code? You mention conduits, what mod are they from? Please mention any optimization mods or shader mods as well. Often rendering issues happen when multiple mods clash somehow, and it can be hard to figure out which combination is the problem.
• You mention it happens when you are close to it. Do you mean close enough to get a reflection? Or do you need to be closer? Do you need to look at the mirror for the issue to occur? Does it happen when you place the mirror far away from your base as well? (Away from any blocks whose rendering code might give issues)

Wow, thanks for the details!

Unfortunately this will still be very difficult for me to reproduce. If I recall correctly, Optifine was not an issue for others in 1.16.5, so I suspect it is some other mod.

A little about how the mirror works: A completed mirror will cause the game to render the mirror reflection to a texture, before the world is rendered. The mirror itself is simply rendered using this texture. There could be two places where this goes wrong for you: either the reflection rendering somehow goes wrong, or the rendering of the mirror goes wrong. It seems like for you it's the latter. I redid most of that code in 1.17 because some changes in the Minecraft code made it possible to implement it in a nicer way.

I reviewed the rendering code and found some potential issues, but nothing that I think should be impacting depth checks, which is the likely cause of seeing things through walls. I don't know what's going on with the messed up dragon head texture and the red reflection (I verified that I explicitly set the color when rendering them), but who knows, they might be related somehow. My guess is that it's just some kind of weird mod interaction and that would require a lot of work to figure out which one it is. And if it's Optifine, I can't realistically do anything because that's not open sourced. Nevertheless, I made two experimental builds that might improve things, if you're up for doing some testing.

The first one fixes some potential issues in my code, and the second one works around a potential depth check issue in some other mod's code.

The builds can be found here: 1 and 2 (just replace the Magic Mirror JAR in your mods folder) (note: these are built by the system that I use to publish official builds, so they should be completely safe)

If you're up for some testing, try them out and let me know if you see any improvements.

Also: TIL about conduits LOL

Update: I have a working 1.17 port of this mod. My other mod is still running into some Forge issues. I'd like to release them together, but if things end up taking a long time, I might release this one first.

Update: Decided to release a beta of this.

The 1.17..1 version ended up involving a rewrite of a good chunk of code (mostly positive changes though!), so please try it out and let me know if you encounter any issues.

¡Hola!

I'm sorry, my language skills are not good enough to reply in Spanish. I tried to make it so the mirror can show you as different mobs, but unfortunately the way the rendering code for entities is set up makes this difficult. I'll consider adding a few of them manually, but it will be hard to support adding, for instance, modded mobs.

Google Translate: Lo siento, mis habilidades lingüísticas no son lo suficientemente buenas para responder en español. Traté de hacerlo para que el espejo pueda mostrarte como diferentes mobs, pero desafortunadamente la forma en que se configura el código de representación para las entidades dificulta esto. Consideraré agregar algunos de ellos manualmente, pero será difícil admitir agregar, por ejemplo, mobs modificados.

Assuming this was intended as a joke, but even so...

When reporting crashes, please add details around which version you attempted to run, which other mods you were playing with and above all, a crash log. Your launcher may provide them for you, but otherwise they'll be in the "logs" directory of your Minecraft instance. Without any information about how to reproduce the crash I will not be able to help you unfortunately. I'd also request that if you report an issue, you do so on the issues page.

Finally, I suggest not being annoyed at the creator of the mod. I maintain these projects for fun, providing the results for free. Minecraft mods can be surprisingly complex, especially when there are so many different combinations of mods that may interact in unexpected ways. It is no surprise that here and there a bug will show up. Just write a proper report, I'll take a look, and we'll hopefully get it working.