Minecolonies: War 'N Taxes

Patchouli Guidebook Integration

• NEW FEATURE: War 'N Taxes Codex - Complete in-game guidebook powered by Patchouli
• Automatic Book Distribution: Players receive the codex on first join (configurable)
• 9 Content Categories:
  • Getting Started: Welcome guide and first steps
  • Tax System: How taxes work, happiness modifier, guard tower boost, claiming tax, tax rates
  • Raid System: Overview, starting raids, mechanics, rewards, militia
  • War System: Overview, declaring war, war phases, vassalization
  • Diplomacy: Peace proposals, extortion
  • PvP Arena: Duels, team battles
  • Colony Management: Abandonment, claiming colonies
  • Commands: Player and admin command references
  • Configuration: Admin-only section (config-gated)
• Interactive Commands: Clickable command links throughout the book that execute commands
• Custom Styling: Color-coded text macros for tax, raid, war, success, warning, and more
• Militia Entity Display: Entity page showing citizen militia with wooden sword equipment
• Multi-Language Support: Translations for German, Russian, French, and Spanish
• Advancements: Progress tracking for claiming tax, starting raids, and declaring war

Configuration Options:

• GivePatchouliBookOnJoin (default: true) - Give book to new players
• ShowAdminPatchouliCategory (default: false) - Show admin config section in book

SDMShop Integration Fix

• FIXED: SDMShop Currency Conversion - Fixed critical bug where SDMShop currency items were not being properly detected and converted when players claimed tax
• Root Cause: The currency item lookup was failing when SDMShop mod was present, resulting in players receiving nothing when claiming tax
• Solution: Added proper null checks and fallback handling for SDMShop integration

Updated to be compatible with latest Versions of the SDM(Shop)-Mods and backwards-compatibility

Colony Abandonment Configuration

• NEW CONFIG: EnableListAbandonedForAll - Controls who can use the /wnt listabandoned command
  • Default: false (OP-only, requires permission level 2)
  • When true: All players can view the list of abandoned colonies
• Location: Colony Auto-Abandon section of config

Configuration Improvements

• FIXED: Absurd Range Values - Replaced all Double.MAX_VALUE (1.7976931348623157E308) in config ranges with sensible maximum of 10000.0
• FIXED: Military Building Map Bug - barrackstower, archery, and combatacademy were incorrectly using BUILDING_TAXES map; now correctly use BUILDING_MAINTENANCE map
• IMPROVED: Added [WIP] markers to Tax Expansion config sections (Economy, Factions, Espionage, War Mechanics, Money Sinks) to indicate feature branches not yet merged

Critical Tax System Fixes

• FIXED: Military Buildings Using Wrong Config Map - barrackstower, archery, and combatacademy were incorrectly using BUILDING_TAXES.put() instead of BUILDING_MAINTENANCE.put() in the military maintenance section
• FIXED: Duplicate Tax Entries - Removed duplicate barracks, guardtower, and barrackstower entries from BUILDING_TAXES (military buildings should only have maintenance costs, not generate tax income)
• FIXED: Debug Command Using Wrong Identifier - The /wnt debugtax command was using getBuildingDisplayName() (e.g., "Restaurant", "Guard Tower") instead of the Registry ID (getBuildingType().getRegistryName().getPath() - e.g., "cook", "guardtower"), causing ALL buildings to show 0 tax in debug output
• IMPROVED: Debug output now shows both display name and registry ID for clarity: Restaurant [cook] (L3): +15 tax, -0 maint = +15 net

Technical Details:

• Military buildings (barracks, barrackstower, guardtower, archery, combatacademy) now correctly only have maintenance entries
• Tax-generating buildings use BUILDING_TAXES map, military buildings use BUILDING_MAINTENANCE map
• All 54 MineColonies Registry IDs verified against ModBuildings.java from Minecolonies
• CLASS_NAME_TO_SHORT_NAME mappings verified: baker→bakery, residence→home, all others→same name

Bug Fixes

• FIXED: War Declaration with Multiple Colonies - Fixed an issue where players with multiple colonies could not declare war if their "first" colony didn't meet requirements. The system now correctly checks all owned colonies for valid war capabilities.
• FIXED: Added missing prerequisite note in First Steps explaining MineColonies colony requirement
• FIXED: Advancement localization keys added for proper display in Advancements screen
• FIXED: Colony Abandonment resetting after Server restart; added .json File with Async File Reading and Saving

More Features to come!