Caravans & Convoys - Automatic Trade

Caravans & Convoys - Automatic Trade Version 1.0.6 - Minecraft 1.20.1, Forge

Two fixes, both from CurseForge reports, and both bigger than they look: long trade routes never finished properly, and escorts never fought.

FIXED: caravans completing their trade partway down the road

• Every leg of a journey carried a flat three minute clock, there as a failsafe so a wagon wedged against the scenery could never freeze a trade route for good. Three minutes at the speed the rig rolls is about 500 blocks of driving, and rather less than that once hills, water and road detours are counted.
• Worse, running that clock out counted as ARRIVING. So on any route longer than a few hundred blocks the wagon stopped wherever it happened to be, the cargo was booked in at a dock it had never reached, the payment came back, the driver had his lunch at the roadside, and the convoy turned for home. The trade "worked", which is why it read as a design choice rather than a bug.
• A leg is now timed against the journey it actually has to make: the distance to the destination, checkpoints included, at the speed the wagon really travels, with a generous multiple on top for terrain and for fights. A 3000 block delivery gets about 57 minutes instead of 3.
• Running the clock out no longer counts as an arrival. Close to the dock the caravan still settles and completes, the way it always did for a rig stopped by a fence post. Anywhere else the run is reported as failed: the partner's payment goes back to the partner's dock, the load stays in the wagon, the owner is told, and the convoy comes home. Nothing is created and nothing is lost.
• This covers Creative Docks too, which is where most people met it. A player caravan sent to a shop now drives the whole way there.

FIXED: caravan guards following the wagon instead of fighting

• Guard movement is handed to Hundred Years War's own follow behaviour, which is what lets an escort keep up over long distances. A guard that picked up a target was then left alone to fight it, but its follow order was left standing, so HYW carried on marching the soldier after the wagon while it was being hit. The escort walked to its death without ever turning round, and only began defending itself once the caravan parked at a dock and the follow order had nothing left to chase.
• A guard with a fight on its hands is now released from the follow order, once, and put back on it when the fight is over.
• The convoy also watches for hostiles itself and hands them to guards that have not noticed anything. HYW's targeting is built around a soldier holding a post, and a soldier in permanent catch up picks up very little on its own, which is how an escort could be whittled down without a swing being thrown. Only hostile mobs are ever handed over: never livestock, never your own soldiers, never anybody else flying your colours.
• A caravan under attack now brakes and stands its ground until the fight is over, which puts the whole escort, scouts included, back around the wagon instead of strung out along the road behind it. Capped at a minute, so a hostile that cannot be reached can never park a route, and time spent fighting is not charged against the journey clock.
• Shooting the driver brings the escort down on you as well, which is the one attacker a sweep for hostile mobs would never find.

Also in this release

• Rendezvous trades over long distances: whichever wagon reached the meeting point first waited a flat minute for its partner before giving up and taking its load home. Two convoys drive different ground and can easily arrive minutes apart, so the wait now grows with the length of the journey.

Existing worlds

• Nothing to reset, and no config keys, protocol or world format changes. A drop in replacement for 1.0.5: swap the jar on the server and have clients update to match.
• Caravans already on the road when you update simply carry on under the new timing.

Thanks to fluffypillows and user_gajjd1sy44ube77o for the reports of wagons turning back early, one of them measured against a 3000 block route, and to TheCrazyDonkey70 for spotting that guards were prioritising the wagon over the people attacking them. All three pointed straight at the two bugs above.