Terrastorage 1.3.0 for Minecraft 1.21.4

Finally got the time and determination to update and fix some things :D

Major Changes

Slot Handling Revamp

Note that this is about the storage button operations. NOT Quick Stack To Nearby Storages, which needs its own revamp that I've already started working on.

All storage button operations now operate directly on container menu slots rather than Container instances. Terrastorage now respects those slots' permissions, and only moves items if they're allowed to be picked up from the source slot and allowed to be placed in the target slot.

Up until now Terrastorage had something similar, but as of 1.3.0 the check is much stricter and applies to all container menus, not just modded ones.

This was necessary in order to provide better compatibility with other storage mods.

This revamp should fix compatibility issues with many storage mods, but note that it isn't perfect - my testing covered 3 mods:

• Backpacked: Appears to work well, I haven't been able to find any issues. Terrastorage now properly respects the locked slots.
• Sophisticated Storage & Backpacks: Compatibility has improved - I was still able to find an issue with sorting and one with item favoriting, but nothing that looked able to result in item duplication or item loss.
• Traveler's Backpack: Compatibility has also improved, but there are still issues that can result in item loss, or at least in a temporary disappearance, so I wouldn't recommend using Terrastorage alongside Traveler's Backpack just yet.

The issues that are still present can't be fixed by a 'better' generic approach. The solution I'm planning is a 'slot ignoring' configuration that ships with Terrastorage and is customizable by the player (via a GUI screen, for instance).

That way certain slots of backpacks from Traveler's Backpack (fluid slots, for instance) will simply be ignored by storage operations.

Storage Detection

Improved the detection mechanism Terrastorage uses to identify which container screens the storage buttons should be added to.

The new mechanism should prevent the storage buttons from being added to locked or non-functional container menu screens. For instance, before this change the storage buttons would be added to Traveler's Backpack's backpack settings screen, even though items aren't accessible inside of it.

Player Inventory Detection

Player slots are now identified by comparing directly against the player's own inventory instance rather than by an instanceof check, which mistook any storage backed by an Inventory, such as a grave holding a dead player's items, for the player's own inventory. (It was also possible to favorite items inside another player's storage lol)

Removed Expanded Storage Compatibility

Expanded Storage is kind of gone so: The dedicated Expanded Storage handling was removed. It only ever affected Quick Stack To Nearby Storages, where it was used to treat an Expanded Storage double chest as a single storage rather than as two separate ones.

Bug Fixes

• The Slot Handling Revamp solves various issues, such as the infamous item duplication bug with Traveler's Backpack (#40).
• Fixed a bug that caused the sort inventory keybind to not work on certain modded container menus, such as Traveler's Backpack's or Sophisticated Storage & Backpacks' containers.
• Fixed a crash on client startup, caused by Terrastorage creating block entities in order to decide which ones need a nametag renderer (this could crash with Traveler's Backpack). Nametag renderers are now provided while rendering instead, which also makes the storage size check accurate for storages whose inventory can be upgraded.
• [1.21.2+] Fixed probably the oldest Terrastorage bug, which caused shift-clicking the destroy item slot in the creative inventory to not properly delete regular non-favorite items (#61).
• [1.21.5+] Fixed a bug that caused block entity custom names to include quotation marks around the actual name.
• [1.21.9+] Fixed a bug that resulted in a desync of the custom name between the chest block entities making up a double chest.

Next Up

I plan on targeting these 3 goals by the next update:

1. Quick Stack To Nearby Storages handling revamp: Currently only a limited number of block entities are supported by Quick Stack To Nearby Storages, and that's a real shame considering it's probably the most useful feature brought over from Terraria.

   My goal with this revamp is to hopefully achieve compatibility with a wider range of container block entities, such as Sophisticated Storage block entities or Metal Barrel block entities.

2. Slot Blacklist Configuration: A customizable slot blacklist (either by slot index or by unique slot class name) that ships with Terrastorage and is easily extensible and customizable in game is something I really want to do. It will also finally make Terrastorage playable with Traveler's Backpack without the risk of losing items.

3. Container Blocklist Configuration: Same thing as the Slot Blacklist Configuration, but for blacklisting certain containers, either from having the storage buttons appended to their menus, or from being picked up by Quick Stack To Nearby Storages (#55).

I would also really love to work on improving the options screen, and mainly the currently lacking button customization screen, but I'm prioritizing these 3 goals above that for now.

Thanks for using Terrastorage!