flagRSP MoP

Addons
77,740 Downloads Last Updated: Dec 12, 2014 Game Version: 6.0.3

Player name conflict with NPCs

#2 By  NukeninRB

Created Mar 13, 2009 Updated Mar 16, 2009

Open
Assigned to  _ForgeUser142632
Defect
Accepted

What steps will reproduce the problem?
1. Create a player named "Squirrel" or "Nightsaber" or the like.
2. Enter RSP info for this player including first name.
3. Add the player to your FlagRSP Friendlist.
4. Find an NPC matching the name you've chosen (squirrel, etc) and observe the mouseover tooltip.

What is the expected output? What do you see instead?
expected: the NPC's name and a normal-ish tooltip
instead: the FlagRSP WotLK code prepends the NPC's name with the first name of the player with the same name, and will also show the Friendstate of the player (Friend, Known, Foe) on the NPC's tooltip.

What version of the product are you using?
1.0.7

Do you have an error log of what happened?
n/a

Please provide any additional information below.
This can be possibly addressed by adding a UnitIsPlayer check before pulling a first name in function tooltipHandler:getNameToolTipText, to prevent the stray first name from being prepended to NPC names; and removing the %flagRSPFriendlistText entry in the PlayerTooltip["npc"] array in tooltipModifier.lua.

NukeninRB   added the tags
New
Defect
  Mar 13, 2009
Mar 16, 2009

Adding NPCs to your friendlist and appending information about them is actually meant to be a feature. But I'm aware of the confusion it may provoke if the same name is used by an NPC and by a player. I recently came across Gnarl, an ancient in ashenvale, that had full flag description and title that belonged to the player named Gnarl. The way out of this is an option to mark a friendlist entry as npc. I'll put this on the todo list. NPCs carrying the same name as a player will not show any flag appendices then anymore if they are not labeled as an npc friend.

_ForgeUser142632   removed a tag
New
  Mar 16, 2009

To post a comment, please login or register a new account.