DialogKey

Addons
145,941 Downloads Last Updated: Nov 22, 2020 Game Version: 8.2.0

Gossip options not working in 8.1.5

#7 By  oiFrango

Created Mar 12, 2019 Updated Jun 9, 2019

Open

Since the patch, the "1-9 keys select conversations/quests" option does not work. I seem to still be able to press space for regular buttons, though.

Mar 14, 2019

It appears the key mappings are merely wrong, because the (hidden) gossip buttons are no longer "visible". This causes the addon to error out, as it assumes they are and uses a QuestTitleButton instead in this case (which doesn't exist in a gossip frame).

 

Example: The gossip option marked as "2" is actually GossipTitleButton3, with GossipTitleButton2 being invisible. If I press 2, it will check GossipTitleButton2:IsVisible(), which returns false, and then try QuestTitleButton2, which doesn't exist. See core.lua, line 643...

 

If pressing three instead of two actually works (it does for me), then a workaround would be to replace in line 644

 

frame = _G["QuestTitleButton"..i]

 with this

frame = _G["QuestTitleButton"..i] or _G["GossipTitleButton".. (i+1)]

 It's not a clean solution and will have unintended side effects if there's another problem affecting the gossip options, or the "next" option doesn't exist in the first place, but for 30 seconds of looking at the code it seems to be working alright... I didn't test it very much, however.

 

If there's something else I would have to do proper debugging, which I'm too lazy to do right now :P I'll edit this if I continue to face errors and decide to investigate further, but so far I haven't.

Edited Mar 14, 2019

Mar 15, 2019

Thanks Cakechart!

Edited Mar 17, 2019

Mar 15, 2019

It appears that QuestTitleButton# is actually gone in 8.1.5.  The quest buttons have been replaced with dynamic frames instead of globals.

 

I'm too lazy to figure out how these work exactly, so I just changed line 812 to the following so that I don't get errors anymore on quest frames:

if frame and frame:IsVisible() and frame:GetText() then

 

Mar 16, 2019

Very valuable plugin!
Is there any way to get it back to work?

Mar 18, 2019

okay.i'll test that later.

-------------------------------------------

It seems that the Horde is fixed. But there is still a problem with the alliance.

Edited Mar 18, 2019

Mar 22, 2019

I'm getting errors on some dialogs with the fix, it only seems to happen when it's a quest giver giving out multiple quests at the same time:

7x DialogKey\core.lua:812: attempt to index local 'frame' (a nil value)
DialogKey\core.lua:812: in function `func'
DialogKey\libs\AceTimer-3.0\AceTimer-3.0-17.lua:55: in function <DialogKey\libs\AceTimer-3.0\AceTimer-3.0.lua:48>

Mar 23, 2019

i can't live without this addon any1 can't update it?

Apr 3, 2019

So is this ever gonna get fixed or can I just assume it's another addon author too lazy to update their stuff and just uninstall it for good?

 

The lack of support and updates for a lot of addons in general these days is getting pretty pathetic honestly.

Apr 4, 2019

setsugekka_ don't be a dick the addons are free and the author(s) don't owe you anything.

Jun 7, 2019

@Sadclaps__  lol really, people use their free time to make some thing for other, and its even FREE, and you then come here and throw shit at their head?

Man what a Trump you are, and talking about pathetic yeah well you are the most pathetic person here, i bet you are one of those that think that everyone just exist for the sole purpose for making your life better, got news for you kiddo, grow up, you are not that important at all, and no one that ever made an addon owes you SHIT, no the opposite you damn ow them, if nothing then a Thx, so dont be a Trump, but thats probably to late already pff.

 

And i know you probably do not have the brain to figure this out yourself, so let me explain why many addons are getting abandoned, people QUIT the game, so why should they then fix addons for a game they left? If you would just go to some of the addons you think that lacks update, try look at the author's last login, so that one also was FREE, now you know why some addons are not updated.

Jun 9, 2019

Can we please not derail this.

 

Still looking for a solution. Cakechart's fix works most of the time but I'm still regularly running into dialogs that will just throw a Lua error instead. :(


To post a comment, please login or register a new account.