DialogKey

Addons
145,763 Downloads Last Updated: Nov 22, 2020 Game Version: 8.2.0
Download
CurseForge
Install

AddOn Blocked, Lua error after Withered Army Training

#2 By  Forge_User_07651551

Created Sep 18, 2016 Updated Oct 10, 2017

Open
Assigned to  foxthorn
New
Defect
View Forge_User_07651551's Profile
Forge_User_07651551

What steps will reproduce the problem?
After you have done the szenario: http://www.wowhead.com/quest=43943/withered-army-training
You need to klick an item on the floor to leave it. When you klick it there is an dialog if you realy want to leave when you ress the addon key to leave it says the action was blocked. Works if you press yes with mouse.

What is the expected output? What do you see instead?
2x [ADDON_ACTION_BLOCKED] AddOn 'DialogKey' hat versucht die geschützte Funktion 'UIParent:EnableMouseWheel()' aufzurufen.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `EnableMouseWheel'
DialogKey\core.lua:50: in function <DialogKey\core.lua:50>
[C]: in function `Hide'
FrameXML\UIParent.lua:2320: in function `SetUIPanel'
FrameXML\UIParent.lua:2396: in function `HideUIPanel'
FrameXML\UIParent.lua:2052: in function <FrameXML\UIParent.lua:2044>
[C]: in function `SetAttribute'
FrameXML\UIParent.lua:2846: in function `HideUIPanel'
FrameXML\QuestFrame.lua:36: in function <FrameXML\QuestFrame.lua:34>
[C]: in function `AcceptQuest'
FrameXML\QuestFrame.lua:555: in function <FrameXML\QuestFrame.lua:548>
[C]: in function `Click'
DialogKey\core.lua:525: in function `ClickButton'
DialogKey\core.lua:504: in function `ClickButtons'
DialogKey\core.lua:495: in function <DialogKey\core.lua:446>

Locals:

View Forge_User_07651551's Profile
Forge_User_07651551   added the tags
New
Defect
  Sep 18, 2016
View Cakechart's Profile
Cakechart
Oct 9, 2017

This is probably the same issue I mentioned here: https://mods.curse.com/addons/wow/dialogkey#c50

 

To fix it, you merely have to declare the "args" variable at around line 84 as local. There's another one in the "function path_to" near 521 but I doubt that one is causing errors.

View Foxthorn's Profile
Foxthorn
Oct 10, 2017

I fixed the taint issues, but it doesn't fix the action itself. I believe it's because accepting the dialog casts a spell (AcceptSpellConfirmationPrompt() ) and due to some issue on Blizzard's side that can't be triggered by an AddOn (even thought it was originally triggered by a hardware key). I'm adding in a built-in blacklist for these types of dialog so at least it'll gracefully fail with a chat box error instead of a Lua error.

 

If you know of any other dialogs that fail similarly to that, please let me know! They'll be ones that cast spells, so enchanting confirmations, teleport confirmations, etc.

To post a comment, please login or register a new account.