86 - Request: special commit messages to interact with tickets
Suggest allowing special messages in commits to interact with the ticket system.
Example:
"CurseForge-42: close" would close the ticket.
It may be a good thing to make the trigger statements strict. It's (arguably) better to force the developer to be nice and explicit about closing tickets rather than trying to be automatic. I'm thinking of this as an aid rather than an automatic system.
| User | When | Change |
|---|---|---|
| Torhal | Fri, 03 Jun 2011 16:56:02 | Changed assigned to from None to prencher |
| Ackis | Tue, 01 Feb 2011 18:00:30 | Changed assigned to from ckknight to None |
| Ackis | Tue, 21 Apr 2009 15:05:30 | Changed component from None to Component #18 |
| Ackis | Tue, 06 Jan 2009 19:02:54 | Changed component from None to Component #18 Changed assigned to from None to ckknight |
Facts
- Last updated on
- 03 Jun 2011
- Reported on
- 18 May 2008
- Status
- Accepted - Problem reproduced / Need acknowledged.
- Type
- Enhancement - A change which is intended to better the project in some way
- Priority
- Low - Might slip to a later milestone.
- Reply
- #11
Dashkal Wed, 28 May 2008 19:54:28That's what I was getting at. Should have made it more clear what I meant with <comment>
- Reply
- #10
Snago Wed, 28 May 2008 19:31:09It would be cool if it also posted the comment from CurseForge-86:<verb> <comment> in the automatic "update-ticket-comment" on the ticket.
- Reply
- #9
Kaelten Wed, 28 May 2008 19:20:47well I'm not against the multiple per line thing, since in some cases it would make sense. Use case is a base error that manifest differently in multiple place.
It also wouldn't have any major complications for implementation, any more thoughts or arguments against?
WowAce.com & CurseForge.com Adminstrator
Check out my new addon, OneChoice, it helps you pick quest rewards faster.
Developer of Ace3, OneBag3, and many other addons and libraries
Project lead and Mac developer for the Curse Client
- Reply
- #8
Dashkal Wed, 28 May 2008 19:14:13Updated description
- Reply
- #7
Dashkal Wed, 28 May 2008 19:10:30Hmm, liking the implied feature of commenting after the action.
CurseForge-86:<verb> <comment>
Dunno about the multiple in one line, but it isn't inherently bad either. Guess that would depend on how much Kaelten likes it.
Edit: One change per commit is really a per-project policy. Even if I do personally consider it a good habit.
- Reply
- #6
Snago Wed, 28 May 2008 18:59:28Making it a strict "CurseForge-86:" in the beginning of a commit message would still make it possible to talk about tickets (Like "I'm such a nub. Trying to fix ticket 86.") without it getting picked up and automaticly closing.
It would probably be good if there was some way to specify several tickets though. For example
and maybe even
- Reply
- #5
Dashkal Wed, 28 May 2008 18:45:19Perhaps: CurseForge-86: fixed/verify (to send to QA) CurseForge-86: fixed/closed (to just close outright) just :fixed would default to just close since most addons don't have qa teams
There isn't much else that can be done from this angle since closing as invalid or requesting more information is something best done at the ticket system rather than via pushing code to the repos.
- Reply
- #4
Kaelten Wed, 28 May 2008 18:41:43Question is how verbose the system should be. Should you be able to say that the revision is in response to the ticket but not closing it, or that another does close it, ect.
Is there other actions that'd be good to make enabled by this?
- Reply
- #3
Dashkal Wed, 28 May 2008 18:39:32I like. It's clear enough what the intention is and is unlikely to be hit accidentally.
- Reply
- #2
Kaelten Tue, 20 May 2008 00:40:04What I'd like to see is having to put something like: 'CurseForge-86:' at the beginning of the commit, thoughts?