CurseForge

86 - Request: special commit messages to interact with tickets

Suggest allowing special messages in commits to interact with the ticket system.

Example:
  "CurseForge-42: close" would close the ticket.

It may be a good thing to make the trigger statements strict.  It's (arguably) better to force the developer to be nice and explicit about closing tickets rather than trying to be automatic.  I'm thinking of this as an aid rather than an automatic system.

User When Change
Torhal Jul 24, 2013 at 20:02 UTC
Torhal Jun 03, 2011 at 16:56 UTC Changed assigned to from None to prencher
Ackis Feb 01, 2011 at 18:00 UTC Changed assigned to from ckknight to None
Ackis Apr 21, 2009 at 15:05 UTC Changed component from None to Component #18
Ackis Jan 06, 2009 at 19:02 UTC Changed component from None to Component #18

Changed assigned to from None to ckknight

You must login to post a comment. Don't have an account? Register to get one!

  • Avatar of Dashkal Dashkal May 28, 2008 at 19:54 UTC - 0 likes

    That's what I was getting at. Should have made it more clear what I meant with <comment>

  • Avatar of Snago Snago May 28, 2008 at 19:31 UTC - 0 likes

    It would be cool if it also posted the comment from CurseForge-86:<verb> <comment> in the automatic "update-ticket-comment" on the ticket.

  • Avatar of Kaelten Kaelten May 28, 2008 at 19:20 UTC - 0 likes

    well I'm not against the multiple per line thing, since in some cases it would make sense. Use case is a base error that manifest differently in multiple place.

    It also wouldn't have any major complications for implementation, any more thoughts or arguments against?

    WowAce.com & CurseForge.com Adminstrator
    Check out my new addon, OneChoice, it helps you pick quest rewards faster.
    Developer of Ace3, OneBag3, and many other addons and libraries
    Project lead and Mac developer for the Curse Client

  • Avatar of Dashkal Dashkal May 28, 2008 at 19:14 UTC - 0 likes

    Updated description

  • Avatar of Dashkal Dashkal May 28, 2008 at 19:10 UTC - 0 likes

    Hmm, liking the implied feature of commenting after the action.
    CurseForge-86:<verb> <comment>

    Dunno about the multiple in one line, but it isn't inherently bad either.  Guess that would depend on how much Kaelten likes it.
    Edit: One change per commit is really a per-project policy.  Even if I do personally consider it a good habit.

  • Avatar of Snago Snago May 28, 2008 at 18:59 UTC - 0 likes

    Making it a strict "CurseForge-86:" in the beginning of a commit message would still make it possible to talk about tickets (Like "I'm such a nub. Trying to fix ticket 86.") without it getting picked up and automaticly closing.

    It would probably be good if there was some way to specify several tickets though. For example

    CurseForge-86:fixed Stupid nil
    CurseForge-88:fixed Need more cofee
    

    and maybe even

    CurseForge-62,72,85:fixed I'm so skilled I can fix several tickets in one commit
    
  • Avatar of Dashkal Dashkal May 28, 2008 at 18:45 UTC - 0 likes

    Perhaps: CurseForge-86: fixed/verify (to send to QA) CurseForge-86: fixed/closed (to just close outright) just :fixed would default to just close since most addons don't have qa teams

    There isn't much else that can be done from this angle since closing as invalid or requesting more information is something best done at the ticket system rather than via pushing code to the repos.

  • Avatar of Kaelten Kaelten May 28, 2008 at 18:41 UTC - 0 likes

    Question is how verbose the system should be. Should you be able to say that the revision is in response to the ticket but not closing it, or that another does close it, ect.

    Is there other actions that'd be good to make enabled by this?

  • Avatar of Dashkal Dashkal May 28, 2008 at 18:39 UTC - 0 likes

    I like. It's clear enough what the intention is and is unlikely to be hit accidentally.

  • Avatar of Kaelten Kaelten May 20, 2008 at 00:40 UTC - 0 likes

    What I'd like to see is having to put something like: 'CurseForge-86:' at the beginning of the commit, thoughts?

Facts

Last updated
Jul 24, 2013
Reported
May 18, 2008
Status
Declined - We decided not to take action on this ticket.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Low - Might slip to a later milestone.
Votes
7

Reported by

Possible assignees