CurseForge

2669 - update mercurial to only package default

What is the enhancement in mind? How should it look and feel?

Please update the packager to package tags and the tip of the 'default' branch, leaving the experimental branches alone.

Please provide any additional information below.

What is the enhancement in mind? How should it look and feel?

I ran an experiment at http://hg.wowace.com/wow/itemauditor/asaayers/graph/ where I created two new branches and left default alone. The packager packaged every tag, and then tip, which happened to be a branch. This means that I can't reliably use in-repository branches for my experimental features.

It looks like this could easily be accomplished by replacing instances of 'tip' in hg.py with 'default'. I'm sure that is the case for all the lines that look like:
hg('update', '-C', 'tip', cwd=self.checkout_path
I'm not sure about line 139, 149

Name Description Size MD5
2669-UpdateMercurialToOnlyPackageDefault.hg Mercurial Bundle of my patch 911 B 1f8fbfbb1616...
User When Change
Torhal Jul 24, 2013 at 16:20 UTC
Torhal Nov 08, 2011 at 18:29 UTC
Torhal Jun 03, 2011 at 17:03 UTC Changed assigned to from None to prencher
Ackis Feb 01, 2011 at 18:02 UTC Changed assigned to from ckknight to None
AsaAyers Dec 04, 2010 at 17:31 UTC

Added attachment 2669-UpdateMercurialToOnlyPackageDefault.hg

AsaAyers Dec 04, 2010 at 17:23 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 1 comment
  • Avatar of AsaAyers AsaAyers Dec 04, 2010 at 17:33 UTC - 0 likes

    After reviewing the code a bit more, I believe the hg('update', '-C', 'tip', cwd=self.checkout_path) at the end of several functions should probably stay. I'm not 100% sure what they are for, but it appears it will keep the repository in a more consistent state between runs.

    I have attached a mercurial bundle of my proposed change. I haven't figured out how I can run the packager locally, so I am unable to test my change at this time.

  • 1 comment

Facts

Last updated
Jul 24, 2013
Reported
Dec 04, 2010
Status
Declined - We decided not to take action on this ticket.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
2

Reported by

Possible assignees