CurseForge.com

CurseForge

197 - git commit hook can be defeated

What steps will reproduce the problem?
1. Commit the bad file
2. Create a tag pointing at that commit
3. Commit a second commit removing the file
4. Push the stack to curseforge

What is the expected output? What do you see instead?
Expected: The commit hook to choke on the offending commit
Actual: The stack was committed just fine (I did not actually test pushing the tag, but I see no reason why it would be rejected -- I just didn't want anything syndicating to curse).

What version of the product are you using?
May 28th

Do you have an error log of what happened?
No -- The operation was successful.

Please provide any additional information below.
Suggest reworking the script to validate each commit one-by-one rather than in aggregate.

User When Change

You must login to post a comment. Don't have an account? Register to get one!

  • 4 comments
  • 4 comments

Facts

Last updated on
11 Jun 2008
Reported on
28 May 2008
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
High - Strongly want to resolve in the specified milestone.

Reported by

Possible assignees

Votes (Total: +9, Average: +3.0)