197 - git commit hook can be defeated
What steps will reproduce the problem?
1. Commit the bad file
2. Create a tag pointing at that commit
3. Commit a second commit removing the file
4. Push the stack to curseforge
What is the expected output? What do you see instead?
Expected: The commit hook to choke on the offending commit
Actual: The stack was committed just fine (I did not actually test pushing the tag, but I see no reason why it would be rejected -- I just didn't want anything syndicating to curse).
What version of the product are you using?
May 28th
Do you have an error log of what happened?
No -- The operation was successful.
Please provide any additional information below.
Suggest reworking the script to validate each commit one-by-one rather than in aggregate.
| User | When | Change |
|---|
- 4 comments
- 4 comments
Facts
- Last updated on
- 11 Jun 2008
- Reported on
- 28 May 2008
- Status
- Fixed - Developer made requested changes. QA should verify.
- Type
- Defect - A shortcoming, fault, or imperfection
- Priority
- High - Strongly want to resolve in the specified milestone.
- Reply
- #4
ckknight Wed, 11 Jun 2008 15:54:52Changed status from 'New' to 'Fixed'
- Reply
- #3
Dashkal Thu, 29 May 2008 18:49:41http://www.curseforge.com/projects/curseforge/tickets/196/ is a symptom of this issue.
- Reply
- #2
Kaelten Thu, 29 May 2008 13:36:54Assign ticket to ckknight
WowAce.com & CurseForge.com Adminstrator
Check out my new addon, OneChoice, it helps you pick quest rewards faster.
Developer of Ace3, OneBag3, and many other addons and libraries
Project lead and Mac developer for the Curse Client
- Reply
- #1
Dashkal Wed, 28 May 2008 21:36:43Updated description