196 - Git commit hooks do not specify which commit was rejected in batch pushes
What steps will reproduce the problem?
1. Commit multiple changes to the local git repository (one of these should be bad -- touching a .exe file, for example)
2. Push them all to origin as a batch
What is the expected output? What do you see instead?
Expected: a notice on the hook rejection message of which commit was rejected
Actual: Entire push rejected (which is fine) but with no notice of which specific commit was rejected
What version of the product are you using?
Current as of May 28th
Do you have an error log of what happened?
$ git push
Counting objects: 10, done.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (8/8), 936 bytes, done.
Total 8 (delta 1), reused 0 (delta 0)
You are not allowed to make changes to ".exe"-type files:
hooks/update.d/prevent-bad-filetypes.py
error: hooks/update exited with error code 1
error: hook declined to update refs/heads/master
Please provide any additional information below.
Context: a new project http://wow.curseforge.com/projects/cfcommittest/ with a single file in the repos called "readme.txt";
The specific set of commits for that test was:
1) Modified the readme text file
2) Copied the text file to "bad.exe";
3) Modified the text file again
| User | When | Change |
|---|
- 2 comments
- 2 comments
Facts
- Last updated on
- 11 Jun 2008
- Reported on
- 28 May 2008
- Status
- Fixed - Developer made requested changes. QA should verify.
- Type
- Defect - A shortcoming, fault, or imperfection
- Priority
- Medium - Normal priority.
- Reply
- #2
ckknight Wed, 11 Jun 2008 16:04:20Changed status from 'New' to 'Fixed'
- Reply
- #1
ckknight Wed, 11 Jun 2008 16:04:15Assign ticket to ckknight